Uh oh!
There was an error while loading. Please reload this page.
Print query stack on ICEs - #49222
Merged
Merged
Conversation
emilyalbini
commented
Mar 26, 2018
Member
Can we get a review on this PR @eddyb (or someone else from @rust-lang/compiler)? |
eddyb
commented
Mar 26, 2018
Contributor
LGTM. r? @nikomatsakis |
nagisa
commented
Mar 27, 2018
Member
I think it would be preferable if we did this only when |
nikomatsakis
commented
Apr 4, 2018
Contributor
Hmm I think I agree with @nagisa -- this feels like a ton of output to dump by default. But it seems very useful! |
Zoxc
commented
Apr 5, 2018
ContributorAuthor
I've changed it so it only prints the query stack when |
bors
commented
Apr 5, 2018
Collaborator
☔ The latest upstream changes (presumably #49045) made this pull request unmergeable. Please resolve the merge conflicts. |
TimNN
commented
Apr 6, 2018
Contributor
Your PR failed on Travis. Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
TimNN
commented
Apr 6, 2018
Contributor
Your PR failed on Travis. Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
nikomatsakis
commented
Apr 6, 2018
Contributor
@bors r+ |
bors
commented
Apr 6, 2018
Collaborator
📌 Commit 4fd188e has been approved by |
bors
commented
Apr 7, 2018
Collaborator
bors added a commit
that referenced
this pull request
Apr 7, 2018
Print query stack on ICEs
ICE output is now:
```
thread 'rustc' panicked at 'no borrowck', librustc_borrowck\borrowck\mod.rs:95:5
note: Run with `RUST_BACKTRACE=1` for a backtrace.
query stack during panic:
#0 [borrowck] processing `main`
--> no-std.rs:10:1
|
10 | fn main() {}
| ^^^^^^^^^
end of query stack
error: internal compiler error: unexpected panic
note: the compiler unexpectedly panicked. this is a bug.
note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
note: rustc 1.26.0-dev running on x86_64-pc-windows-msvc
```
Fixes#42529.
r? @eddybbors
commented
Apr 7, 2018
Collaborator
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ICE output is now:
Fixes#42529.
r? @eddyb