Skip to content

Rustdoc support for universal_impl_trait - #49304

Merged
bors merged 4 commits into
rust-lang:masterfrom
sinkuu:impl_trait_rustdoc
Mar 28, 2018
Merged

Rustdoc support for universal_impl_trait#49304
bors merged 4 commits into
rust-lang:masterfrom
sinkuu:impl_trait_rustdoc

Conversation

@sinkuu

@sinkuusinkuu commented Mar 23, 2018•
edited
Loading

Copy link
Copy Markdown
Contributor

Hides type parameters synthesized by impl Trait-in-argument-position, and enables links to trait names.

before

↓

after

Fixes#49309

@rust-highfive

rust-highfive commented Mar 23, 2018

Copy link
Copy Markdown
Contributor

r? @QuietMisdreavus

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 23, 2018
@sinkuu

sinkuu commented Mar 23, 2018

Copy link
Copy Markdown
ContributorAuthor

Ah, no, this does not work if impl Debug is not the argument type directly, e.g. fn foo(x: (impl Debug, i32)).

@sinkuusinkuu closed this Mar 23, 2018
@QuietMisdreavus

QuietMisdreavus commented Mar 23, 2018

Copy link
Copy Markdown
Contributor

Ah, i was starting to read through it. Looking forward to seeing if you can get it working!

Also, it doesn't really require the other PR. It's okay to expose features in rustdoc that are unstable, because they'll only be there in the first place if the library enabled the feature. Other unstable features have been exposed in rustdoc before they were stable, and it's not like the other commits changed anything that rustdoc depends on.

@sinkuusinkuu mentioned this pull request Mar 23, 2018
Closed
@sinkuusinkuu reopened this Mar 24, 2018
@sinkuu
sinkuuforce-pushed the impl_trait_rustdoc branch from 7bc7fbe to 4800afaCompareMarch 24, 2018 05:19
@QuietMisdreavus

QuietMisdreavus commented Mar 27, 2018

Copy link
Copy Markdown
Contributor

This looks great! Thanks so much!

@bors r+

@bors

bors commented Mar 27, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 4800afa has been approved by QuietMisdreavus

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 27, 2018
@kennytm

kennytm commented Mar 27, 2018

Copy link
Copy Markdown
Member

@bors p=6

@bors

bors commented Mar 28, 2018

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 4800afa with merge e58df0d...

bors added a commit that referenced this pull request Mar 28, 2018
@bors
Auto merge of#49304- sinkuu:impl_trait_rustdoc, r=QuietMisdreavus
e58df0d
Rustdoc support for universal_impl_trait
Hides type parameters synthesized by `impl Trait`-in-argument-position, and enables links to trait names.
<img alt="before" src="https://user-images.githubusercontent.com/7091080/37831646-a61413c6-2ee9-11e8-8ec2-a6137956d922.png" width="450"/>
↓
<img alt="after" src="https://user-images.githubusercontent.com/7091080/37831657-b2ff0ae6-2ee9-11e8-8797-fdad904782bf.png" width="450"/>
Fixes#49309
@bors

bors commented Mar 28, 2018

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-appveyor, status-travis
Approved by: QuietMisdreavus
Pushing e58df0d to master...

@bors
bors merged commit 4800afa into rust-lang:masterMar 28, 2018
@QuietMisdreavusQuietMisdreavus mentioned this pull request May 2, 2018
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@QuietMisdreavusQuietMisdreavus

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sinkuu@rust-highfive@QuietMisdreavus@bors@kennytm