Skip to content

Add a test for the fix to issue #43058 - #49634

Merged
alexcrichton merged 2 commits into
rust-lang:masterfrom
lloydmeta:tests/issue-43058
Apr 5, 2018
Merged

Add a test for the fix to issue #43058#49634
alexcrichton merged 2 commits into
rust-lang:masterfrom
lloydmeta:tests/issue-43058

Conversation

@lloydmeta

@lloydmetalloydmeta commented Apr 4, 2018

Copy link
Copy Markdown
Contributor

Followed the instructions laid out here #43058 (comment)

r? @nikomatsakis

@TimNN

TimNN commented Apr 4, 2018

Copy link
Copy Markdown
Contributor

Your PR failed on Travis. Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[00:00:46] configure: rust.quiet-tests := True
---
[00:04:20] tidy error: /checkout/src/test/ui/nll/issue-43058.rs: incorrect license
[00:04:20] tidy error: /checkout/src/test/ui/nll/issue-43058.rs: missing trailing newline
---
113676 ./obj/build/bootstrap/debug/incremental/bootstrap-171j8p2wafl95/s-ezsf4xl341-1dury5j-gd1ykehqltr2

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN.

@emilyalbiniemilyalbini added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 4, 2018
@nikomatsakis

Copy link
Copy Markdown
Contributor

@bors r+ rollup -- thanks!

@bors

bors commented Apr 4, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit f2cc501 has been approved by nikomatsakis

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 4, 2018
@kennytmkennytm mentioned this pull request Apr 4, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Apr 4, 2018
…matsakis
Add a test for the fix to issue rust-lang#43058
Followed the instructions laid out here rust-lang#43058 (comment)
bors added a commit that referenced this pull request Apr 4, 2018
Rollup of 25 pull requests
Successful merges:
- #49179 (Handle future deprecation annotations )
- #49512 (Add support for variant and types fields for intra links)
- #49515 (fix targetted value background)
- #49516 (Add missing anchor for union type fields)
- #49532 (Add test for rustdoc ignore test)
- #49533 (Add #[must_use] to a few standard library methods)
- #49540 (Fix miri Discriminant() for non-ADT)
- #49559 (Introduce Vec::resize_with method (see #41758))
- #49570 (avoid IdxSets containing garbage above the universe length)
- #49577 (Stabilize String::replace_range)
- #49599 (Fix typo)
- #49603 (Fix url for intra link provided method)
- #49607 (Stabilize iterator methods in 1.27)
- #49609 (run-pass/attr-stmt-expr: expand test cases)
- #49612 (Fix "since" version for getpid feature.)
- #49618 (Fix build error when compiling libcore for 16bit targets)
- #49619 (tweak core::fmt docs)
- #49637 (Stabilize parent_id())
- #49639 (Update Cargo)
- #49628 (Re-write the documentation index)
- #49594 (Add some performance guidance to std::fs and std::io docs)
- #49625 (miri: add public alloc_kind accessor)
- #49634 (Add a test for the fix to issue #43058)
- #49641 (Regression test for #46314)
- #49547 (Unignore borrowck test)
Failed merges:
@alexcrichton
alexcrichton merged commit f2cc501 into rust-lang:masterApr 5, 2018
@lloydmeta
lloydmeta deleted the tests/issue-43058 branch April 5, 2018 03:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@lloydmeta@TimNN@nikomatsakis@bors@alexcrichton@emilyalbini
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Add a test for the fix to issue #43058 by lloydmeta · Pull Request #49634 · rust-lang/rust · GitHub
Skip to content

Add a test for the fix to issue #43058 - #49634

Merged
alexcrichton merged 2 commits into
rust-lang:masterfrom
lloydmeta:tests/issue-43058
Apr 5, 2018
Merged

Add a test for the fix to issue #43058#49634
alexcrichton merged 2 commits into
rust-lang:masterfrom
lloydmeta:tests/issue-43058

Conversation

@lloydmeta

@lloydmetalloydmeta commented Apr 4, 2018

Copy link
Copy Markdown
Contributor

Followed the instructions laid out here #43058 (comment)

r? @nikomatsakis

@TimNN

TimNN commented Apr 4, 2018

Copy link
Copy Markdown
Contributor

Your PR failed on Travis. Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[00:00:46] configure: rust.quiet-tests := True
---
[00:04:20] tidy error: /checkout/src/test/ui/nll/issue-43058.rs: incorrect license
[00:04:20] tidy error: /checkout/src/test/ui/nll/issue-43058.rs: missing trailing newline
---
113676 ./obj/build/bootstrap/debug/incremental/bootstrap-171j8p2wafl95/s-ezsf4xl341-1dury5j-gd1ykehqltr2

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN.

@emilyalbiniemilyalbini added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 4, 2018
@nikomatsakis

Copy link
Copy Markdown
Contributor

@bors r+ rollup -- thanks!

@bors

bors commented Apr 4, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit f2cc501 has been approved by nikomatsakis

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 4, 2018
@kennytmkennytm mentioned this pull request Apr 4, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Apr 4, 2018
…matsakis
Add a test for the fix to issue rust-lang#43058
Followed the instructions laid out here rust-lang#43058 (comment)
bors added a commit that referenced this pull request Apr 4, 2018
Rollup of 25 pull requests
Successful merges:
- #49179 (Handle future deprecation annotations )
- #49512 (Add support for variant and types fields for intra links)
- #49515 (fix targetted value background)
- #49516 (Add missing anchor for union type fields)
- #49532 (Add test for rustdoc ignore test)
- #49533 (Add #[must_use] to a few standard library methods)
- #49540 (Fix miri Discriminant() for non-ADT)
- #49559 (Introduce Vec::resize_with method (see #41758))
- #49570 (avoid IdxSets containing garbage above the universe length)
- #49577 (Stabilize String::replace_range)
- #49599 (Fix typo)
- #49603 (Fix url for intra link provided method)
- #49607 (Stabilize iterator methods in 1.27)
- #49609 (run-pass/attr-stmt-expr: expand test cases)
- #49612 (Fix "since" version for getpid feature.)
- #49618 (Fix build error when compiling libcore for 16bit targets)
- #49619 (tweak core::fmt docs)
- #49637 (Stabilize parent_id())
- #49639 (Update Cargo)
- #49628 (Re-write the documentation index)
- #49594 (Add some performance guidance to std::fs and std::io docs)
- #49625 (miri: add public alloc_kind accessor)
- #49634 (Add a test for the fix to issue #43058)
- #49641 (Regression test for #46314)
- #49547 (Unignore borrowck test)
Failed merges:
@alexcrichton
alexcrichton merged commit f2cc501 into rust-lang:masterApr 5, 2018
@lloydmeta
lloydmeta deleted the tests/issue-43058 branch April 5, 2018 03:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@lloydmeta@TimNN@nikomatsakis@bors@alexcrichton@emilyalbini
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Add a test for the fix to issue #43058 by lloydmeta · Pull Request #49634 · rust-lang/rust · GitHub
Skip to content

Add a test for the fix to issue #43058 - #49634

Merged
alexcrichton merged 2 commits into
rust-lang:masterfrom
lloydmeta:tests/issue-43058
Apr 5, 2018
Merged

Add a test for the fix to issue #43058#49634
alexcrichton merged 2 commits into
rust-lang:masterfrom
lloydmeta:tests/issue-43058

Conversation

@lloydmeta

@lloydmetalloydmeta commented Apr 4, 2018

Copy link
Copy Markdown
Contributor

Followed the instructions laid out here #43058 (comment)

r? @nikomatsakis

@TimNN

TimNN commented Apr 4, 2018

Copy link
Copy Markdown
Contributor

Your PR failed on Travis. Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[00:00:46] configure: rust.quiet-tests := True
---
[00:04:20] tidy error: /checkout/src/test/ui/nll/issue-43058.rs: incorrect license
[00:04:20] tidy error: /checkout/src/test/ui/nll/issue-43058.rs: missing trailing newline
---
113676 ./obj/build/bootstrap/debug/incremental/bootstrap-171j8p2wafl95/s-ezsf4xl341-1dury5j-gd1ykehqltr2

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN.

@emilyalbiniemilyalbini added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 4, 2018
@nikomatsakis

Copy link
Copy Markdown
Contributor

@bors r+ rollup -- thanks!

@bors

bors commented Apr 4, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit f2cc501 has been approved by nikomatsakis

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 4, 2018
@kennytmkennytm mentioned this pull request Apr 4, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Apr 4, 2018
…matsakis
Add a test for the fix to issue rust-lang#43058
Followed the instructions laid out here rust-lang#43058 (comment)
bors added a commit that referenced this pull request Apr 4, 2018
Rollup of 25 pull requests
Successful merges:
- #49179 (Handle future deprecation annotations )
- #49512 (Add support for variant and types fields for intra links)
- #49515 (fix targetted value background)
- #49516 (Add missing anchor for union type fields)
- #49532 (Add test for rustdoc ignore test)
- #49533 (Add #[must_use] to a few standard library methods)
- #49540 (Fix miri Discriminant() for non-ADT)
- #49559 (Introduce Vec::resize_with method (see #41758))
- #49570 (avoid IdxSets containing garbage above the universe length)
- #49577 (Stabilize String::replace_range)
- #49599 (Fix typo)
- #49603 (Fix url for intra link provided method)
- #49607 (Stabilize iterator methods in 1.27)
- #49609 (run-pass/attr-stmt-expr: expand test cases)
- #49612 (Fix "since" version for getpid feature.)
- #49618 (Fix build error when compiling libcore for 16bit targets)
- #49619 (tweak core::fmt docs)
- #49637 (Stabilize parent_id())
- #49639 (Update Cargo)
- #49628 (Re-write the documentation index)
- #49594 (Add some performance guidance to std::fs and std::io docs)
- #49625 (miri: add public alloc_kind accessor)
- #49634 (Add a test for the fix to issue #43058)
- #49641 (Regression test for #46314)
- #49547 (Unignore borrowck test)
Failed merges:
@alexcrichton
alexcrichton merged commit f2cc501 into rust-lang:masterApr 5, 2018
@lloydmeta
lloydmeta deleted the tests/issue-43058 branch April 5, 2018 03:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@lloydmeta@TimNN@nikomatsakis@bors@alexcrichton@emilyalbini
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Add a test for the fix to issue #43058 by lloydmeta · Pull Request #49634 · rust-lang/rust · GitHub
Skip to content

Add a test for the fix to issue #43058 - #49634

Merged
alexcrichton merged 2 commits into
rust-lang:masterfrom
lloydmeta:tests/issue-43058
Apr 5, 2018
Merged

Add a test for the fix to issue #43058#49634
alexcrichton merged 2 commits into
rust-lang:masterfrom
lloydmeta:tests/issue-43058

Conversation

@lloydmeta

@lloydmetalloydmeta commented Apr 4, 2018

Copy link
Copy Markdown
Contributor

Followed the instructions laid out here #43058 (comment)

r? @nikomatsakis

@TimNN

TimNN commented Apr 4, 2018

Copy link
Copy Markdown
Contributor

Your PR failed on Travis. Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[00:00:46] configure: rust.quiet-tests := True
---
[00:04:20] tidy error: /checkout/src/test/ui/nll/issue-43058.rs: incorrect license
[00:04:20] tidy error: /checkout/src/test/ui/nll/issue-43058.rs: missing trailing newline
---
113676 ./obj/build/bootstrap/debug/incremental/bootstrap-171j8p2wafl95/s-ezsf4xl341-1dury5j-gd1ykehqltr2

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN.

@emilyalbiniemilyalbini added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 4, 2018
@nikomatsakis

Copy link
Copy Markdown
Contributor

@bors r+ rollup -- thanks!

@bors

bors commented Apr 4, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit f2cc501 has been approved by nikomatsakis

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 4, 2018
@kennytmkennytm mentioned this pull request Apr 4, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Apr 4, 2018
…matsakis
Add a test for the fix to issue rust-lang#43058
Followed the instructions laid out here rust-lang#43058 (comment)
bors added a commit that referenced this pull request Apr 4, 2018
Rollup of 25 pull requests
Successful merges:
- #49179 (Handle future deprecation annotations )
- #49512 (Add support for variant and types fields for intra links)
- #49515 (fix targetted value background)
- #49516 (Add missing anchor for union type fields)
- #49532 (Add test for rustdoc ignore test)
- #49533 (Add #[must_use] to a few standard library methods)
- #49540 (Fix miri Discriminant() for non-ADT)
- #49559 (Introduce Vec::resize_with method (see #41758))
- #49570 (avoid IdxSets containing garbage above the universe length)
- #49577 (Stabilize String::replace_range)
- #49599 (Fix typo)
- #49603 (Fix url for intra link provided method)
- #49607 (Stabilize iterator methods in 1.27)
- #49609 (run-pass/attr-stmt-expr: expand test cases)
- #49612 (Fix "since" version for getpid feature.)
- #49618 (Fix build error when compiling libcore for 16bit targets)
- #49619 (tweak core::fmt docs)
- #49637 (Stabilize parent_id())
- #49639 (Update Cargo)
- #49628 (Re-write the documentation index)
- #49594 (Add some performance guidance to std::fs and std::io docs)
- #49625 (miri: add public alloc_kind accessor)
- #49634 (Add a test for the fix to issue #43058)
- #49641 (Regression test for #46314)
- #49547 (Unignore borrowck test)
Failed merges:
@alexcrichton
alexcrichton merged commit f2cc501 into rust-lang:masterApr 5, 2018
@lloydmeta
lloydmeta deleted the tests/issue-43058 branch April 5, 2018 03:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@lloydmeta@TimNN@nikomatsakis@bors@alexcrichton@emilyalbini
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' Add a test for the fix to issue #43058 by lloydmeta · Pull Request #49634 · rust-lang/rust · GitHub
Skip to content

Add a test for the fix to issue #43058 - #49634

Merged
alexcrichton merged 2 commits into
rust-lang:masterfrom
lloydmeta:tests/issue-43058
Apr 5, 2018
Merged

Add a test for the fix to issue #43058#49634
alexcrichton merged 2 commits into
rust-lang:masterfrom
lloydmeta:tests/issue-43058

Conversation

@lloydmeta

@lloydmetalloydmeta commented Apr 4, 2018

Copy link
Copy Markdown
Contributor

Followed the instructions laid out here #43058 (comment)

r? @nikomatsakis

@TimNN

TimNN commented Apr 4, 2018

Copy link
Copy Markdown
Contributor

Your PR failed on Travis. Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[00:00:46] configure: rust.quiet-tests := True
---
[00:04:20] tidy error: /checkout/src/test/ui/nll/issue-43058.rs: incorrect license
[00:04:20] tidy error: /checkout/src/test/ui/nll/issue-43058.rs: missing trailing newline
---
113676 ./obj/build/bootstrap/debug/incremental/bootstrap-171j8p2wafl95/s-ezsf4xl341-1dury5j-gd1ykehqltr2

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN.

@emilyalbiniemilyalbini added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 4, 2018
@nikomatsakis

Copy link
Copy Markdown
Contributor

@bors r+ rollup -- thanks!

@bors

bors commented Apr 4, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit f2cc501 has been approved by nikomatsakis

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 4, 2018
@kennytmkennytm mentioned this pull request Apr 4, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Apr 4, 2018
…matsakis
Add a test for the fix to issue rust-lang#43058
Followed the instructions laid out here rust-lang#43058 (comment)
bors added a commit that referenced this pull request Apr 4, 2018
Rollup of 25 pull requests
Successful merges:
- #49179 (Handle future deprecation annotations )
- #49512 (Add support for variant and types fields for intra links)
- #49515 (fix targetted value background)
- #49516 (Add missing anchor for union type fields)
- #49532 (Add test for rustdoc ignore test)
- #49533 (Add #[must_use] to a few standard library methods)
- #49540 (Fix miri Discriminant() for non-ADT)
- #49559 (Introduce Vec::resize_with method (see #41758))
- #49570 (avoid IdxSets containing garbage above the universe length)
- #49577 (Stabilize String::replace_range)
- #49599 (Fix typo)
- #49603 (Fix url for intra link provided method)
- #49607 (Stabilize iterator methods in 1.27)
- #49609 (run-pass/attr-stmt-expr: expand test cases)
- #49612 (Fix "since" version for getpid feature.)
- #49618 (Fix build error when compiling libcore for 16bit targets)
- #49619 (tweak core::fmt docs)
- #49637 (Stabilize parent_id())
- #49639 (Update Cargo)
- #49628 (Re-write the documentation index)
- #49594 (Add some performance guidance to std::fs and std::io docs)
- #49625 (miri: add public alloc_kind accessor)
- #49634 (Add a test for the fix to issue #43058)
- #49641 (Regression test for #46314)
- #49547 (Unignore borrowck test)
Failed merges:
@alexcrichton
alexcrichton merged commit f2cc501 into rust-lang:masterApr 5, 2018
@lloydmeta
lloydmeta deleted the tests/issue-43058 branch April 5, 2018 03:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@lloydmeta@TimNN@nikomatsakis@bors@alexcrichton@emilyalbini
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Add a test for the fix to issue #43058 by lloydmeta · Pull Request #49634 · rust-lang/rust · GitHub
Skip to content

Add a test for the fix to issue #43058 - #49634

Merged
alexcrichton merged 2 commits into
rust-lang:masterfrom
lloydmeta:tests/issue-43058
Apr 5, 2018
Merged

Add a test for the fix to issue #43058#49634
alexcrichton merged 2 commits into
rust-lang:masterfrom
lloydmeta:tests/issue-43058

Conversation

@lloydmeta

@lloydmetalloydmeta commented Apr 4, 2018

Copy link
Copy Markdown
Contributor

Followed the instructions laid out here #43058 (comment)

r? @nikomatsakis

@TimNN

TimNN commented Apr 4, 2018

Copy link
Copy Markdown
Contributor

Your PR failed on Travis. Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[00:00:46] configure: rust.quiet-tests := True
---
[00:04:20] tidy error: /checkout/src/test/ui/nll/issue-43058.rs: incorrect license
[00:04:20] tidy error: /checkout/src/test/ui/nll/issue-43058.rs: missing trailing newline
---
113676 ./obj/build/bootstrap/debug/incremental/bootstrap-171j8p2wafl95/s-ezsf4xl341-1dury5j-gd1ykehqltr2

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN.

@emilyalbiniemilyalbini added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 4, 2018
@nikomatsakis

Copy link
Copy Markdown
Contributor

@bors r+ rollup -- thanks!

@bors

bors commented Apr 4, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit f2cc501 has been approved by nikomatsakis

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 4, 2018
@kennytmkennytm mentioned this pull request Apr 4, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Apr 4, 2018
…matsakis
Add a test for the fix to issue rust-lang#43058
Followed the instructions laid out here rust-lang#43058 (comment)
bors added a commit that referenced this pull request Apr 4, 2018
Rollup of 25 pull requests
Successful merges:
- #49179 (Handle future deprecation annotations )
- #49512 (Add support for variant and types fields for intra links)
- #49515 (fix targetted value background)
- #49516 (Add missing anchor for union type fields)
- #49532 (Add test for rustdoc ignore test)
- #49533 (Add #[must_use] to a few standard library methods)
- #49540 (Fix miri Discriminant() for non-ADT)
- #49559 (Introduce Vec::resize_with method (see #41758))
- #49570 (avoid IdxSets containing garbage above the universe length)
- #49577 (Stabilize String::replace_range)
- #49599 (Fix typo)
- #49603 (Fix url for intra link provided method)
- #49607 (Stabilize iterator methods in 1.27)
- #49609 (run-pass/attr-stmt-expr: expand test cases)
- #49612 (Fix "since" version for getpid feature.)
- #49618 (Fix build error when compiling libcore for 16bit targets)
- #49619 (tweak core::fmt docs)
- #49637 (Stabilize parent_id())
- #49639 (Update Cargo)
- #49628 (Re-write the documentation index)
- #49594 (Add some performance guidance to std::fs and std::io docs)
- #49625 (miri: add public alloc_kind accessor)
- #49634 (Add a test for the fix to issue #43058)
- #49641 (Regression test for #46314)
- #49547 (Unignore borrowck test)
Failed merges:
@alexcrichton
alexcrichton merged commit f2cc501 into rust-lang:masterApr 5, 2018
@lloydmeta
lloydmeta deleted the tests/issue-43058 branch April 5, 2018 03:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@lloydmeta@TimNN@nikomatsakis@bors@alexcrichton@emilyalbini
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Add a test for the fix to issue #43058 by lloydmeta · Pull Request #49634 · rust-lang/rust · GitHub
Skip to content

Add a test for the fix to issue #43058 - #49634

Merged
alexcrichton merged 2 commits into
rust-lang:masterfrom
lloydmeta:tests/issue-43058
Apr 5, 2018
Merged

Add a test for the fix to issue #43058#49634
alexcrichton merged 2 commits into
rust-lang:masterfrom
lloydmeta:tests/issue-43058

Conversation

@lloydmeta

@lloydmetalloydmeta commented Apr 4, 2018

Copy link
Copy Markdown
Contributor

Followed the instructions laid out here #43058 (comment)

r? @nikomatsakis

@TimNN

TimNN commented Apr 4, 2018

Copy link
Copy Markdown
Contributor

Your PR failed on Travis. Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[00:00:46] configure: rust.quiet-tests := True
---
[00:04:20] tidy error: /checkout/src/test/ui/nll/issue-43058.rs: incorrect license
[00:04:20] tidy error: /checkout/src/test/ui/nll/issue-43058.rs: missing trailing newline
---
113676 ./obj/build/bootstrap/debug/incremental/bootstrap-171j8p2wafl95/s-ezsf4xl341-1dury5j-gd1ykehqltr2

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN.

@emilyalbiniemilyalbini added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 4, 2018
@nikomatsakis

Copy link
Copy Markdown
Contributor

@bors r+ rollup -- thanks!

@bors

bors commented Apr 4, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit f2cc501 has been approved by nikomatsakis

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 4, 2018
@kennytmkennytm mentioned this pull request Apr 4, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Apr 4, 2018
…matsakis
Add a test for the fix to issue rust-lang#43058
Followed the instructions laid out here rust-lang#43058 (comment)
bors added a commit that referenced this pull request Apr 4, 2018
Rollup of 25 pull requests
Successful merges:
- #49179 (Handle future deprecation annotations )
- #49512 (Add support for variant and types fields for intra links)
- #49515 (fix targetted value background)
- #49516 (Add missing anchor for union type fields)
- #49532 (Add test for rustdoc ignore test)
- #49533 (Add #[must_use] to a few standard library methods)
- #49540 (Fix miri Discriminant() for non-ADT)
- #49559 (Introduce Vec::resize_with method (see #41758))
- #49570 (avoid IdxSets containing garbage above the universe length)
- #49577 (Stabilize String::replace_range)
- #49599 (Fix typo)
- #49603 (Fix url for intra link provided method)
- #49607 (Stabilize iterator methods in 1.27)
- #49609 (run-pass/attr-stmt-expr: expand test cases)
- #49612 (Fix "since" version for getpid feature.)
- #49618 (Fix build error when compiling libcore for 16bit targets)
- #49619 (tweak core::fmt docs)
- #49637 (Stabilize parent_id())
- #49639 (Update Cargo)
- #49628 (Re-write the documentation index)
- #49594 (Add some performance guidance to std::fs and std::io docs)
- #49625 (miri: add public alloc_kind accessor)
- #49634 (Add a test for the fix to issue #43058)
- #49641 (Regression test for #46314)
- #49547 (Unignore borrowck test)
Failed merges:
@alexcrichton
alexcrichton merged commit f2cc501 into rust-lang:masterApr 5, 2018
@lloydmeta
lloydmeta deleted the tests/issue-43058 branch April 5, 2018 03:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@lloydmeta@TimNN@nikomatsakis@bors@alexcrichton@emilyalbini