Skip to content

std: Inline some Termination-related methods - #49702

Merged
bors merged 1 commit into
rust-lang:masterfrom
alexcrichton:inline-methods
Apr 7, 2018
Merged

std: Inline some Termination-related methods#49702
bors merged 1 commit into
rust-lang:masterfrom
alexcrichton:inline-methods

Conversation

@alexcrichton

Copy link
Copy Markdown
Member

These were showing up in tests and in binaries but are trivially optimize-able
away, so add #[inline] attributes so LLVM has an opportunity to optimize them
out.

These were showing up in tests and in binaries but are trivially optimize-able
away, so add `#[inline]` attributes so LLVM has an opportunity to optimize them
out.

@scottmcmscottmcm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Mark-Simulacrum

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Apr 5, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 323f808 has been approved by Mark-Simulacrum

@borsbors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 5, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Apr 6, 2018
…-Simulacrum
std: Inline some Termination-related methods
These were showing up in tests and in binaries but are trivially optimize-able
away, so add `#[inline]` attributes so LLVM has an opportunity to optimize them
out.
@kennytmkennytm mentioned this pull request Apr 6, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Apr 7, 2018
…-Simulacrum
std: Inline some Termination-related methods
These were showing up in tests and in binaries but are trivially optimize-able
away, so add `#[inline]` attributes so LLVM has an opportunity to optimize them
out.
@kennytmkennytm mentioned this pull request Apr 7, 2018
bors added a commit that referenced this pull request Apr 7, 2018
Rollup of 9 pull requests
Successful merges:
- #49510 (Fix anchor position on fields)
- #49652 (Fix anchors issue when everything is collapsed)
- #49702 (std: Inline some Termination-related methods)
- #49728 (add emit_debug_gdb_scripts target option and ..)
- #49731 (add THUMB targets to rustup manifest)
- #49742 (Using X headings instead of 0.X #49739)
- #49748 (proc_macro: Improve Debug representations)
- #49750 (bootstrap: Remove the fast path)
- #49503 (Inject the `compiler_builtins` crate whenever the `core` crate is injected)
Failed merges:
@bors
bors merged commit 323f808 into rust-lang:masterApr 7, 2018
@alexcrichton
alexcrichton deleted the inline-methods branch April 20, 2018 06:03
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@alexcrichton@Mark-Simulacrum@bors@scottmcm