Uh oh!
There was an error while loading. Please reload this page.
don't see issue #0 - #49985
Merged
Merged
Conversation
The unstable-feature attribute requires an issue (neglecting it is E0547), which gets used in the error messages. Unfortunately, there are some cases where "0" is apparently used a placeholder where no issue exists, directing the user to see the (nonexistent) issue #0. (It would have been better to either let `issue` be optional—compare to how issue is an `Option<u32>` in the feature-gate declarations in libsyntax/feature-gate.rs—or actually require that an issue be created.) Rather than endeavoring to change how `#[unstable]` works at this time (given competing contributor and reviewer priorities), this simple patch proposes the less-ambitious solution of just not adding the "(see issue)" note when the number is zero. Resolvesrust-lang#49983.
rust-highfive
commented
Apr 15, 2018
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
clarfonthey
commented
Apr 15, 2018
Contributor
I mentioned this in #41260 and @GuillaumeGomez was against it at the time. Not sure how people feel about this, although I personally would prefer this. |
GuillaumeGomez
commented
Apr 15, 2018
Member
Optional related issue sounds good for me. |
michaelwoerister
commented
Apr 16, 2018
Member
r? @nikomatsakis for re-assignment or nomination. Not sure how contentious this is. |
emilyalbini
commented
Apr 23, 2018
Member
Ping from triage @nikomatsakis! This PR needs your review. |
zackmdavis
commented
Apr 23, 2018
ContributorAuthor
estebank
commented
Apr 23, 2018
Contributor
@bors r+ rollup |
bors
commented
Apr 23, 2018
Collaborator
📌 Commit e77110e has been approved by |
estebank
commented
Apr 23, 2018
Contributor
Lets have a follow up PR making the related issue optional, but for now this is a net positive. |
kennytm added a commit
to kennytm/rust
that referenced
this pull request
Apr 24, 2018
don't see issue #0 The unstable-feature attribute requires an issue (neglecting it is E0547), which gets used in the error messages. Unfortunately, there are some cases where "0" is apparently used a placeholder where no issue exists, directing the user to see the (nonexistent) issue #0. (It would have been better to either let `issue` be optional—compare to how issue is an `Option<u32>` in the feature-gate declarations in libsyntax/feature-gate.rs—or actually require that an issue be created.) Rather than endeavoring to change how `#[unstable]` works at this time (given competing contributor and reviewer priorities), this simple patch proposes the less-ambitious solution of just not adding the "(see issue)" note when the number is zero. Resolvesrust-lang#49983.
bors added a commit
that referenced
this pull request
Apr 24, 2018
Rollup of 11 pull requests Successful merges: - #49461 (std: Child::kill() returns error if process has already exited) - #49727 (Add Cell::update) - #49812 (Fix revision support for UI tests.) - #49829 (Add doc links to `std::os` extension traits) - #49906 (Stabilize `std::hint::unreachable_unchecked`.) - #49970 (Deprecate Read::chars and char::decode_utf8) - #49985 (don't see issue #0) - #50118 (fix search bar bug) - #50139 (encourage descriptive issue titles) - #50174 (Use FxHashMap in syntax_pos::symbol::Interner::intern.) - #50185 (core: Fix overflow in `int::mod_euc` when `self < 0 && rhs == MIN`) Failed merges:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unstable-feature attribute requires an issue (neglecting it is
E0547), which gets used in the error messages. Unfortunately, there are
some cases where "0" is apparently used a placeholder where no issue
exists, directing the user to see the (nonexistent) issue #0. (It would
have been better to either let
issuebe optional—compare to how issueis an
Option<u32>in the feature-gate declarations inlibsyntax/feature-gate.rs—or actually require that an issue be created.)
Rather than endeavoring to change how
#[unstable]works at this time(given competing contributor and reviewer priorities), this simple patch
proposes the less-ambitious solution of just not adding the "(see
issue)" note when the number is zero.
Resolves#49983.