Uh oh!
There was an error while loading. Please reload this page.
Add some groundwork for cross-language LTO. - #50000
Conversation
This comment has been minimized.
This comment has been minimized.
d83758e to
0869f7bComparealexcrichton
commented
Apr 16, 2018
@bors: r+ Looks great! |
bors
commented
Apr 16, 2018
📌 Commit 0869f7b has been approved by |
This comment has been minimized.
This comment has been minimized.
michaelwoerister
commented
Apr 16, 2018
@bors r- (travis failing) |
michaelwoerister
commented
Apr 16, 2018
@rust-lang/infra, |
alexcrichton
commented
Apr 16, 2018
I think that |
kennytm
commented
Apr 16, 2018
I can find |
michaelwoerister
commented
Apr 17, 2018
I'm calling it like this: So it should not need to be in |
michaelwoerister
commented
Apr 17, 2018
Oh, but maybe we are not building LLVM ourselves in all cases? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
8dc6599 to
56df629Comparemichaelwoerister
commented
Apr 17, 2018
@bors r=alexcrichton |
bors
commented
Apr 17, 2018
📌 Commit 56df629 has been approved by |
bors
commented
Apr 18, 2018
☔ The latest upstream changes (presumably #49972) made this pull request unmergeable. Please resolve the merge conflicts. |
56df629 to
34d58d7Comparemichaelwoerister
commented
Apr 19, 2018
Rebased. @bors r=alexcrichton |
bors
commented
Apr 19, 2018
📌 Commit 34d58d7 has been approved by |
bors
commented
May 4, 2018
📌 Commit d0253ad has been approved by |
bors
commented
May 4, 2018
⌛ Testing commit d0253ad with merge 66814fddd9d01dd9b900f880c74e27e278060545... |
bors
commented
May 4, 2018
💔 Test failed - status-appveyor |
rust-highfive
commented
May 4, 2018
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
retep998
commented
May 4, 2018
That's a blatantly spurious error. |
kennytm
commented
May 4, 2018
bors
commented
May 4, 2018
Add some groundwork for cross-language LTO. Implements part of #49879: - Adds a `-Z cross-lang-lto` flag to rustc - Makes sure that bitcode is embedded in object files if the flag is set. This should already allow for using cross language LTO for staticlibs (where one has to invoke the linker manually anyway). However, `rustc` will not try to enable LTO for its own linker invocations yet. r? @alexcrichton
bors
commented
May 4, 2018
💔 Test failed - status-travis |
rust-highfive
commented
May 4, 2018
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
1 similar comment
rust-highfive
commented
May 4, 2018
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
michaelwoerister
commented
May 7, 2018
Seems like @bors r=alexcrichton |
bors
commented
May 7, 2018
📌 Commit 0bf26bf has been approved by |
bors
commented
May 7, 2018
bors
commented
May 7, 2018
☀️ Test successful - status-appveyor, status-travis |
michaelwoerister
commented
May 7, 2018
🎉 |
Implements part of #49879:
-Z cross-lang-ltoflag to rustcThis should already allow for using cross language LTO for staticlibs (where one has to invoke the linker manually anyway). However,
rustcwill not try to enable LTO for its own linker invocations yet.r? @alexcrichton