Skip to content

rustdoc: Don't include private paths in all.html - #50032

Merged
bors merged 1 commit into
rust-lang:masterfrom
ollie27:rustdoc_all_private
Apr 17, 2018
Merged

rustdoc: Don't include private paths in all.html#50032
bors merged 1 commit into
rust-lang:masterfrom
ollie27:rustdoc_all_private

Conversation

@ollie27

@ollie27ollie27 commented Apr 17, 2018

Copy link
Copy Markdown
Contributor

For example the stdall.html includes references to the coresimd module which is a private implementation detail.

r? @GuillaumeGomez

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 17, 2018
@GuillaumeGomez

GuillaumeGomez commented Apr 17, 2018

Copy link
Copy Markdown
Member

Good catch, thanks!

@bors: r+

@bors

bors commented Apr 17, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit abded61 has been approved by GuillaumeGomez

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 17, 2018
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Apr 17, 2018
@GuillaumeGomez
Rollup merge ofrust-lang#50032- ollie27:rustdoc_all_private, r=Guil…
92d29c1
…laumeGomez
rustdoc: Don't include private paths in all.html
For example the `std` [`all.html`](https://doc.rust-lang.org/nightly/std/all.html) includes references to the `coresimd` module which is a private implementation detail.
r? @GuillaumeGomez
@GuillaumeGomezGuillaumeGomez mentioned this pull request Apr 17, 2018
Merged
bors added a commit that referenced this pull request Apr 17, 2018
@bors
Auto merge of#50033- GuillaumeGomez:rollup, r=GuillaumeGomez
9379bcd
Rollup of 4 pull requests
Successful merges:
- #49699 (Removed 'proc' from the reserved keywords list)
- #49966 (Multiple query search)
- #50013 (Remove no longer necessary comparison to Vec::splice.)
- #50032 (rustdoc: Don't include private paths in all.html)
Failed merges:
@bors
bors merged commit abded61 into rust-lang:masterApr 17, 2018
@ollie27
ollie27 deleted the rustdoc_all_private branch April 17, 2018 19:05
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@GuillaumeGomezGuillaumeGomez

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ollie27@GuillaumeGomez@bors@rust-highfive