Skip to content

Added rust tool similar to go's go tool - #5014

Merged
bors merged 2 commits into
rust-lang:incomingfrom
Kimundi:incoming
Feb 19, 2013
Merged

Added rust tool similar to go's go tool#5014
bors merged 2 commits into
rust-lang:incomingfrom
Kimundi:incoming

Conversation

@Kimundi

Copy link
Copy Markdown
Contributor

This implements a rust tool similar to go's go tool. It acts as a central hub for the tools rustc, rustdoc, rustpkg, rusti, and also provides shortcuts for directly compiling and running a source file either as a normal or a test executable. Default usage message:

The rust tool is a convenience for managing rust source code.
It acts as a shortcut for programs of the rust tool chain.
Usage: rust <command> [arguments]
The commands are:
build compile rust source files
run build a executable, and run it
test build a test executable, and run it
doc generate documentation from doc comments
pkg download, build, install rust packages
sketch run a rust interpreter
help show detailed usage of a command
Use "rust help <command>" for more information about a command.

@Kimundi

Copy link
Copy Markdown
ContributorAuthor

Just noticed that I forgot to actually run make check, apparently naming the tool just rust everywhere in the makefile introduces ambiguities. Trying to rename it to rusttool now.

Edit: Getting those warnings on make check:

/home/marvin/dev/rust/fork/rust/mk/tests.mk:492: warning: overriding commands for target `tmp/check-stage0-T-x86_64-unknown-linux-gnu-H-x86_64-unknown-linux-gnu-rust.ok'
/home/marvin/dev/rust/fork/rust/mk/tests.mk:274: warning: ignoring old commands for target `tmp/check-stage0-T-x86_64-unknown-linux-gnu-H-x86_64-unknown-linux-gnu-rust.ok'
/home/marvin/dev/rust/fork/rust/mk/tests.mk:492: warning: overriding commands for target `tmp/check-stage1-T-x86_64-unknown-linux-gnu-H-x86_64-unknown-linux-gnu-rust.ok'
/home/marvin/dev/rust/fork/rust/mk/tests.mk:274: warning: ignoring old commands for target `tmp/check-stage1-T-x86_64-unknown-linux-gnu-H-x86_64-unknown-linux-gnu-rust.ok'
/home/marvin/dev/rust/fork/rust/mk/tests.mk:492: warning: overriding commands for target `tmp/check-stage2-T-x86_64-unknown-linux-gnu-H-x86_64-unknown-linux-gnu-rust.ok'
/home/marvin/dev/rust/fork/rust/mk/tests.mk:274: warning: ignoring old commands for target `tmp/check-stage2-T-x86_64-unknown-linux-gnu-H-x86_64-unknown-linux-gnu-rust.ok'
/home/marvin/dev/rust/fork/rust/mk/tests.mk:492: warning: overriding commands for target `tmp/check-stage3-T-x86_64-unknown-linux-gnu-H-x86_64-unknown-linux-gnu-rust.ok'
/home/marvin/dev/rust/fork/rust/mk/tests.mk:274: warning: ignoring old commands for target `tmp/check-stage3-T-x86_64-unknown-linux-gnu-H-x86_64-unknown-linux-gnu-rust.ok'

I guess I have to modify the makefile definition responsible for those target triples to use rusttool instead, but I have no idea which definition is responsible for that. Makefiles are confusing, I just copied and modified the rusti definitions. ;)

@Kimundi

Copy link
Copy Markdown
ContributorAuthor

Made the warnings go away, letting make check run while I'm catching some sleep, gonna report back tomorrow.

@Kimundi

Copy link
Copy Markdown
ContributorAuthor

make check passes without those warnings now, and the doc tests still run. This seems to be ready to merge now.

bors added a commit that referenced this pull request Feb 19, 2013
This implements a rust tool similar to go's go tool. It acts as a central hub for the tools rustc, rustdoc, rustpkg, rusti, and also provides shortcuts for directly compiling and running a source file either as a normal or a test executable. Default usage message:
```
The rust tool is a convenience for managing rust source code.
It acts as a shortcut for programs of the rust tool chain.
Usage:	rust <command> [arguments]
The commands are:
build compile rust source files
run build a executable, and run it
test build a test executable, and run it
doc generate documentation from doc comments
pkg download, build, install rust packages
sketch run a rust interpreter
help show detailed usage of a command
Use "rust help <command>" for more information about a command.
```
@borsbors closed this Feb 19, 2013
@bors
bors merged commit 702a6f7 into rust-lang:incomingFeb 19, 2013
@frewsxcvfrewsxcv mentioned this pull request Oct 28, 2018
bors added a commit to rust-lang-ci/rust that referenced this pull request May 2, 2020
Fix redundant_clone lint not working with PathBuf and OsString
rust-lang/rust-clippy#4825 diabled MIR optimization in clippy, including `rustc_mir::transform::InstCombine` which reduces `&(*x)` to `x`. This PR tries to unwrap `&*` when looking into `mir::Rvalue`s.
Fixesrust-lang#5014.
---
changelog: fixed `redundant_clone` lint not working with `PathBuf` and `OsString`
RalfJung added a commit to RalfJung/rust that referenced this pull request May 10, 2026
U007D pushed a commit to U007D/rust-mos that referenced this pull request Aug 21, 2026
5014: Use only one code-path for parsing fixtures r=matklad a=matklad
This removes leading newlines everywhere, shifting all ranges in tests
by one
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Kimundi@graydon@bors