move skolemized regions into global tcx by nikomatsakis · Pull Request #50197 · rust-lang/rust

nikomatsakis · 2018-04-24T13:36:03Z

Experimental branch to move skolemized regions into global tcx. This is probably not what we want long term but may be convenient to unblock @sgrif in the short term.

I'd like to do a perf run, though the main concern I guess would be memory usage.

r? @eddyb

nikomatsakis · 2018-04-24T13:48:24Z

(I think that when all is said and done we can again confine skolemized things to the local tcx)

eddyb · 2018-04-24T17:20:11Z

@bors r+

bors · 2018-04-24T17:20:12Z

📋 Looks like this PR is still in progress, ignoring approval

nikomatsakis · 2018-04-24T17:59:44Z

@bors r=eddyb

bors · 2018-04-24T17:59:44Z

📌 Commit 910cf2a has been approved by eddyb

bors · 2018-04-25T01:03:17Z

⌛ Testing commit 910cf2ae18dd4596e23035c7b2552200b51d5984 with merge d7bc491b1cdf9addc73d7189cd106c2b50e25748...

bors · 2018-04-25T01:07:00Z

💔 Test failed - status-appveyor

rust-highfive · 2018-04-25T01:08:08Z

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:01:28] warning: spurious network error (1 tries remaining): failed to get 200 response from `https://crates.io/api/v1/crates/cmake/0.1.30/download`, got 500
[00:01:28] error: unable to get packages from source
[00:01:28] [00:01:28] Caused by:
[00:01:28] failed to get 200 response from `https://crates.io/api/v1/crates/cmake/0.1.30/download`, got 500
[00:01:28] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:01:28] Build completed unsuccessfully in 0:00:40
[00:01:28] make: *** [prepare] Error 1
[00:01:28] Makefile:81: recipe for target 'prepare' failed
[00:01:30] Downloading serde v1.0.40
[00:01:30] error: unable to get packages from source
[00:01:30] [00:01:30] Caused by:
[00:01:30] Caused by:
[00:01:30] failed to get 200 response from `https://crates.io/api/v1/crates/serde/1.0.40/download`, got 404
[00:01:30] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:01:30] Build completed unsuccessfully in 0:00:02
[00:01:30] make: *** [prepare] Error 1
[00:01:30] Makefile:81: recipe for target 'prepare' failed
[00:01:31] Downloading getopts v0.2.17
[00:01:31] error: unable to get packages from source
[00:01:31] [00:01:31] Caused by:
[00:01:31] Caused by:
[00:01:31] failed to get 200 response from `https://crates.io/api/v1/crates/getopts/0.2.17/download`, got 404
[00:01:31] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:01:31] Build completed unsuccessfully in 0:00:00
[00:01:31] Makefile:81: recipe for target 'prepare' failed
[00:01:31] make: *** [prepare] Error 1
[00:01:31] Downloading libc v0.2.40
[00:01:32] error: unable to get packages from source
[00:01:32] [00:01:32] Caused by:
[00:01:32] Caused by:
[00:01:32] failed to get 200 response from `https://crates.io/api/v1/crates/libc/0.2.40/download`, got 404
[00:01:32] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:01:32] Build completed unsuccessfully in 0:00:00
[00:01:32] Makefile:81: recipe for target 'prepare' failed
[00:01:32] make: *** [prepare] Error 1
[00:01:32] Downloading cc v1.0.10
[00:01:32] error: unable to get packages from source
[00:01:32] [00:01:32] Caused by:
[00:01:32] Caused by:
[00:01:32] failed to get 200 response from `https://crates.io/api/v1/crates/cc/1.0.10/download`, got 404
[00:01:32] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:01:32] Build completed unsuccessfully in 0:00:00
[00:01:32] Makefile:81: recipe for target 'prepare' failed
[00:01:32] make: *** [prepare] Error 1
[00:01:32] The command has failed after 5 attempts.
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 1.
travis_time:start:1e99a3a4
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

nagbot-rs · 2018-04-25T01:49:33Z

@bors: retry * crates.io was down

…

On Tue, Apr 24, 2018 at 8:07 PM, bors ***@***.***> wrote: 💔 Test failed - status-appveyor <https://ci.appveyor.com/project/rust-lang/rust/build/1.0.7135> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#50197 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AaPN0LhibQwo2kaiMdP2DW9SHNv5dui6ks5tr8xJgaJpZM4ThsO1> . -- You received this message because you are subscribed to the Google Groups "rust-ops" group. To unsubscribe from this group and stop receiving emails from it, send an email to ***@***.*** To post to this group, send email to ***@***.*** To view this discussion on the web visit https://groups.google.com/d/ msgid/rust-ops/rust-lang/rust/pull/50197/c384127864%40github.com <https://groups.google.com/d/msgid/rust-ops/rust-lang/rust/pull/50197/c384127864%40github.com?utm_medium=email&utm_source=footer> . For more options, visit https://groups.google.com/d/optout.

bors · 2018-04-25T01:49:34Z

@nagbot-rs: 🔑 Insufficient privileges: not in try users

aturon · 2018-04-25T02:04:35Z

@bors: retry

bors · 2018-04-25T23:27:45Z

☔ The latest upstream changes (presumably #50016) made this pull request unmergeable. Please resolve the merge conflicts.

nikomatsakis · 2018-04-26T18:23:33Z

@bors r=eddyb

bors · 2018-04-26T18:23:34Z

📌 Commit 7dbb151 has been approved by eddyb

rust-highfive · 2018-04-26T18:44:44Z

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:07:56] Compiling rustc_const_math v0.0.0 (file:///checkout/src/librustc_const_math)
[00:08:20] Compiling syntax_ext v0.0.0 (file:///checkout/src/libsyntax_ext)
[00:15:52] Compiling rustc_typeck v0.0.0 (file:///checkout/src/librustc_typeck)
[00:15:52] Compiling rustc_mir v0.0.0 (file:///checkout/src/librustc_mir)
[00:15:58] error[E0599]: no method named `substs` found for type `&rustc::ty::TraitRef<'_>` in the current scope
[00:15:58] --> librustc_typeck/check/method/probe.rs:1490:57
[00:15:58] |
[00:15:58] 1490 | && !trait_ref.skip_binder().substs().has_skol()
[00:15:58] | ^^^^^^ field, not a method
[00:15:58] |
[00:15:58] = help: did you mean to write `trait_ref.skip_binder().substs` instead of `trait_ref.skip_binder().substs(...)`?
[00:16:01] error: aborting due to previous error
[00:16:01] [00:16:01] For more information about this error, try `rustc --explain E0599`.
[00:16:01] error: Could not compile `rustc_typeck`.
[00:16:01] error: Could not compile `rustc_typeck`.
[00:16:01] [00:16:01] Caused by:
[00:16:01] process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustc --crate-name rustc_typeck librustc_typeck/lib.rs --color always --error-format json --crate-type dylib --emit=dep-info,link -C prefer-dynamic -C opt-level=2 -C metadata=22421d2ff61f4da9 -C extra-filename=-22421d2ff61f4da9 --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps --target x86_64-unknown-linux-gnu -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/release/deps --extern rustc_platform_intrinsics=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_platform_intrinsics-6f259a2a9f59267f.so --extern rustc_target=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_target-959ba3a7ab7a2be3.so --extern rustc_data_structures=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_data_structures-550afbc40330c44b.so --extern rustc_const_math=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_const_math-648afcf1a0c2954c.so --extern log=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/liblog-3e35efb9e5bc7a9a.rlib --extern rustc=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc-cb643e904ecf9227.so --extern rustc_errors=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_errors-7f999938245933d1.so --extern syntax=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libsyntax-21033e7d98b3b734.so --extern arena=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libarena-0b7f7b8330cb09ce.so --extern syntax_pos=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libsyntax_pos-de29d22526477961.so --extern fmt_macros=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libfmt_macros-3706e912fdb98df1.so -L native=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/build/backtrace-sys-22398a187b4139a2/out/.libs -L native=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/build/miniz-sys-4a7fffed6b170d5b/out` (exit code: 101)
/llvm-emscripten/test
149024 ./.git/modules
149020 ./.git/modules/src
143664 ./obj/build/bootstrap/debug/incremental
143664 ./obj/build/bootstrap/debug/incremental
126608 ./obj/build/x86_64-unknown-linux-gnu/stage0-rustc
122708 ./obj/build/bootstrap/debug/incremental/bootstrap-1sil8jgb030ka
122704 ./obj/build/bootstrap/debug/incremental/bootstrap-1sil8jgb030ka/s-f0hgex28vh-1b56voz-2f3cmz1knheyt
89696 ./src/llvm/test/CodeGen
82464 ./obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu
82460 ./obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release
70944 ./obj/build/x86_64-unknown-linux-gnu/native
---
11900 ./src/tools/lld
11284 ./.git/objects
10708 ./.git/objects/pack
10076 ./src/test/compile-fail
10012 ./src/llvm/test/MC/AMDGPU
9648 ./src/llvm/test/MC/Disassembler/AMDGPU
9304 ./.git/modules/src/tools/clippy/objects
travis_time:end:2177543a:start=1524768280137570666,finish=1524768280361682807,duration=224112141
travis_fold:end:after_failure.1
travis_fold:start:after_failure.2

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

kennytm · 2018-04-26T20:47:26Z

@bors r-

CI error is legit.

Notably, excluding ReSkolemized

nikomatsakis · 2018-04-30T18:53:51Z

@bors r=eddyb

bors · 2018-04-30T18:53:51Z

📌 Commit 149ab1b has been approved by eddyb

bors · 2018-05-01T00:16:22Z

⌛ Testing commit 149ab1b with merge 2a8ad90...

@sgrif

move skolemized regions into global tcx Experimental branch to move skolemized regions into global tcx. This is probably not what we want long term but may be convenient to unblock @sgrif in the short term. I'd like to do a perf run, though the main concern I guess would be memory usage. r? @eddyb

bors · 2018-05-01T02:47:37Z

☀️ Test successful - status-appveyor, status-travis
Approved by: eddyb
Pushing 2a8ad90 to master...

rust-highfive assigned eddyb Apr 24, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 24, 2018

nikomatsakis changed the title ~~[WIP] move skolemized regions into global tcx~~move skolemized regions into global tcxApr 24, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 24, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 25, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 25, 2018

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 25, 2018

nikomatsakis force-pushed the skolemize-out-of-tcx branch from 910cf2a to 7dbb151Compare April 26, 2018 18:23

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 26, 2018

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 26, 2018

nikomatsakis added 3 commits April 30, 2018 13:36

remove some (apparently) dead code
2e59e46

make needs_infer specific to inference variables
6940075
Notably, excluding ReSkolemized

put ReSkolemized into the global tcx
149ab1b

nikomatsakis force-pushed the skolemize-out-of-tcx branch from 7dbb151 to 149ab1bCompare April 30, 2018 18:37

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 30, 2018

bors merged commit 149ab1b into rust-lang:masterMay 1, 2018

This was referenced May 1, 2018
Make GlobalCtxt thread-safe #50108
Merged
WIP: Parallelize passes using rayon #46564
Closed

ishitatsuyuki mentioned this pull request May 2, 2018
Memory usage regression since 5/1 #50389
Closed

nikomatsakis deleted the skolemize-out-of-tcx branch May 2, 2018 19:49

pnkfelix mentioned this pull request Jan 28, 2019
ICE !ty.needs_infer() && !ty.has_placeholders() from boxing closure of type dyn for<'a> _ #57843
Closed

Uh oh!

Uh oh!

Conversation

nikomatsakis commented Apr 24, 2018

Uh oh!

nikomatsakis commented Apr 24, 2018

Uh oh!

eddyb commented Apr 24, 2018

Uh oh!

bors commented Apr 24, 2018

Uh oh!

nikomatsakis commented Apr 24, 2018

Uh oh!

bors commented Apr 24, 2018

Uh oh!

bors commented Apr 25, 2018

Uh oh!

bors commented Apr 25, 2018

Uh oh!

rust-highfive commented Apr 25, 2018

Uh oh!

nagbot-rs commented Apr 25, 2018 via email

Uh oh!

bors commented Apr 25, 2018

Uh oh!

aturon commented Apr 25, 2018

Uh oh!

bors commented Apr 25, 2018

Uh oh!

nikomatsakis commented Apr 26, 2018

Uh oh!

bors commented Apr 26, 2018

Uh oh!

rust-highfive commented Apr 26, 2018

Uh oh!

kennytm commented Apr 26, 2018

Uh oh!

nikomatsakis commented Apr 30, 2018

Uh oh!

bors commented Apr 30, 2018

Uh oh!

bors commented May 1, 2018

Uh oh!

bors commented May 1, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants