Skip to content

Make String::new() const - #50460

Merged
bors merged 1 commit into
rust-lang:masterfrom
F001:const_string
May 9, 2018
Merged

Make String::new() const#50460
bors merged 1 commit into
rust-lang:masterfrom
F001:const_string

Conversation

@F001

@F001F001 commented May 5, 2018

Copy link
Copy Markdown
Contributor

Following the steps of #50233 , make String::new() a const fn.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @kennytm

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 5, 2018
@kennytmkennytm added the T-libs-api [DEPRECATED; DO NOT USE] label May 5, 2018
@kennytm

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented May 5, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 160063a has been approved by kennytm

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 5, 2018
@emilyalbiniemilyalbini added the relnotes Marks issues that should be documented in the release notes of the next release. label May 7, 2018
@kennytmkennytm removed the relnotes Marks issues that should be documented in the release notes of the next release. label May 8, 2018
@kennytm

Copy link
Copy Markdown
Member

@pietroalbini This doesn't need relnotes yet because this is still unstable.

@kennytmkennytm mentioned this pull request May 8, 2018
kennytm added a commit to kennytm/rust that referenced this pull request May 9, 2018
Make `String::new()` const
Following the steps of rust-lang#50233 , make `String::new()` a `const fn`.
bors added a commit that referenced this pull request May 9, 2018
Rollup of 11 pull requests
Successful merges:
- #49988 (Mention Result<!, E> in never docs.)
- #50148 (turn `ManuallyDrop::new` into a constant function)
- #50456 (Update the Cargo submodule)
- #50460 (Make `String::new()` const)
- #50464 (Remove some transmutes)
- #50505 (Added regression function match value test)
- #50511 (Add some explanations for #[must_use])
- #50525 (Optimize string handling in lit_token().)
- #50527 (Cleanup a `use` in a raw_vec test)
- #50539 (Add more logarithm constants)
- #49523 (Update RELEASES.md for 1.26.0)
Failed merges:
@bors
bors merged commit 160063a into rust-lang:masterMay 9, 2018
@F001
F001 deleted the const_string branch August 28, 2018 10:27
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libs-api[DEPRECATED; DO NOT USE]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@F001@rust-highfive@kennytm@bors@emilyalbini