Uh oh!
There was an error while loading. Please reload this page.
env: remove unwrap in examples in favor of try op - #50736
Conversation
rust-highfive
commented
May 14, 2018
r? @shepmaster (rust_highfive has picked a reviewer for you, use r? to override) |
I think I'm generally in favor of this, but I'm hesitant to accept it as-is because doctests will be getting the ability to use I could see if we used the +/// # fn main() -> std::io::Result<()> {+/// let path = env::current_dir()?;+/// println!("The current directory is {}", path.display());+/// # Ok(())+/// # }But I wonder if hiding the |
udoprog
commented
May 15, 2018
@shepmaster this is only documentation, we can patch it again when try-op is available for doctests. This change puts it in line with other similar doctests (e.g. https://doc.rust-lang.org/std/io/trait.Read.html) which will also have to be patched later. |
shepmaster
commented
May 16, 2018
Ah, alright then. @bors r+ |
bors
commented
May 16, 2018
📌 Commit f73c4a4 has been approved by |
shepmaster
commented
May 16, 2018
@bors rollup |
shepmaster
commented
May 16, 2018
Thanks! |
env: remove unwrap in examples in favor of try op
Rollup of 17 pull requests Successful merges: - #50170 (Implement From for more types on Cow) - #50638 (Don't unconditionally set CLOEXEC twice on every fd we open on Linux) - #50656 (Fix `fn main() -> impl Trait` for non-`Termination` trait) - #50669 (rustdoc: deprecate `#![doc(passes, plugins, no_default_passes)]`) - #50726 (read2: Use inner function instead of closure) - #50728 (Fix rustdoc panic with `impl Trait` in type parameters) - #50736 (env: remove unwrap in examples in favor of try op) - #50740 (Remove LazyBTreeMap.) - #50752 (Add missing error codes in libsyntax-ext asm) - #50779 (Make mutable_noalias and arg_align_attributes be tracked) - #50787 (Fix run-make wasm tests) - #50788 (Fix an ICE when casting a nonexistent const) - #50789 (Ensure libraries built in stage0 have unique metadata) - #50793 (tidy: Add a check for empty UI test files) - #50797 (fix a typo in signed-integer::from_str_radix()) - #50808 (Stabilize num::NonZeroU*) - #50809 (GitHub: Stop treating Cargo.lock as a generated file.) Failed merges:
No description provided.