Uh oh!
There was an error while loading. Please reload this page.
etc: Suppress the remaining Valgrind error in rustdoc. rs=burningtree - #5080
Closed
pcwalton wants to merge 9 commits into
Closed
etc: Suppress the remaining Valgrind error in rustdoc. rs=burningtree#5080pcwalton wants to merge 9 commits into
pcwalton wants to merge 9 commits into
Conversation
flip1995 pushed a commit
to flip1995/rust
that referenced
this pull request
Jul 17, 2020
This lint catches cases where the last statement of a closure expecting an instance of Ord has a trailing semi-colon. It compiles since the closure ends up return () which also implements Ord but causes unexpected results in cases such as sort_by_key. Fixesrust-lang#5080 reprise: rebase, update and address all concerns
flip1995 pushed a commit
to flip1995/rust
that referenced
this pull request
Jul 17, 2020
Reprise: new lint: Unintentional return of unit from closures expecting Ord This lint catches cases where the last statement of a closure expecting an instance of Ord has a trailing semi-colon. It compiles since the closure ends up return () which also implements Ord but causes unexpected results in cases such as sort_by_key. Fixesrust-lang#5080 Reprise of rust-lang#5348 where I addressed all the comments there changelog: add lint [`unit_return_expecting_ord`]
U007D pushed a commit
to U007D/rust-mos
that referenced
this pull request
Aug 21, 2026
5080: Set corret request method r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.