Skip to content

rustdoc: set tab width in rust source blocks - #50947

Merged
bors merged 1 commit into
rust-lang:masterfrom
QuietMisdreavus:nice-tabs
May 22, 2018
Merged

rustdoc: set tab width in rust source blocks#50947
bors merged 1 commit into
rust-lang:masterfrom
QuietMisdreavus:nice-tabs

Conversation

@QuietMisdreavus

Copy link
Copy Markdown
Contributor

cc #49155 (fixes it?)

This sets the tab width (in supported browsers) in Rust source blocks to 4 spaces wide (instead of the default 8), to correspond with the style guidelines.

@rust-highfive

Copy link
Copy Markdown
Contributor

Some changes occurred in HTML/CSS.

cc @GuillaumeGomez

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @GuillaumeGomez

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 21, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this backline. :)

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Force-pushed, but i should mention that vim will keep automatically putting that in there.

@GuillaumeGomez

Copy link
Copy Markdown
Member

This just reminded me that I should enable the css minifier as well.

@GuillaumeGomez

Copy link
Copy Markdown
Member

Thanks!

@bors: r+ rollup

@bors

bors commented May 22, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit ac38345 has been approved by GuillaumeGomez

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 22, 2018
kennytm added a commit to kennytm/rust that referenced this pull request May 22, 2018
…umeGomez
rustdoc: set tab width in rust source blocks
cc rust-lang#49155 (fixes it?)
This sets the tab width ([in supported browsers](https://developer.mozilla.org/en-US/docs/Web/CSS/tab-size)) in Rust source blocks to 4 spaces wide (instead of the default 8), to correspond with the style guidelines.
@kennytmkennytm mentioned this pull request May 22, 2018
bors added a commit that referenced this pull request May 22, 2018
Rollup of 15 pull requests
Successful merges:
- #50846 (Add E0665)
- #50849 (CheckLoopVisitor: also visit closure arguments)
- #50863 (Make `[T]::len` and `str::len` const fn)
- #50875 (rustdoc: use "short form" doc(cfg) printing even when combined with other conditionals)
- #50913 (Fix typo in cell.rs)
- #50914 (Issue #50636: Improve error diagnostic with missing commas after struct fields.)
- #50931 (Inline `try_get`.)
- #50932 (Optimize seen Predicate filtering.)
- #50945 (Stabilize feature from_ref)
- #50946 (rustc: Fix procedural macros generating lifetime tokens)
- #50947 (rustdoc: set tab width in rust source blocks)
- #50952 (Add the 2018 edition of the book to doc.rust-lang.org)
- #50958 (Micro-optimization on PR#50697)
- #50961 (Fix FileCheck finding with MSVC)
- #50963 (Right-size the `VecDeque` in `coerce_unsized`.)
Failed merges:
@bors
bors merged commit ac38345 into rust-lang:masterMay 22, 2018
@QuietMisdreavus
QuietMisdreavus deleted the nice-tabs branch May 24, 2018 14:35
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Mar 28, 2020
…Gomez
Fix rustdoc.css CSS tab-size property
This fixes the CSS tab size property names which are called `tab-size` / `-moz-tab-size` and not `tab-width`
Old issue rust-lang#49155 and related PR rust-lang#50947
tab-size: https://developer.mozilla.org/en-US/docs/Web/CSS/tab-size
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@QuietMisdreavus@rust-highfive@GuillaumeGomez@bors