Uh oh!
There was an error while loading. Please reload this page.
Make sure that queries have predictable symbol names. - #50964
Merged
Conversation
michaelwoerister
commented
May 22, 2018
MemberAuthor
@bors try |
bors
commented
May 22, 2018
Collaborator
bors added a commit
that referenced
this pull request
May 22, 2018
Make sure that queries have predictable symbol names. Some recent refactorings led to queriy names not showing up in the corresponding symbol names. [perf-focus](https://github.com/nikomatsakis/perf-focus) and manual profiling have been broken by this. This PR makes sure that query providers always get their own symbol and that that symbol has a predictable name. Since this adds `#[inline(never)]` to a function that wraps the provider call, let's check if this does not regress performance before merging. r? @nikomatsakis
bors
commented
May 22, 2018
Collaborator
☀️ Test successful - status-travis |
michaelwoerister
commented
May 22, 2018
MemberAuthor
@Mark-Simulacrum, could I get a perf-run, please? |
nikomatsakis
commented
May 22, 2018
Contributor
r=me presuming perf is fine (I'd be quite shocked to see otherwise though) |
michaelwoerister
commented
May 23, 2018
MemberAuthor
Performance does not seem to be affected. @bors r=nikomatsakis |
bors
commented
May 23, 2018
Collaborator
📌 Commit 599b79e has been approved by |
michaelwoerister
commented
May 23, 2018
MemberAuthor
@bors rollup |
kennytm added a commit
to kennytm/rust
that referenced
this pull request
May 24, 2018
…, r=nikomatsakis Make sure that queries have predictable symbol names. Some recent refactorings led to query names not showing up in the corresponding symbol names. [perf-focus](https://github.com/nikomatsakis/perf-focus) and manual profiling have been broken by this. This PR makes sure that query providers always get their own symbol and that that symbol has a predictable name. Since this adds `#[inline(never)]` to a function that wraps the provider call, let's check if this does not regress performance before merging. r? @nikomatsakis
bors added a commit
that referenced
this pull request
May 24, 2018
Rollup of 9 pull requests Successful merges: - #50864 (Add NetBSD/arm target specs) - #50956 (rust-gdb: work around the re-used -d argument in cgdb) - #50964 (Make sure that queries have predictable symbol names.) - #50965 (Update LLVM to pull in another wasm fix) - #50972 (Add -Z no-parallel-llvm flag) - #50979 (Fix span for type-only arguments) - #50981 (Shrink `LiveNode`.) - #50995 (move type out of unsafe block) - #51011 ( rustdoc: hide macro export statements from docs) Failed merges:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some recent refactorings led to query names not showing up in the corresponding symbol names. perf-focus and manual profiling have been broken by this. This PR makes sure that query providers always get their own symbol and that that symbol has a predictable name.
Since this adds
#[inline(never)]to a function that wraps the provider call, let's check if this does not regress performance before merging.r? @nikomatsakis