Uh oh!
There was an error while loading. Please reload this page.
Reword {ptr,mem}::replace docs. - #51124
Merged
Merged
Conversation
rust-highfive
commented
May 28, 2018
Contributor
r? @shepmaster (rust_highfive has picked a reviewer for you, use r? to override) |
shepmaster
commented
May 29, 2018
Member
I'm not a fan of the phrase "behind the mutable {pointer,reference}", but this probably belongs to someone with more appropriate view of the docs. |
QuietMisdreavus
commented
May 29, 2018
Contributor
I agree that the phrasing is a little awkward. How about:
|
frewsxcv
commented
Jun 2, 2018
ContributorAuthor
sgtm! adjusted in the latest force push |
QuietMisdreavus
commented
Jun 2, 2018
Contributor
Thanks! @bors r+ rollup |
bors
commented
Jun 2, 2018
Collaborator
📌 Commit 61b5bd2 has been approved by |
Mark-Simulacrum added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Jun 2, 2018
…isdreavus
Reword {ptr,mem}::replace docs.
Fixesrust-lang#50657.bors added a commit
that referenced
this pull request
Jun 2, 2018
Rollup of 6 pull requests Successful merges: - #50167 ( Add as_nanos function to Duration) - #50919 (Provide more context for what the {f32,f64}::EPSILON values represent.) - #51124 (Reword {ptr,mem}::replace docs.) - #51147 (Stabilize SliceIndex trait.) - #51291 (Fix typos of ‘ambiguous’) - #51302 (Permit building rustdoc without compiler artifacts) Failed merges:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#50657.