First step towards `u128` instead of `Const` in `PatternKind::Range` by pacman82 · Pull Request #51159 · rust-lang/rust

pacman82 · 2018-05-29T09:50:14Z

This PR accomplishes two things:

It adds ty::Ty to PatternKind::Range. The extra type information will make it easier to remove it from the hi and lo members.
It exchanges Const for u128 in Constructor::ConstantRange.

rust-highfive · 2018-05-29T09:50:17Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @cramertj (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

cramertj · 2018-05-29T18:06:09Z

r? @oli-obk

eddyb · 2018-05-30T14:13:34Z

cc @varkor

emilyalbini · 2018-06-04T10:48:32Z

Ping from triage @oli-obk! This PR needs your review.

oli-obk · 2018-06-04T11:52:22Z

cc @varkor is this conflicting with your changes in #50912 ?

varkor · 2018-06-04T13:19:26Z

@oli-obk: it does conflict, though it shouldn't be a huge pain to deal with. It would be less hassle for me if this PR could be merged after #50912, though.

bors · 2018-06-29T01:17:27Z

☔ The latest upstream changes (presumably #51884) made this pull request unmergeable. Please resolve the merge conflicts.

TimNN · 2018-08-28T17:29:41Z

Ping from triage! Wow, after a multi-month process, the blocking PR has been merged 🎉

If I understand correctly, this PR should be unblocked now, however it does require a rebase, @pacman82.

pacman82 · 2018-08-29T12:16:57Z

@TimNN Thanks for the ping; I'll hopefully find the time this weekend.

pacman82 · 2018-09-04T08:34:26Z

@TimNN, @oli-obk Merged the changes from master

oli-obk

just a nit.

Would you also be so kind and squash the commits into a single one?

BatmanAoD · 2018-09-11T15:30:02Z

Ping from triage, @pacman82; looks like this is pretty close.

oli-obk · 2018-09-11T16:03:22Z

r=me with the nits addressed.

…antRange

eddyb · 2018-09-11T22:42:07Z

@bors r=oli-obk

bors · 2018-09-11T22:42:07Z

📌 Commit 26c05b1 has been approved by oli-obk

bors · 2018-09-12T01:56:55Z

⌛ Testing commit 26c05b1 with merge a2b991b...

First step towards `u128` instead of `Const` in `PatternKind::Range` This PR accomplishes two things: * It adds `ty::Ty` to `PatternKind::Range`. The extra type information will make it easier to remove it from the `hi` and `lo` members. * It exchanges `Const` for `u128` in `Constructor::ConstantRange`.

bors · 2018-09-12T04:28:48Z

☀️ Test successful - status-appveyor, status-travis
Approved by: oli-obk
Pushing a2b991b to master...

rust-highfive assigned cramertj May 29, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 29, 2018

rust-highfive assigned oli-obk and unassigned cramertj May 29, 2018

oli-obk added the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Jun 4, 2018

TimNN removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 12, 2018

emilyalbini added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Jun 25, 2018

TimNN added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Aug 28, 2018

oli-obk requested changes Sep 4, 2018
View reviewed changes

Comment threadsrc/librustc_mir/hair/pattern/_match.rs Outdated

Add ty::Ty to PatternKind::Range;u128 for Const in Constructor::Const…
26c05b1
…antRange

pacman82 force-pushed the master branch from 3fcda74 to 26c05b1Compare September 11, 2018 22:29

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 11, 2018

bors merged commit 26c05b1 into rust-lang:masterSep 12, 2018

DaniPopes mentioned this pull request Nov 29, 2023
Recursive generics #118449
Open

mu001999 mentioned this pull request Mar 14, 2025
update outdated doc with new example #137889
Merged

Uh oh!

Uh oh!

Conversation

pacman82 commented May 29, 2018

Uh oh!

rust-highfive commented May 29, 2018

Uh oh!

cramertj commented May 29, 2018

Uh oh!

eddyb commented May 30, 2018

Uh oh!

emilyalbini commented Jun 4, 2018

Uh oh!

oli-obk commented Jun 4, 2018

Uh oh!

varkor commented Jun 4, 2018

Uh oh!

bors commented Jun 29, 2018

Uh oh!

TimNN commented Aug 28, 2018

Uh oh!

pacman82 commented Aug 29, 2018

Uh oh!

pacman82 commented Sep 4, 2018

Uh oh!

oli-obk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

BatmanAoD commented Sep 11, 2018

Uh oh!

oli-obk commented Sep 11, 2018

Uh oh!

eddyb commented Sep 11, 2018

Uh oh!

bors commented Sep 11, 2018

Uh oh!

bors commented Sep 12, 2018

Uh oh!

bors commented Sep 12, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants