NLL: report type moved from behind borrow of array/slice by pnkfelix · Pull Request #51247 · rust-lang/rust

pnkfelix · 2018-05-31T11:00:59Z

When NLL has illegal move due to borrowed content in an array or slice, provide feedback about why the move wasn't a copy.

Drive by: While comparing the resulting .nll.stderr files to their old borrowck variants, I noticed that the test for borrowck-vec-pattern-nesting.rs was not signaling some errors under NLL due to the test assuming lexical lifetimes. So I fixed that too.

Fix#51190

rust-highfive · 2018-05-31T11:01:04Z

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

pnkfelix · 2018-06-01T00:46:11Z

@nikomatsakis you want to review this? (or maybe hand it off to another member of WG-compiler-nll ?)

pnkfelix · 2018-06-04T12:17:23Z

r? @nikomatsakis

nikomatsakis · 2018-06-05T16:59:27Z

@bors r+

bors · 2018-06-05T16:59:29Z

📌 Commit e99f5ec has been approved by nikomatsakis

…ved-from-behind-borrow, r=nikomatsakis NLL: report type moved from behind borrow of array/slice When NLL has illegal move due to borrowed content in an array or slice, provide feedback about why the move wasn't a copy. Drive by: While comparing the resulting `.nll.stderr` files to their old borrowck variants, I noticed that the test for borrowck-vec-pattern-nesting.rs was not signaling some errors under NLL due to the test assuming lexical lifetimes. So I fixed that too. Fixrust-lang#51190

bors · 2018-06-06T06:44:12Z

🔒 Merge conflict

…bout why the move wasn't a copy. This should address rust-lang#51190.

…ing.rs robust for NLL.

pnkfelix · 2018-06-06T21:38:18Z

@bors r=nikomatsakis

bors · 2018-06-06T21:38:18Z

📌 Commit e5b378b has been approved by nikomatsakis

…ved-from-behind-borrow, r=nikomatsakis NLL: report type moved from behind borrow of array/slice When NLL has illegal move due to borrowed content in an array or slice, provide feedback about why the move wasn't a copy. Drive by: While comparing the resulting `.nll.stderr` files to their old borrowck variants, I noticed that the test for borrowck-vec-pattern-nesting.rs was not signaling some errors under NLL due to the test assuming lexical lifetimes. So I fixed that too. Fixrust-lang#51190

rust-highfive · 2018-06-08T14:44:07Z

The job dist-x86_64-linux of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:20:28] Updating git repository `https://github.com/rust-lang-nursery/rustfmt`
[00:21:01] warning: spurious network error (2 tries remaining): curl error: Couldn't resolve host 'github.com'
[00:21:01] ; class=Net (12)
[00:21:08] Downloading petgraph v0.4.12
[00:21:45] warning: spurious network error (2 tries remaining): [6] Couldn't resolve host name (Couldn't resolve host 'crates.io')
[00:22:08] Downloading lazy_static v0.2.11
[00:22:08] Downloading getopts v0.2.17
[00:22:08] Downloading time v0.1.39
[00:22:09] Downloading filetime v0.1.15
---
0 0 0 0 0 0 0 0 --:--:-- 0:03:04 --:--:-- 0
0 0 0 0 0 0 0 0 --:--:-- 0:03:05 --:--:-- 0
0 0 0 0 0 0 0 0 --:--:-- 0:03:06 --:--:-- 0
0 0 0 0 0 0 0 0 --:--:-- 0:03:07 --:--:-- 0curl: (7) Failed to connect to s3-us-west-1.amazonaws.com port 443: Connection timed out
[01:44:19] curl: (6) Couldn't resolve host 's3-us-west-1.amazonaws.com'
[01:44:19] thread 'main' panicked at 'failed to download openssl source: exit code: 6', bootstrap/native.rs:575:17
[01:44:19] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap dist --host x86_64-unknown-linux-gnu --target x86_64-unknown-linux-gnu
[01:44:19] Build completed unsuccessfully in 1:19:49
travis_time:end:05837eca:start=1528462669938858777,finish=1528468929531919920,duration=6259593061143

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2018-06-08T14:44:35Z

The job dist-x86_64-linux of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:20:28] Updating git repository `https://github.com/rust-lang-nursery/rustfmt`
[00:21:01] warning: spurious network error (2 tries remaining): curl error: Couldn't resolve host 'github.com'
[00:21:01] ; class=Net (12)
[00:21:08] Downloading petgraph v0.4.12
[00:21:45] warning: spurious network error (2 tries remaining): [6] Couldn't resolve host name (Couldn't resolve host 'crates.io')
[00:22:08] Downloading lazy_static v0.2.11
[00:22:08] Downloading getopts v0.2.17
[00:22:08] Downloading time v0.1.39
[00:22:09] Downloading filetime v0.1.15
---
0 0 0 0 0 0 0 0 --:--:-- 0:03:04 --:--:-- 0
0 0 0 0 0 0 0 0 --:--:-- 0:03:05 --:--:-- 0
0 0 0 0 0 0 0 0 --:--:-- 0:03:06 --:--:-- 0
0 0 0 0 0 0 0 0 --:--:-- 0:03:07 --:--:-- 0curl: (7) Failed to connect to s3-us-west-1.amazonaws.com port 443: Connection timed out
[01:44:19] curl: (6) Couldn't resolve host 's3-us-west-1.amazonaws.com'
[01:44:19] thread 'main' panicked at 'failed to download openssl source: exit code: 6', bootstrap/native.rs:575:17
[01:44:19] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap dist --host x86_64-unknown-linux-gnu --target x86_64-unknown-linux-gnu
[01:44:19] Build completed unsuccessfully in 1:19:49
travis_time:end:05837eca:start=1528462669938858777,finish=1528468929531919920,duration=6259593061143

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

kennytm · 2018-06-08T14:57:40Z

@bors retry

bors · 2018-06-08T14:58:20Z

⌛ Testing commit e5b378b with merge 6514ef6680d36624bbdb5d674718fc83c6d5fd6a...

bors · 2018-06-08T15:12:10Z

💔 Test failed - status-travis

rust-highfive · 2018-06-08T15:12:11Z

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_fold:start:worker_info
Worker information
hostname: 15d1e2b5-5e55-432b-8334-0681710b0985@1.production-5-worker-org-a-1-gce
version: v3.8.0 https://github.com/travis-ci/worker/tree/cccff7c89da7ba0cf47a90e5615266a45b372e30
instance: travis-job-1f3de9da-b9a5-4460-ad5b-7b52021b80b9 travis-ci-connie-trusty-1512502258-986baf0 (via amqp)
startup: 26.548592147s
travis_fold:end:worker_info
Download from https://build.travis-ci.org/filter/redirect_io.rb failed. Trying https://build.travis-ci.com/filter/redirect_io.rb ...
Build system information
Build language: shell
Build group: stable
Build dist: trusty

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2018-06-08T15:12:15Z

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_fold:start:worker_info
Worker information
hostname: 15d1e2b5-5e55-432b-8334-0681710b0985@1.production-5-worker-org-a-1-gce
version: v3.8.0 https://github.com/travis-ci/worker/tree/cccff7c89da7ba0cf47a90e5615266a45b372e30
instance: travis-job-1f3de9da-b9a5-4460-ad5b-7b52021b80b9 travis-ci-connie-trusty-1512502258-986baf0 (via amqp)
startup: 26.548592147s
travis_fold:end:worker_info
Download from https://build.travis-ci.org/filter/redirect_io.rb failed. Trying https://build.travis-ci.com/filter/redirect_io.rb ...
Build system information
Build language: shell
Build group: stable
Build dist: trusty

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

kennytm · 2018-06-08T15:41:20Z

@bors retry

bors · 2018-06-08T15:41:35Z

⌛ Testing commit e5b378b with merge d7a04b98a929989a9c360b76be2563a02eeb4e14...

bors · 2018-06-08T17:04:11Z

💔 Test failed - status-appveyor

kennytm · 2018-06-08T17:19:18Z

@bors retry #42693

bors · 2018-06-08T20:41:27Z

⌛ Testing commit e5b378b with merge 8afb894...

…hind-borrow, r=nikomatsakis NLL: report type moved from behind borrow of array/slice When NLL has illegal move due to borrowed content in an array or slice, provide feedback about why the move wasn't a copy. Drive by: While comparing the resulting `.nll.stderr` files to their old borrowck variants, I noticed that the test for borrowck-vec-pattern-nesting.rs was not signaling some errors under NLL due to the test assuming lexical lifetimes. So I fixed that too. Fix#51190

kennytm · 2018-06-08T21:08:38Z

@bors treeclosed-

bors · 2018-06-08T23:21:16Z

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing 8afb894 to master...

rust-highfive assigned petrochenkov May 31, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 31, 2018

pnkfelix force-pushed the issue-51190-report-type-moved-from-behind-borrow branch from 7c84263 to e99f5ecCompare May 31, 2018 11:02

rust-highfive assigned nikomatsakis and unassigned petrochenkov Jun 4, 2018

nikomatsakis approved these changes Jun 5, 2018
View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 5, 2018

Mark-Simulacrum mentioned this pull request Jun 5, 2018
Rollup of 5 pull requests #51379
Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 6, 2018

pnkfelix added 3 commits June 6, 2018 22:42

When NLL has illegal move due to borrowed content, provide feedback a…
fbe7d5b
…bout why the move wasn't a copy. This should address rust-lang#51190.

Drive-by: Make assignment conflict tests in borrowck-vec-pattern-nest…
9b24595
…ing.rs robust for NLL.

Update the expected error output to reflect changes in this PR.
e5b378b

pnkfelix force-pushed the issue-51190-report-type-moved-from-behind-borrow branch from e99f5ec to e5b378bCompare June 6, 2018 21:37

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 6, 2018

Mark-Simulacrum mentioned this pull request Jun 6, 2018
Rollup of 9 pull requests #51403
Closed

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 8, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 8, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 8, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 8, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 8, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 8, 2018

bors merged commit e5b378b into rust-lang:masterJun 8, 2018

Uh oh!

Uh oh!

Conversation

pnkfelix commented May 31, 2018

Uh oh!

rust-highfive commented May 31, 2018

Uh oh!

pnkfelix commented Jun 1, 2018

Uh oh!

pnkfelix commented Jun 4, 2018

Uh oh!

nikomatsakis commented Jun 5, 2018

Uh oh!

bors commented Jun 5, 2018

Uh oh!

bors commented Jun 6, 2018

Uh oh!

pnkfelix commented Jun 6, 2018

Uh oh!

bors commented Jun 6, 2018

Uh oh!

rust-highfive commented Jun 8, 2018

Uh oh!

rust-highfive commented Jun 8, 2018

Uh oh!

kennytm commented Jun 8, 2018

Uh oh!

bors commented Jun 8, 2018

Uh oh!

bors commented Jun 8, 2018

Uh oh!

rust-highfive commented Jun 8, 2018

Uh oh!

rust-highfive commented Jun 8, 2018

Uh oh!

kennytm commented Jun 8, 2018

Uh oh!

bors commented Jun 8, 2018

Uh oh!

bors commented Jun 8, 2018

Uh oh!

kennytm commented Jun 8, 2018

Uh oh!

bors commented Jun 8, 2018

Uh oh!

kennytm commented Jun 8, 2018

Uh oh!

bors commented Jun 8, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants