Uh oh!
There was an error while loading. Please reload this page.
Rollup of 5 pull requests - #51287
Merged
Merged
Conversation
When encountering an unexisting method for a given trait where an associated function has the same name, suggest using the appropriate syntax, instead of using `help` text. When only one candidate is found, do not call it "candidate #1", just call it "the candidate".
The old text was: "The precise definition is: a type T is Sync if &T is Send." Since we've also got ``` impl<'a, T> Send for &'a T where T: Sync + ?Sized, ``` I purpose we can change the `if` to `if and only if` to make it more precise.
This is stable, and so no longer needed
Tweak output on E0599 for assoc fn used as method - Use suggestion instead of `help` when possible - Add primary span label - Remove incorrect `help` suggestion using incorrect syntax - Do not refer to only one possible candidate as `candidate #1`, refer to it as `the candidate`
Replace `if` with `if and only if` in the definition dox of `Sync` The old text was: "The precise definition is: a type `T` is `Sync` if `&T` is Send." Since we've also got ``` impl<'a, T> Send for &'a T where T: Sync + ?Sized, ``` I purpose we can change the `if` to `if and only if` to make it more precise.
…ce, r=QuietMisdreavus Add missing whitespace in num example r? @QuietMisdreavus
…=QuietMisdreavus Remove feature flag from fs::read_to_string example This is stable, and so no longer needed
…s, r=Mark-Simulacrum Pull 1.26.2 release notes into master None
rust-highfive
commented
Jun 1, 2018
Contributor
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
Mark-Simulacrum
commented
Jun 1, 2018
MemberAuthor
@bors r+ p=10 |
bors
commented
Jun 1, 2018
Collaborator
📌 Commit c8f9b7c has been approved by |
bors
commented
Jun 2, 2018
Collaborator
bors added a commit
that referenced
this pull request
Jun 2, 2018
Rollup of 5 pull requests Successful merges: - #51135 (Tweak output on E0599 for assoc fn used as method) - #51152 (Replace `if` with `if and only if` in the definition dox of `Sync`) - #51262 (Add missing whitespace in num example) - #51272 (Remove feature flag from fs::read_to_string example) - #51286 (Pull 1.26.2 release notes into master) Failed merges:
bors
commented
Jun 2, 2018
Collaborator
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
ifwithif and only ifin the definition dox ofSync#51152 (Replaceifwithif and only ifin the definition dox ofSync)Failed merges: