[fuchsia] Migrate from launchpad to fdio_spawn_etc by cramertj · Pull Request #51359 · rust-lang/rust

cramertj · 2018-06-05T00:18:03Z

fdio_spawn_etc is the preferred way of creating processes on Fuchsia
now.

cc @abarth

rust-highfive · 2018-06-05T00:18:07Z

r? @withoutboats

(rust_highfive has picked a reviewer for you, use r? to override)

cramertj · 2018-06-05T00:20:11Z

r? @sfackler I guess?

rust-highfive · 2018-06-05T00:33:20Z

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.


[00:04:38] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:04:39] tidy error: /checkout/src/libstd/sys/unix/process/process_fuchsia.rs:85: trailing whitespace
[00:04:39] tidy error: /checkout/src/libstd/sys/unix/process/process_fuchsia.rs:95: line longer than 100 chars
[00:04:39] tidy error: /checkout/src/libstd/sys/unix/process/process_fuchsia.rs:96: line longer than 100 chars
[00:04:40] some tidy checks failed
[00:04:40] [00:04:40] [00:04:40] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:04:40] [00:04:40] [00:04:40] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:04:40] Build completed unsuccessfully in 0:01:37
[00:04:40] Build completed unsuccessfully in 0:01:37
[00:04:40] Makefile:79: recipe for target 'tidy' failed
[00:04:40] make: *** [tidy] Error 1
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:019ac250
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

sfackler · 2018-06-05T03:45:03Z

Tidy failures, but r=me otherwise.

abarth · 2018-06-05T03:52:14Z

nit: We renamed FDIO_SPAWN_SHARE_JOB to FDIO_SPAWN_CLONE_JOB in the C header. Might be worth aligning here.

abarth · 2018-06-05T03:52:23Z

cramertj · 2018-06-05T17:59:48Z

@bors r=sfackler

bors · 2018-06-05T17:59:49Z

📌 Commit aa23aba has been approved by sfackler

@abarth

[fuchsia] Migrate from launchpad to fdio_spawn_etc fdio_spawn_etc is the preferred way of creating processes on Fuchsia now. cc @abarth

@abarth

[fuchsia] Migrate from launchpad to fdio_spawn_etc fdio_spawn_etc is the preferred way of creating processes on Fuchsia now. cc @abarth

@abarth

[fuchsia] Migrate from launchpad to fdio_spawn_etc fdio_spawn_etc is the preferred way of creating processes on Fuchsia now. cc @abarth

bors · 2018-06-07T04:42:17Z

⌛ Testing commit aa23aba with merge fc3ad51a9e906bf5690d03ff661c4fd6507f724b...

fdio_spawn_etc is the preferred way of creating processes on Fuchsia now.

cramertj · 2018-06-07T16:23:24Z

@bors r=sfackler

bors · 2018-06-07T16:23:24Z

📌 Commit 0c6cd26 has been approved by sfackler

bors · 2018-06-08T09:06:19Z

⌛ Testing commit 0c6cd26 with merge b6b9886a757a40a910d5155f3c5c59b83428da1c...

bors · 2018-06-08T09:20:17Z

💔 Test failed - status-travis

kennytm · 2018-06-08T10:15:45Z

@bors retry

@abarth

[fuchsia] Migrate from launchpad to fdio_spawn_etc fdio_spawn_etc is the preferred way of creating processes on Fuchsia now. cc @abarth

bors · 2018-06-09T03:41:37Z

⌛ Testing commit 0c6cd26 with merge 40f20b5...

bors · 2018-06-09T05:49:13Z

☀️ Test successful - status-appveyor, status-travis
Approved by: sfackler
Pushing 40f20b5 to master...

rust-highfive assigned withoutboats Jun 5, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 5, 2018

rust-highfive assigned sfackler and unassigned withoutboats Jun 5, 2018

abarth reviewed Jun 5, 2018
View reviewed changes

Comment threadsrc/libstd/sys/unix/process/process_fuchsia.rs Outdated
abarthJun 5, 2018
Copy link
Copy Markdown
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!

cramertj force-pushed the fdio_spawn branch from 8e85492 to aa23abaCompare June 5, 2018 16:58

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 5, 2018

Mark-Simulacrum mentioned this pull request Jun 5, 2018
Rollup of 5 pull requests #51379
Closed

Mark-Simulacrum mentioned this pull request Jun 6, 2018
Rollup of 9 pull requests #51403
Closed

Mark-Simulacrum mentioned this pull request Jun 7, 2018
Rollup of 7 pull requests #51406
Closed

This comment has been minimized.
Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 7, 2018

This comment has been minimized.
Sign in to view

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 7, 2018

This comment has been minimized.
Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 7, 2018

[fuchsia] Migrate from launchpad to fdio_spawn_etc
0c6cd26
fdio_spawn_etc is the preferred way of creating processes on Fuchsia now.

cramertj force-pushed the fdio_spawn branch from aa23aba to 0c6cd26Compare June 7, 2018 16:23

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 7, 2018

This comment has been minimized.
Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 8, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 8, 2018

rust-lang deleted a comment from rust-highfive Jun 8, 2018

bors added a commit that referenced this pull request Jun 9, 2018
Auto merge of#51359- cramertj:fdio_spawn, r=sfackler
40f20b5
[fuchsia] Migrate from launchpad to fdio_spawn_etc fdio_spawn_etc is the preferred way of creating processes on Fuchsia now. cc @abarth

bors merged commit 0c6cd26 into rust-lang:masterJun 9, 2018

cramertj deleted the fdio_spawn branch June 11, 2018 16:58

Uh oh!

Uh oh!

Conversation

cramertj commented Jun 5, 2018

Uh oh!

rust-highfive commented Jun 5, 2018

Uh oh!

cramertj commented Jun 5, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Jun 5, 2018

Uh oh!

sfackler commented Jun 5, 2018

Uh oh!

abarthJun 5, 2018

Choose a reason for hiding this comment

Uh oh!

cramertjJun 5, 2018

Choose a reason for hiding this comment

Uh oh!

abarthJun 5, 2018

Choose a reason for hiding this comment

Uh oh!

cramertj commented Jun 5, 2018

Uh oh!

bors commented Jun 5, 2018

Uh oh!

bors commented Jun 7, 2018

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

cramertj commented Jun 7, 2018

Uh oh!

bors commented Jun 7, 2018

Uh oh!

bors commented Jun 8, 2018

Uh oh!

bors commented Jun 8, 2018

Uh oh!

This comment has been minimized.

kennytm commented Jun 8, 2018

Uh oh!

bors commented Jun 9, 2018

Uh oh!

bors commented Jun 9, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

cramertj commented Jun 5, 2018•
edited
Loading