Uh oh!
There was an error while loading. Please reload this page.
Rollup of 7 pull requests - #51369
Merged
Merged
Conversation
Refactor hiding example to be more complete
When subtracting an Instant from another, the function will panick when `RHS > self`, but the error message confusingly displays a different error:
```rust
let i = Instant::now();
let other = Instant::now();
if other > i {
println!("{:?}", i - other);
}
```
This results in a panic:
```
thread 'test_instant' panicked at 'other was less than the current instant', libstd/sys/unix/time.rs:292:17
```Uses the same wording as [`src/libstd/sys/windows/time.rs`][1]. 1: https://github.com/avdv/rust/blob/95e2bf253d864c5e14ad000ffa2040ce85916056/src/libstd/sys/windows/time.rs#L65
…, r=GuillaumeGomez Add doc comment to hiding portions of code example fixesrust-lang#50816 Not sure if this is all that's needed, but I think it's a good start. One thing to note is that the code block is a text block where it could possibly be a rust block.
…=steveklabnik Update rustdoc book to suggest using Termination trait instead of hidden ‘foo’ function Closesrust-lang#50721. I suggest that someone double-checks my English since I am not a native speaker. r? @steveklabnik
Fix confusing error message for sub_instant
When subtracting an Instant from another, the function will panick when `RHS > self`, but the error message confusingly displays a different error:
```rust
let i = Instant::now();
let other = Instant::now();
if other > i {
println!("{:?}", i - other);
}
```
This results in a panic:
```
thread 'test_instant' panicked at 'other was less than the current instant', libstd/sys/unix/time.rs:292:17
```
But clearly, `other` was actually greater than the current instant.…me, r=QuietMisdreavus Fix crate-name option in rustdoc Fixesrust-lang#51229. r? @QuietMisdreavus
…ck, r=oli-obk Check array indices in constant propagation Previously, uses of constant weren't correctly propagated. This fixesrust-lang#48920. r? @oli-obk because you suggested it
test: Ignore some problematic tests on sparc and sparc64 This updates the list of tests which can be safely ignored on sparc and sparc64.
Tests that rust-lang#39963 is fixed on MIR borrowck As title. fixesrust-lang#39963
rust-highfive
commented
Jun 5, 2018
Contributor
r? @frewsxcv (rust_highfive has picked a reviewer for you, use r? to override) |
Mark-Simulacrum
commented
Jun 5, 2018
MemberAuthor
@bors r+ p=10 |
bors
commented
Jun 5, 2018
Collaborator
📌 Commit d011150 has been approved by |
bors
commented
Jun 5, 2018
Collaborator
bors added a commit
that referenced
this pull request
Jun 5, 2018
Rollup of 7 pull requests Successful merges: - #50852 (Add doc comment to hiding portions of code example) - #51183 (Update rustdoc book to suggest using Termination trait instead of hidden ‘foo’ function) - #51255 (Fix confusing error message for sub_instant) - #51256 (Fix crate-name option in rustdoc) - #51308 (Check array indices in constant propagation) - #51343 (test: Ignore some problematic tests on sparc and sparc64) - #51358 (Tests that #39963 is fixed on MIR borrowck) Failed merges:
bors
commented
Jun 5, 2018
Collaborator
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
Failed merges: