Uh oh!
There was an error while loading. Please reload this page.
Removed uninitialized_statics field from Memory struct in miri - #51428
Conversation
alexreg
commented
Jun 8, 2018
@oli-obk All tests are passing locally, just waiting on Travis here. See my message on Discord re |
rust-highfive
commented
Jun 8, 2018
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
oli-obk
commented
Jun 8, 2018
Could you also check how much of an impact this has on the miri submodule? |
oli-obk
left a comment
There was a problem hiding this comment.
That was less fallout than I feared!
There was a problem hiding this comment.
I think these two maps can now be merged into one
alexreg
commented
Jun 8, 2018
How do you mean, exactly? |
alexreg
commented
Jun 8, 2018
What's the Travis test failure due to, do you think? Not happening on my machine. |
oli-obk
commented
Jun 8, 2018
Well... I guess we first need to fix miri on nightly before it would make sense to adjust it to the changes of this PR |
rust-highfive
commented
Jun 8, 2018
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
oli-obk
commented
Jun 8, 2018
Not sure. Can you provide a |
alexreg
commented
Jun 8, 2018
@oli-obk The test passes locally though so... |
alexreg
commented
Jun 8, 2018
Oh, the errors are to do with |
emilyalbini
commented
Jun 18, 2018
Blocked on #51110. |
This comment has been minimized.
This comment has been minimized.
alexreg
commented
Jun 24, 2018
Err, looks like a transitory issue with CI. |
emilyalbini
commented
Jun 25, 2018
Manually restarted the build. |
rust-highfive
commented
Jun 25, 2018
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
alexreg
commented
Jun 25, 2018
Okay, that’s the same error I’m getting in the PR blocking this. Looks like something changed in master with the rebase. |
bors
commented
Jun 29, 2018
☔ The latest upstream changes (presumably #51884) made this pull request unmergeable. Please resolve the merge conflicts. |
@oli-obk Okay, I've rebased over master now that #51110 has merged. I think we're ready to merge this too now! @pietroalbini I don't know if you need to remove the |
rust-highfive
commented
Jul 2, 2018
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
rust-highfive
commented
Jul 2, 2018
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
There was a problem hiding this comment.
I fixed this though! WTF?
rust-highfive
commented
Jul 2, 2018
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
rust-highfive
commented
Jul 2, 2018
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Refactored code accordingly.
oli-obk
commented
Jul 2, 2018
@bors r+ |
bors
commented
Jul 2, 2018
📌 Commit 6660c25 has been approved by |
…ification, r=oli-obk Removed `uninitialized_statics` field from `Memory` struct in miri **IMPORTANT: Do not merge until rust-lang#51110 is merged** r? @oli-obk CC @eddyb
bors
commented
Jul 3, 2018
bors
commented
Jul 3, 2018
☀️ Test successful - status-appveyor, status-travis |
rust-highfive
commented
Jul 3, 2018
Tested on commit rust-lang/rust@81d5c3e. Direct link to PR: <rust-lang/rust#51428> 🎉 miri on windows: build-fail → test-pass. 🎉 miri on linux: build-fail → test-pass.
based on #51110
r? @oli-obk
CC @eddyb