Uh oh!
There was an error while loading. Please reload this page.
rustdoc: process cross-crate glob re-exports - #51584
Merged
Merged
Conversation
rust-highfive
commented
Jun 15, 2018
Contributor
r? @frewsxcv (rust_highfive has picked a reviewer for you, use r? to override) |
QuietMisdreavus
commented
Jun 15, 2018
ContributorAuthor
r? @ollie27 |
ollie27
commented
Jun 16, 2018
Contributor
Looks good to me. @bors r+ |
bors
commented
Jun 16, 2018
Collaborator
@ollie27: 🔑 Insufficient privileges: Not in reviewers |
petrochenkov
commented
Jun 16, 2018
Contributor
bors
commented
Jun 16, 2018
Collaborator
📌 Commit 042f1df has been approved by |
bors
commented
Jun 16, 2018
Collaborator
✌️ @ollie27 can now approve this pull request |
bors
commented
Jun 16, 2018
Collaborator
bors added a commit
that referenced
this pull request
Jun 16, 2018
rustdoc: process cross-crate glob re-exports Turns out, we were deliberately ignoring glob re-exports when they were occurring across crates, even though we were fully processing them for local re-exports. This will at least bring the two into parity. Fixes#51252
bors
commented
Jun 16, 2018
Collaborator
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out, we were deliberately ignoring glob re-exports when they were occurring across crates, even though we were fully processing them for local re-exports. This will at least bring the two into parity.
Fixes#51252