Skip to content

Combine all builtin late lints - #51678

Merged
bors merged 1 commit into
rust-lang:masterfrom
Zoxc:combine-lints
Jun 26, 2018
Merged

Combine all builtin late lints#51678
bors merged 1 commit into
rust-lang:masterfrom
Zoxc:combine-lints

Conversation

@Zoxc

@ZoxcZoxc commented Jun 21, 2018

Copy link
Copy Markdown
Contributor

No description provided.

@rust-highfive

rust-highfive commented Jun 21, 2018

Copy link
Copy Markdown
Contributor

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 21, 2018
@Zoxc

Zoxc commented Jun 21, 2018

Copy link
Copy Markdown
ContributorAuthor

@bors try

@bors

bors commented Jun 21, 2018

Copy link
Copy Markdown
Collaborator

⌛ Trying commit ebb4a708d79ded9db0860e92efd0042ae2e48334 with merge 467cf3c80ae91949cd435870ae33b27310c02d1c...

@kennytm

kennytm commented Jun 21, 2018

Copy link
Copy Markdown
Member

@Zoxc If you're trying for perf, we can't do it until #51680 is merged (see #51356 (comment)).

@bors

bors commented Jun 21, 2018

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-travis
State: approved= try=True

@Zoxc

Zoxc commented Jun 21, 2018

Copy link
Copy Markdown
ContributorAuthor

@bors try

@bors

bors commented Jun 21, 2018

Copy link
Copy Markdown
Collaborator

⌛ Trying commit c5ecc6f with merge 8059be493eda3c285d334e22c36b80071ee2a2a4...

@kennytm

kennytm commented Jun 21, 2018

Copy link
Copy Markdown
Member

@bors r- try- retry

The try build is complete but we've restarted bors and got the states confused.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 21, 2018
@kennytmkennytm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-perf Status: Waiting on a perf run to be completed. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 21, 2018
@kennytm

kennytm commented Jun 24, 2018

Copy link
Copy Markdown
Member

@Mark-Simulacrum perf is requested try#8059be493eda3c285d334e22c36b80071ee2a2a4 vs master#f790780451a724dce9be0ba03ff217955036ff88.

@Mark-Simulacrum

Mark-Simulacrum commented Jun 24, 2018

Copy link
Copy Markdown
Member

Perf queued.

@Zoxc

Zoxc commented Jun 24, 2018

Copy link
Copy Markdown
ContributorAuthor

Result: https://perf.rust-lang.org/compare.html?start=f790780451a724dce9be0ba03ff217955036ff88&end=8059be493eda3c285d334e22c36b80071ee2a2a4&stat=instructions%3Au

@estebank

estebank commented Jun 25, 2018

Copy link
Copy Markdown
Contributor

@Zoxc great! I feel comfortable merging this as is. Do you have any outstanding change before I approve?

@kennytmkennytm removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 25, 2018
@Zoxc

Zoxc commented Jun 25, 2018

Copy link
Copy Markdown
ContributorAuthor

@estebank No, this should be good to go.

@estebank

estebank commented Jun 25, 2018

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Jun 25, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit c5ecc6f has been approved by estebank

@borsbors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 25, 2018
@borsbors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 25, 2018
@bors

bors commented Jun 26, 2018

Copy link
Copy Markdown
Collaborator

⌛ Testing commit c5ecc6f with merge 2808460...

bors added a commit that referenced this pull request Jun 26, 2018
@bors
Auto merge of#51678- Zoxc:combine-lints, r=estebank
2808460
Combine all builtin late lints
@bors

bors commented Jun 26, 2018

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-appveyor, status-travis
Approved by: estebank
Pushing 2808460 to master...

@bors
bors merged commit c5ecc6f into rust-lang:masterJun 26, 2018
This was referenced Jun 26, 2018
Merged
Merged
@Zoxc
Zoxc deleted the combine-lints branch August 6, 2018 22:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@estebankestebank

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Zoxc@rust-highfive@bors@kennytm@Mark-Simulacrum@estebank