Uh oh!
There was an error while loading. Please reload this page.
incr.comp.: Take names of children into account when computing the ICH of a module's HIR. - #51982
Merged
Merged
Conversation
…H of a module's HIR.
Mark-Simulacrum
commented
Jul 2, 2018
Member
@bors retry |
Mark-Simulacrum
commented
Jul 2, 2018
Member
er, @bors try |
bors
commented
Jul 2, 2018
Collaborator
bors added a commit
that referenced
this pull request
Jul 2, 2018
incr.comp.: Take names of children into account when computing the ICH of a module's HIR. Fixes#40876. Red-green tracking does not make this a problem anymore. We should verify this via a perf-run though. r? @nikomatsakis
bors
commented
Jul 2, 2018
Collaborator
☀️ Test successful - status-travis |
nikomatsakis
commented
Jul 2, 2018
Contributor
r=me modulo perf |
Mark-Simulacrum
commented
Jul 2, 2018
Member
Perf started |
michaelwoerister
commented
Jul 3, 2018
MemberAuthor
Interesting. That fix in I'll apply another small optimization to the hashing of the DefPathHashes and then r=niko. |
michaelwoerister
commented
Jul 3, 2018
MemberAuthor
@bors r=nikomatsakis |
bors
commented
Jul 3, 2018
Collaborator
📌 Commit 447f1f3 has been approved by |
emilyalbini added a commit
to emilyalbini/rust
that referenced
this pull request
Jul 3, 2018
…rly, r=nikomatsakis incr.comp.: Take names of children into account when computing the ICH of a module's HIR. Fixesrust-lang#40876. Red-green tracking does not make this a problem anymore. We should verify this via a perf-run though. r? @nikomatsakis
emilyalbini added a commit
to emilyalbini/rust
that referenced
this pull request
Jul 3, 2018
…rly, r=nikomatsakis incr.comp.: Take names of children into account when computing the ICH of a module's HIR. Fixesrust-lang#40876. Red-green tracking does not make this a problem anymore. We should verify this via a perf-run though. r? @nikomatsakis
bors added a commit
that referenced
this pull request
Jul 3, 2018
Rollup of 13 pull requests Successful merges: - #51548 (Initialize LLVM's AMDGPU target machine, if available.) - #51809 (Add read_exact_at and write_all_at methods to FileExt on unix) - #51914 (add outlives annotations to `BTreeMap`) - #51958 (Show known meta items in unknown meta items error) - #51973 (Make Stdio handle UnwindSafe) - #51977 (bootstrap: tests should use rustc from config.toml) - #51978 (Do not suggest changes to str literal if it isn't one) - #51979 (Get rid of `TyImplTraitExistential`) - #51980 (Emit column info in debuginfo for non msvc like targets) - #51982 (incr.comp.: Take names of children into account when computing the ICH of a module's HIR.) - #51997 (add entry for cargo-metadata feature to RELEASES) - #52004 (toolstate: Fixed detection of changed submodule, and other fixes.) - #52006 ( Change --keep-stage to apply more often) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#40876. Red-green tracking does not make this a problem anymore. We should verify this via a perf-run though.
r? @nikomatsakis