Skip to content

Deny bare trait objects in src/bootstrap - #52220

Merged
bors merged 2 commits into
rust-lang:masterfrom
ljedrz:dyn_bootstrap
Jul 12, 2018
Merged

Deny bare trait objects in src/bootstrap#52220
bors merged 2 commits into
rust-lang:masterfrom
ljedrz:dyn_bootstrap

Conversation

@ljedrz

Copy link
Copy Markdown
Contributor

Enforce #![deny(bare_trait_objects)] in src/bootstrap.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 10, 2018
@petrochenkov

Copy link
Copy Markdown
Contributor

cc rust-lang/cargo#5034

Comment threadsrc/bootstrap/lib.rs
//! More documentation can be found in each respective module below, and you can
//! also check out the `src/bootstrap/README.md` file for more information.

#![deny(warnings)]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be kept ?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, you're right - I actually misread it as #![allow(warnings)] 🙈. I'll revert this bit.

@kennytm

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Jul 12, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 72b908f has been approved by kennytm

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 12, 2018
@ljedrzljedrz changed the title Deny bare trait objects in src/bootstrapDeny bare trait objects in src/bootstrapJul 12, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Jul 12, 2018
Deny bare trait objects in `src/bootstrap`
Enforce `#![deny(bare_trait_objects)]` in `src/bootstrap`.
@kennytmkennytm mentioned this pull request Jul 12, 2018
bors added a commit that referenced this pull request Jul 12, 2018
Rollup of 9 pull requests
Successful merges:
- #51816 (bootstrap: write texts to a .tmp file first for atomicity)
- #51912 (impl Clone for Box<CStr>, Box<OsStr>, Box<Path>)
- #52164 (use proper footnote syntax for references)
- #52220 (Deny bare trait objects in `src/bootstrap`)
- #52276 (rustc: Verify #[proc_macro] is only a word)
- #52277 (Uncapitalize "If")
- #52287 (Deny bare trait objects in src/librustc_resolve)
- #52295 (Deny bare trait objects in src/libsyntax_ext)
- #52298 (make reference to dirs crate clickable in terminals)
Failed merges:
r? @ghost
@bors
bors merged commit 72b908f into rust-lang:masterJul 12, 2018
@ljedrz
ljedrz deleted the dyn_bootstrap branch July 12, 2018 15:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@ljedrz@rust-highfive@petrochenkov@kennytm@bors@Eijebong@aturon