Fix doc link

[felixrabe]

Result of first searching via:

find src -type f -exec fgrep -l dynamically-sized-types--sized {} \;

and then replacing all relevant occurrences via:

find src/{libcore,test/ui} -type f -exec sed -i.bak \
s/dynamically-sized-types--sized/dynamically-sized-types-and-sized/g {} \;
find src -type f -name '*.bak' -exec rm {} \;

(Note: Commands run on macOS 10.13 (BSD). sed -i.bak should work on
GNU/Linux as well, but not tested.)

EDIT: Did not compile / test Rust for this change at all.

Clickable links for comparison:
https://doc.rust-lang.org/book/second-edition/ch19-04-advanced-types.html#dynamically-sized-types--sized (broken)
https://doc.rust-lang.org/book/second-edition/ch19-04-advanced-types.html#dynamically-sized-types-and-sized (fixed)

[GuillaumeGomez]

Thanks!

@bors: r+ rollup

[bors]

📌 Commit 2ffdf0b115c7319176dd2756af4803933133ee2f has been approved by GuillaumeGomez

[kennytm]

@bors r- rollup- p=1

A lot of new UI tests have included the broken link. You may see them after rebasing on the latest master. For reference, see the error log in #52433.

[felixrabe]

@kennytm refined my commit commands and have re-run them against master.

[GuillaumeGomez]

Ok, let's have it tested on its own. Once CI is ok, r=me

[kennytm]

@bors r=GuillaumeGomez

[bors]

📌 Commit 88e9af0 has been approved by GuillaumeGomez

[bors]

⌛ Testing commit 88e9af0 with merge 1c84d81...

[bors]

☀️ Test successful - status-appveyor, status-travis
Approved by: GuillaumeGomez
Pushing 1c84d81 to master...

[ehuss]

Unfortunately this link will be broken again once 1.28 is released. The new section header will be #dynamically-sized-types-and-the-sized-trait.

cc @carols10cents or @steveklabnik is there maybe a better way to have more stable URLs?

[kennytm]

I think mdbook should support adding an anchor via HTML <a name="dynamically-sized-types-and-sized"></a>?

[felixrabe]

@ehuss@kennytm If the 1.28 link change is the only one you anticipate, It should be easy to modify and re-run the commands from the commit description. Or you can ping me and I'll do it again.

[carols10cents]

The second edition is now frozen because the book has been printed and we intend to keep the second edition the same as what was printed, so these section headings should no longer be changing, if that helps.

[ehuss]

@carols10cents can small changes like adding <a> tags be made, or is it completely frozen? Maybe it would be easiest to just go ahead and have @felixrabe update for the new heading?

[carols10cents]

@carols10cents can small changes like adding tags be made, or is it completely frozen? Maybe it would be easiest to just go ahead and have @felixrabe update for the new heading?

@ehuss I don't understand? Why do you need to add a link in the book?

I think updating the link here to https://doc.rust-lang.org/book/second-edition/ch19-04-advanced-types.html#dynamically-sized-types-and-sized is correct because the <a> tag for #dynamically-sized-types-and-sized is in the second edition and won't change again.

[ehuss]

Why do you need to add a link in the book?

I was just thinking for people running older versions of the compiler, it will still point to the old location. Adding an <a name=".."> tag with the old name would make it work for them. However, I don't think it is all that important (it's pretty easy to figure it out when the page doesn't scroll). Whichever is easiest!

[felixrabe]

Ok so.... I've just clicked the link again today, and someone changed it. (And I happen to have to click that link a lot, being a beginner and all 🙂)

broken link: https://doc.rust-lang.org/book/second-edition/ch19-04-advanced-types.html#dynamically-sized-types-and-sized

correct link: https://doc.rust-lang.org/book/second-edition/ch19-04-advanced-types.html#dynamically-sized-types-and-the-sized-trait

also on nightly: https://doc.rust-lang.org/nightly/book/second-edition/ch19-04-advanced-types.html#dynamically-sized-types-and-the-sized-trait

also on nightly / 2018 edition: https://doc.rust-lang.org/nightly/book/2018-edition/ch19-04-advanced-types.html#dynamically-sized-types-and-the-sized-trait

New PR: #53082.