Skip to content

Implement Iterator::size_hint for Elaborator. - #52858

Merged
bors merged 1 commit into
rust-lang:masterfrom
frewsxcv:frewsxcv-elaborator
Aug 17, 2018
Merged

Implement Iterator::size_hint for Elaborator.#52858
bors merged 1 commit into
rust-lang:masterfrom
frewsxcv:frewsxcv-elaborator

Conversation

@frewsxcv

@frewsxcvfrewsxcv commented Jul 30, 2018

Copy link
Copy Markdown
Contributor

No description provided.

@rust-highfive

rust-highfive commented Jul 30, 2018

Copy link
Copy Markdown
Contributor

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[00:55:47] [00:55:47] running 247 tests
[00:56:13] .....................i..............................................................................
[00:56:36] ...................i................................................................................
"x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-5.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options " "--target-rustcflags" "-Crpath -O -Zunstable-options -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "5.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[00:56:43] [00:56:43] [00:56:43] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[00:56:43] Build completed unsuccessfully in 0:15:23
[00:56:43] Build completed unsuccessfully in 0:15:23
[00:56:43] make: *** [check] Error 1
[00:56:43] Makefile:58: recipe for target 'check' failed
2871592 ./obj
2762568 ./obj/build
2165572 ./obj/build/x86_64-unknown-linux-gnu
786328 ./src
---
145460 ./obj/build/bootstrap/debug/incremental
133976 ./obj/build/x86_64-unknown-linux-gnu/stage1-rustc/x86_64-unknown-linux-gnu
133972 ./obj/build/x86_64-unknown-linux-gnu/stage1-rustc/x86_64-unknown-linux-gnu/release
130592 ./obj/build/bootstrap/debug/incremental/bootstrap-c7ee2tfsizs
130588 ./obj/build/bootstrap/debug/incremental/bootstrap-c7ee2tfsizs/s-f3dyez5hwf-3s9z4x-3t5kexjst7huj
128820 ./obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release
122972 ./obj/build/x86_64-unknown-linux-gnu/stage1-rustc/x86_64-unknown-linux-gnu/release/deps
121808 ./obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release/deps
113404 ./obj/build/x86_64-unknown-linux-gnu/test/mir-opt
---
travis_time:end:10c3507f:start=1532959607469926352,finish=1532959607477705408,duration=7779056
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0508945e
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@rust-highfive

rust-highfive commented Jul 30, 2018

Copy link
Copy Markdown
Contributor

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[01:03:46] .....................i..............................................................................
[01:04:12] ...................i................................................................................
] error: internal compiler error: unexpected panic
[01:04:19] [01:04:19] note: the compiler unexpectedly panicked. this is a bug.
[01:04:19] [01:04:19] note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
[01:04:19] note: rustc 1.29.0-dev running on x86_64-unknown-linux-gnu
[01:04:19] [01:04:19] [01:04:19] ------------------------------------------
---
[01:04:19] [01:04:19] thread 'main' panicked at 'Some tests failed', tools/compiletest/src/main.rs:498:22
[01:04:19] [01:04:19] [01:04:19] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--rustdoc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustdoc" "--src-base" "/checkout/src/test/rustdoc" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "rustdoc" "--target" "x86_64-unknown-linux-gnu" "--host"
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:164483a6
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Mark-Simulacrum

Mark-Simulacrum commented Jul 30, 2018

Copy link
Copy Markdown
Member

r? @SimonSapin

@kennytmkennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 1, 2018
@XAMPPRocky

XAMPPRocky commented Aug 10, 2018

Copy link
Copy Markdown
Contributor

Triage: @SimonSapin Do you have time to review this PR?

@SimonSapin

SimonSapin commented Aug 10, 2018

Copy link
Copy Markdown
Contributor

Oops, sorry for the delay.

I’m not familiar with this part of compiler internals but based on reading surrounding code: the lower bound look accurate, but I think the upper bound should be None. Iterator::next can call Elaborator::push which can call self.stack.extend(…).

@TimNNTimNN added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 14, 2018
@frewsxcv

frewsxcv commented Aug 17, 2018

Copy link
Copy Markdown
ContributorAuthor

based on reading surrounding code: the lower bound look accurate, but I think the upper bound should be None. Iterator::next can call Elaborator::push which can call self.stack.extend(…)

Addressed in the latest force push.

@SimonSapin

SimonSapin commented Aug 17, 2018

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Aug 17, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 742ef58 has been approved by SimonSapin

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 17, 2018
@bors

bors commented Aug 17, 2018

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 742ef58 with merge 7af5ff31898fb613859a9c8c8ff289db2b8bf32f...

@bors

bors commented Aug 17, 2018

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-appveyor

@borsbors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 17, 2018
@frewsxcv

frewsxcv commented Aug 17, 2018

Copy link
Copy Markdown
ContributorAuthor

@bors retry rollup

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 17, 2018
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Aug 17, 2018
@frewsxcv
Rollup merge ofrust-lang#52858- frewsxcv:frewsxcv-elaborator, r=Sim…
2578036
…onSapin
Implement Iterator::size_hint for Elaborator.
None
@frewsxcvfrewsxcv mentioned this pull request Aug 17, 2018
Merged
bors added a commit that referenced this pull request Aug 17, 2018
@bors
Auto merge of#53449- frewsxcv:rollup, r=frewsxcv
de21ea8
Rollup of 11 pull requests
Successful merges:
- #52858 (Implement Iterator::size_hint for Elaborator.)
- #53321 (Fix usage of `wasm_target_feature`)
- #53326 ([nll] add regression test for issue #27868)
- #53347 (rustc_resolve: don't allow paths starting with `::crate`.)
- #53349 ([nll] add tests for #48697 and #30104)
- #53357 (Pretty print btreemap for GDB)
- #53358 (`{to,from}_{ne,le,be}_bytes` for unsigned integer types)
- #53406 (Do not suggest conversion method that is already there)
- #53407 (make more ported compile fail tests more robust w.r.t. NLL)
- #53413 (Warn that `#![feature(rust_2018_preview)]` is implied when the edition is set to Rust 2018.)
- #53434 (wasm: Remove --strip-debug argument to LLD)
Failed merges:
r? @ghost
@bors
bors merged commit 742ef58 into rust-lang:masterAug 17, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@SimonSapinSimonSapin

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@frewsxcv@rust-highfive@Mark-Simulacrum@XAMPPRocky@SimonSapin@bors@kennytm@TimNN