Skip to content

run-pass/simd-intrinsic-float-minmax: Force use of qNaN on Mips - #52895

Merged
bors merged 1 commit into
rust-lang:masterfrom
draganmladjenovic:minmax_qnan
Aug 14, 2018
Merged

run-pass/simd-intrinsic-float-minmax: Force use of qNaN on Mips#52895
bors merged 1 commit into
rust-lang:masterfrom
draganmladjenovic:minmax_qnan

Conversation

@draganmladjenovic

@draganmladjenovicdraganmladjenovic commented Jul 31, 2018•
edited
Loading

Copy link
Copy Markdown

Workaround for #52746.
r? @gnzlbg

@rust-highfive

rust-highfive commented Jul 31, 2018

Copy link
Copy Markdown
Contributor

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 31, 2018
@gnzlbg

gnzlbg commented Jul 31, 2018

Copy link
Copy Markdown
Contributor

LGTM. I've opened #52897 to track one of the issues raised in #52746 .

@draganmladjenovic

draganmladjenovic commented Aug 13, 2018•
edited
Loading

Copy link
Copy Markdown
Author

r? @gnzlbg

Sorry my first assignment change didn't get picked up. I don't think I have sufficient rights to merge this anyway, so assigning this to you.

@gnzlbg

gnzlbg commented Aug 13, 2018•
edited
Loading

Copy link
Copy Markdown
Contributor

cc @alexcrichton - the problem here is that the bitpattern used for NAN is a QNAN in most archs, but an SNAN on mips and that breaks this test for the time being. It is currently unclear in LLVM which semantics min and max should have w.r.t. SNAN, so we'll revisit this when that is resolved (see #52897 ).

In the mean time, this test breaking blocks further work on MIPS64 support.

@alexcrichton

alexcrichton commented Aug 14, 2018

Copy link
Copy Markdown
Member

@bors: r+

This is fine for now yeah, but definitely seems like something to sort before stabilization!

@bors

bors commented Aug 14, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 78a1c45 has been approved by alexcrichton

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 14, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Aug 14, 2018
@kennytm
Rollup merge ofrust-lang#52895- draganmladjenovic:minmax_qnan, r=al…
c80cf1a
…excrichton
run-pass/simd-intrinsic-float-minmax: Force use of qNaN on Mips
Workaround for rust-lang#52746.
@kennytmkennytm mentioned this pull request Aug 14, 2018
Closed
@bors

bors commented Aug 14, 2018

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 78a1c45 with merge a8763b5...

bors added a commit that referenced this pull request Aug 14, 2018
@bors
Auto merge of#52895- draganmladjenovic:minmax_qnan, r=alexcrichton
a8763b5
run-pass/simd-intrinsic-float-minmax: Force use of qNaN on Mips
Workaround for #52746.
r? @gnzlbg
@bors

bors commented Aug 14, 2018

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing a8763b5 to master...

@bors
bors merged commit 78a1c45 into rust-lang:masterAug 14, 2018
@RalfJungRalfJung mentioned this pull request Mar 18, 2026
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@aturonaturon

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@draganmladjenovic@rust-highfive@gnzlbg@alexcrichton@bors@aturon