Uh oh!
There was an error while loading. Please reload this page.
region error messages involving impls are confusing - #53124
Merged
Merged
Conversation
nikomatsakis
commented
Aug 6, 2018
Contributor
@bors r+ |
1 similar comment
nikomatsakis
commented
Aug 7, 2018
Contributor
@bors r+ |
bors
commented
Aug 7, 2018
Collaborator
📌 Commit 12037ff has been approved by |
nikomatsakis
commented
Aug 7, 2018
Contributor
@bors delegate=davidtwco |
bors
commented
Aug 7, 2018
Collaborator
✌️ @davidtwco can now approve this pull request |
cramertj added a commit
to cramertj/rust
that referenced
this pull request
Aug 8, 2018
region error messages involving impls are confusing Part of rust-lang#52742. r? @nikomatsakis
bors
commented
Aug 9, 2018
Collaborator
bors added a commit
that referenced
this pull request
Aug 9, 2018
region error messages involving impls are confusing Part of #52742. r? @nikomatsakis
bors
commented
Aug 9, 2018
Collaborator
💔 Test failed - status-appveyor |
kennytm
commented
Aug 9, 2018
Member
@bors r- failures:
---- [ui] ui\nll\issue-52742.rs stdout ----
diff of stderr:
- error: unsatisfied lifetime constraints- --> $DIR/issue-52742.rs:25:9+ error[E0106]: missing lifetime specifiers+ --> $DIR/issue-52742.rs:23:10
3 |
- LL | fn take_bar(&mut self, b: Bar<'_>) {- | --------- -- let's call this `'1`- | |- | has type `&mut Foo<'_, '2>`- LL | self.y = b.z- | ^^^^^^^^^^^^ requires that `'1` must outlive `'2`+ LL | impl Foo<'_, '_> {+ | ^^ expected 2 lifetime parameters
10 11 error: aborting due to previous error
12 + For more information about this error, try `rustc --explain E0106`.
13 |
| // except according to those terms. | ||
| #![feature(nll)] | ||
| #![feature(in_band_lifetimes)] |
Contributor
There was a problem hiding this comment.
the problem here is that we now need another feature gate here
#![feature(impl_header_lifetime_elision)]
nikomatsakis
commented
Aug 9, 2018
Contributor
@bors r+ |
bors
commented
Aug 9, 2018
Collaborator
📌 Commit 31657c9 has been approved by |
bors
commented
Aug 10, 2018
Collaborator
bors added a commit
that referenced
this pull request
Aug 10, 2018
region error messages involving impls are confusing Part of #52742. r? @nikomatsakis
bors
commented
Aug 10, 2018
Collaborator
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #52742.
r? @nikomatsakis