Uh oh!
There was an error while loading. Please reload this page.
Re-enable a bunch of debuginfo tests. - #53154
Conversation
This comment has been minimized.
This comment has been minimized.
d485ef5 to
4eb52ffComparemichaelwoerister
commented
Aug 7, 2018
Seems to work now. r? @kennytm |
| // gdb-command: print os_string | ||
| // gdb-check:$7 = "IAMA OS string 😃" | ||
| // gdb-check:$7 = "IAMA OS string" |
There was a problem hiding this comment.
Is the emoji essential? #42278 (comment) mentioned something about Unicode.
There was a problem hiding this comment.
I don't think it's essential. In my terminal emulator this prints as the emoji, but on CI it seems to print escaped to octals. I did not find a quick way to make print the same everywhere, so I figured that it's better to have a test for the simple case instead of none at all.
kennytm
commented
Aug 7, 2018
@bors r+ rollup |
bors
commented
Aug 7, 2018
📌 Commit 4eb52ff has been approved by |
…ginfo-tests, r=kennytm Re-enable a bunch of debuginfo tests. Re-enable some more debuginfo tests that actually seem to work.
…ginfo-tests, r=kennytm Re-enable a bunch of debuginfo tests. Re-enable some more debuginfo tests that actually seem to work.
…ginfo-tests, r=kennytm Re-enable a bunch of debuginfo tests. Re-enable some more debuginfo tests that actually seem to work.
…ginfo-tests, r=kennytm Re-enable a bunch of debuginfo tests. Re-enable some more debuginfo tests that actually seem to work.
This seems to have caused test failures in rollup #53206: see https://ci.appveyor.com/project/rust-lang/rust/build/1.0.8503/job/nw74idt1w1skyomw: Logs |
kennytm
commented
Aug 9, 2018
@bors rollup- |
bors
commented
Aug 10, 2018
⌛ Testing commit 4eb52ff with merge 97e096691801785e730dd1e1dcae26f4dc29c538... |
kennytm
commented
Aug 10, 2018
Details |
4eb52ff to
5dd8ed0Comparemichaelwoerister
commented
Aug 13, 2018
GDB has always been flaky on Windows. Let's not let that prevent us from testing on other platforms. |
kennytm
commented
Aug 13, 2018
@bors r+ rollup |
bors
commented
Aug 13, 2018
📌 Commit 5dd8ed0 has been approved by |
…ginfo-tests, r=kennytm Re-enable a bunch of debuginfo tests. Re-enable some more debuginfo tests that actually seem to work.
michaelwoerister
commented
Aug 14, 2018
Adding this to a rollup is risky business |
heh. @bors rollup- r- |
XAMPPRocky
commented
Aug 21, 2018
Triage: @kennytm What is left to be done with this PR? |
kennytm
commented
Aug 21, 2018
@Aaronepower The reenabled tests caused #53309 (comment) to fail and must be fixed before approving again. |
Dylan-DPC-zz
commented
Nov 26, 2018
ping from triage @kennytm@michaelwoerister what's the update on this? |
michaelwoerister
commented
Nov 27, 2018
I don't really have time to look into this |
Re-enable some more debuginfo tests that actually seem to work.