Skip to content

Stabilise raw_identifiers feature - #53236

Merged
bors merged 1 commit into
rust-lang:masterfrom
alexreg:stabilise-raw-idents
Aug 21, 2018
Merged

Stabilise raw_identifiers feature#53236
bors merged 1 commit into
rust-lang:masterfrom
alexreg:stabilise-raw-idents

Conversation

@alexreg

@alexregalexreg commented Aug 9, 2018•
edited
Loading

Copy link
Copy Markdown
Contributor

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 9, 2018
@cramertj

cramertj commented Aug 9, 2018

Copy link
Copy Markdown
Member

Before merging this we need docs PRs against the reference, the book, and Rust by Example.

@rust-highfive

This comment has been minimized.

Sign in to view
@alexreg

alexreg commented Aug 9, 2018

Copy link
Copy Markdown
ContributorAuthor

@cramertj Was planning on doing ones for the Reference and Rust By Example, but how do you think it would fit in the Book?

@Havvy

Havvy commented Aug 9, 2018

Copy link
Copy Markdown
Contributor

The current rules state that you just need to open issues, not full fledged PRs. Though of course, we prefer PRs over issues. But if you're not sure what to write in a PR, file an issue.

@alexreg

alexreg commented Aug 9, 2018

Copy link
Copy Markdown
ContributorAuthor

@Havvy Okay. I'll open a PR with what I think is most sane, and we can go from there, if people aren't happy with it...

@rust-highfive

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@alexreg

alexreg commented Aug 10, 2018

Copy link
Copy Markdown
ContributorAuthor

Okay, I think we're good to go now, at least as far as this PR itself is concerned. :-)

@kennytmkennytm added relnotes Marks issues that should be documented in the release notes of the next release. T-lang Relevant to the language team labels Aug 10, 2018
@cramertj

cramertj commented Aug 10, 2018

Copy link
Copy Markdown
Member

@bors r+

Assuming @alexreg will also open an issue against the book :)

@bors

bors commented Aug 10, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 176f8c2 has been approved by cramertj

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 10, 2018
@alexreg

alexreg commented Aug 10, 2018

Copy link
Copy Markdown
ContributorAuthor

@cramertj I already opened a PR against the book. From the Forge guide, I thought that was enough... what should the issue be about?

@kennytmkennytm mentioned this pull request Aug 10, 2018
Closed
@cramertj

cramertj commented Aug 10, 2018

Copy link
Copy Markdown
Member

@alexreg Oh, I see it linked at the top now. Thanks! I just missed it before.

kennytm added a commit to kennytm/rust that referenced this pull request Aug 11, 2018
@kennytm
Rollup merge ofrust-lang#53236- alexreg:stabilise-raw-idents, r=cra…
dcfbdea
…mertj
Stabilise raw_identifiers feature
* [Reference PR](rust-lang/reference#395)
* [Book PR](rust-lang/book#1480)
* [Rust by Example PR](rust-lang/rust-by-example#1095)
Closesrust-lang#48589.
r? @cramertj
CC @cuviper@Centril
kennytm added a commit to kennytm/rust that referenced this pull request Aug 13, 2018
@kennytm
Rollup merge ofrust-lang#53236- alexreg:stabilise-raw-idents, r=cra…
5931aa7
…mertj
Stabilise raw_identifiers feature
* [Reference PR](rust-lang/reference#395)
* [Book PR](rust-lang/book#1480)
* [Rust by Example PR](rust-lang/rust-by-example#1095)
Closesrust-lang#48589.
r? @cramertj
CC @cuviper@Centril
@kennytmkennytm mentioned this pull request Aug 13, 2018
Closed
@kennytmkennytm mentioned this pull request Aug 14, 2018
Merged
@kennytm

kennytm commented Aug 15, 2018

Copy link
Copy Markdown
Member

@bors r-

Merge conflicts in the UI tests.

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 15, 2018
@alexreg

alexreg commented Aug 15, 2018

Copy link
Copy Markdown
ContributorAuthor

@kennytm Done!

@kennytm

kennytm commented Aug 15, 2018

Copy link
Copy Markdown
Member

@alexreg you forgot to delete this file: https://github.com/rust-lang/rust/blob/a31c363881066e26b6eef43be3eee26073740795/src/test/ui/feature-gates/feature-gate-raw-identifiers.rs

@alexreg

alexreg commented Aug 15, 2018

Copy link
Copy Markdown
ContributorAuthor

Ah, rubbish... done now. :-P

@frewsxcvfrewsxcv added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 17, 2018
@kennytm

kennytm commented Aug 21, 2018

Copy link
Copy Markdown
Member

@bors r=cramertj p=1

@bors

bors commented Aug 21, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit e221fcc has been approved by cramertj

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 21, 2018
@bors

bors commented Aug 21, 2018

Copy link
Copy Markdown
Collaborator

⌛ Testing commit e221fcc with merge a9d4967...

bors added a commit that referenced this pull request Aug 21, 2018
@bors
Auto merge of#53236- alexreg:stabilise-raw-idents, r=cramertj
a9d4967
Stabilise raw_identifiers feature
* [Reference PR](rust-lang/reference#395)
* [Book PR](rust-lang/book#1480)
* [Rust by Example PR](rust-lang/rust-by-example#1095)
Closes#48589.
r? @cramertj
CC @cuviper@Centril
@bors

bors commented Aug 21, 2018

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-appveyor, status-travis
Approved by: cramertj
Pushing a9d4967 to master...

@bors
bors merged commit e221fcc into rust-lang:masterAug 21, 2018
@borsbors mentioned this pull request Aug 21, 2018
Merged
@haraldhharaldh mentioned this pull request Oct 26, 2018
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@cramertjcramertj

Labels

relnotesMarks issues that should be documented in the release notes of the next release.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-langRelevant to the language team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@alexreg@cramertj@rust-highfive@Havvy@bors@kennytm@frewsxcv