Uh oh!
There was an error while loading. Please reload this page.
Add links to std::char::REPLACEMENT_CHARACTER from docs. - #53273
Merged
Conversation
rust-highfive
commented
Aug 11, 2018
Contributor
r? @sfackler (rust_highfive has picked a reviewer for you, use r? to override) |
frewsxcv
commented
Aug 11, 2018
ContributorAuthor
frewsxcv
commented
Aug 11, 2018
ContributorAuthor
r? @rust-lang/docs |
Member
There was a problem hiding this comment.
Looks like we're a bit inconsistent between "U+FFFD REPLACEMENT CHARACTER" and "U+FFFD REPLACEMENT CHARACTER".
ContributorAuthor
There was a problem hiding this comment.
What's your opinion? I don't feel strongly
Member
There was a problem hiding this comment.
I don't really feel strongly either.
ContributorAuthor
There was a problem hiding this comment.
Made consistent in the latest force push
There are a few places where we mention the replacement character in the docs, and it could be helpful for users to utilize the constant which is available in the standard library, so let’s link to it!
fbstj
reviewed
Aug 11, 2018
| /// Decode a UTF-16 encoded slice `v` into a `String`, replacing | ||
| /// invalid data with the replacement character (U+FFFD). | ||
| /// invalid data with [the replacement character (`U+FFFD`)][U+FFFD]. |
Contributor
There was a problem hiding this comment.
was this missed in the push to U+FFFD REPLACEMENT CHARACTER everywhere (the above comment)?
ContributorAuthor
There was a problem hiding this comment.
Not missed, I intentionally didn't change this instance. Not sure I see the value in making all of these cases exactly identical
GuillaumeGomez
commented
Aug 12, 2018
Member
Thanks! @bors: r+ rollup |
bors
commented
Aug 12, 2018
Collaborator
📌 Commit ec18991 has been approved by |
bors
commented
Aug 12, 2018
Collaborator
🌲 The tree is currently closed for pull requests below priority 10, this pull request will be tested once the tree is reopened |
kennytm added a commit
to kennytm/rust
that referenced
this pull request
Aug 12, 2018
…eGomez Add links to std::char::REPLACEMENT_CHARACTER from docs. There are a few places where we mention the replacement character in the docs, and it could be helpful for users to utilize the constant which is available in the standard library, so let’s link to it!
GuillaumeGomez added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Aug 12, 2018
…eGomez Add links to std::char::REPLACEMENT_CHARACTER from docs. There are a few places where we mention the replacement character in the docs, and it could be helpful for users to utilize the constant which is available in the standard library, so let’s link to it!
bors added a commit
that referenced
this pull request
Aug 12, 2018
Rollup of 15 pull requests Successful merges: - #52955 (Update compiler test documentation) - #53019 (Don't collect() when size_hint is useless) - #53025 (Consider changing assert! to debug_assert! when it calls visit_with) - #53059 (Remove explicit returns where unnecessary) - #53165 ( Add aarch64-unknown-netbsd target) - #53210 (Deny future duplication of rustc-ap-syntax) - #53223 (A few cleanups for rustc_data_structures) - #53230 ([nll] enable feature(nll) on various crates for bootstrap: part 4) - #53231 (Add let keyword doc) - #53240 (Add individual documentation for <integer>`.swap_bytes`/.`reverse_bits`) - #53253 (Remove unwanted console log) - #53264 (Show that Command can be reused and remodified) - #53267 (Fix styles) - #53273 (Add links to std::char::REPLACEMENT_CHARACTER from docs.) - #53283 (wherein we suggest float for integer literals where a float was expected) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a few places where we mention the replacement character in the
docs, and it could be helpful for users to utilize the constant which is
available in the standard library, so let’s link to it!