Skip to content

When closure with no arguments was expected, suggest wrapping - #53296

Merged
bors merged 2 commits into
rust-lang:masterfrom
estebank:suggest-closure
Aug 21, 2018
Merged

When closure with no arguments was expected, suggest wrapping#53296
bors merged 2 commits into
rust-lang:masterfrom
estebank:suggest-closure

Conversation

@estebank

Copy link
Copy Markdown
Contributor

Fix#49694.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @KodrAus

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 12, 2018
@rust-highfive

This comment has been minimized.

@rust-highfive

This comment has been minimized.

@KodrAus

Copy link
Copy Markdown
Contributor

Thanks for your patience @estebank! This looks like a nice improvement to me.

@bors r+ rollup

@bors

bors commented Aug 19, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit cea73d6 has been approved by KodrAus

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 19, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Aug 20, 2018
When closure with no arguments was expected, suggest wrapping
Fixrust-lang#49694.
@kennytmkennytm mentioned this pull request Aug 20, 2018
bors added a commit that referenced this pull request Aug 21, 2018
Rollup of 17 pull requests
Successful merges:
- #53030 (Updated RELEASES.md for 1.29.0)
- #53104 (expand the documentation on the `Unpin` trait)
- #53213 (Stabilize IP associated constants)
- #53296 (When closure with no arguments was expected, suggest wrapping)
- #53329 (Replace usages of ptr::offset with ptr::{add,sub}.)
- #53363 (add individual docs to `core::num::NonZero*`)
- #53370 (Stabilize macro_vis_matcher)
- #53393 (Mark libserialize functions as inline)
- #53405 (restore the page title after escaping out of a search)
- #53452 (Change target triple used to check for lldb in build-manifest)
- #53462 (Document Box::into_raw returns non-null ptr)
- #53465 (Remove LinkMeta struct)
- #53492 (update lld submodule to include RISCV patch)
- #53496 (Fix typos found by codespell.)
- #53521 (syntax: Optimize some literal parsing)
- #53540 (Moved issue-53157.rs into src/test/ui/consts/const-eval/)
- #53551 (Avoid some Place clones.)
Failed merges:
r? @ghost
@bors
bors merged commit cea73d6 into rust-lang:masterAug 21, 2018
@estebank
estebank deleted the suggest-closure branch November 9, 2023 05:23
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@estebank@rust-highfive@KodrAus@bors