Uh oh!
There was an error while loading. Please reload this page.
rustc_resolve: crates only exist in the type namespace. - #53335
Merged
Conversation
rust-highfive
commented
Aug 14, 2018
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
eddyb
commented
Aug 14, 2018
ContributorAuthor
@bors p=10 This bug broke toolstate so I assume we want the fix before next nightly. |
petrochenkov
commented
Aug 14, 2018
Contributor
@bors r+ |
bors
commented
Aug 14, 2018
Collaborator
📌 Commit 262392c has been approved by |
bors
commented
Aug 14, 2018
Collaborator
bors
commented
Aug 14, 2018
Collaborator
☀️ Test successful - status-appveyor, status-travis |
rust-highfive
commented
Aug 14, 2018
Contributor
rust-highfive added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Aug 14, 2018
Tested on commit rust-lang/rust@d67ba90. Direct link to PR: <rust-lang/rust#53335> 🎉 clippy-driver on windows: build-fail → test-pass. 🎉 clippy-driver on linux: build-fail → test-pass. 🎉 rls on windows: build-fail → test-pass. 🎉 rls on linux: build-fail → test-pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#53333 by resolving
::crate_nameinTypeNSalone, which was overlooked in #52923 and didn't break tests, since havinguse crate_name;and acrate_namevalue in the same scope is rare.