Uh oh!
There was an error while loading. Please reload this page.
Make some ported cfail tests robust w.r.t. NLL - #53369
Merged
bors merged 1 commit intoAug 18, 2018
Merged
Conversation
… from rust-lang#53196. See also the bulletpoint list on rust-lang#53351.
rust-highfive
commented
Aug 14, 2018
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
49 tasks
pnkfelix
commented
Aug 14, 2018
ContributorAuthor
r? @davidtwco |
alexcrichton
commented
Aug 15, 2018
Member
@bors: r=davidtwco delegate=davidtwco |
bors
commented
Aug 15, 2018
Collaborator
✌️ @davidtwco can now approve this pull request |
bors
commented
Aug 15, 2018
Collaborator
📌 Commit c7041a6 has been approved by |
bors
commented
Aug 17, 2018
Collaborator
⌛ Testing commit c7041a6 with merge 67cd9f6d77efce03f15569d84024b77bd38ed6a0... |
bors
commented
Aug 17, 2018
Collaborator
💔 Test failed - status-appveyor |
kennytm
commented
Aug 17, 2018
Member
@bors retry GitHub archive issue.
|
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Aug 17, 2018
…rted-compile-fail-tests-more-robust-wrt-nll, r=nikomatsakis make more ported compile fail tests more robust w.r.t. NLL This is similar to PR rust-lang#53369, except it covers a disjoint (and much smaller) set of tests that I needed to look at more carefully before being 100% certain they were the same kind of issue.
bors
commented
Aug 17, 2018
Collaborator
bors
commented
Aug 18, 2018
Collaborator
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the most glaring instances of weak tests w.r.t. NLL that came from #53196.
See also the bulletpoint list on #53351.