Skip to content

Don't truncate compiler output in compiletest - #53422

Closed
ashtneoi wants to merge 1 commit into
rust-lang:masterfrom
ashtneoi:dont-truncate-compiler-output
Closed

Don't truncate compiler output in compiletest#53422
ashtneoi wants to merge 1 commit into
rust-lang:masterfrom
ashtneoi:dont-truncate-compiler-output

Conversation

@ashtneoi

Copy link
Copy Markdown
Contributor

Fixes issue #53332. Should I write a test for this, or is it sufficiently regression-proof?

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 16, 2018
@alexcrichton

Copy link
Copy Markdown
Member

Thanks for the PR! I want to be sure to cc @kennytm in relation to #45783 where this was originally added. It seems that if we do this we may go back to OOMing sometimes?

A better default may be to perhaps only whitelist tests to be executed with read2_abbreviated?

@kennytm

kennytm commented Aug 20, 2018

Copy link
Copy Markdown
Member

read2_abbreviated is definitely needed as long as the test run-pass\rustc-rust-log.rs still runs on a 32-bit platform.

Perhaps enable read2_abbreviated just for run-pass tests?

P.S. Why would the JSON output exceed 416 KB? Could we redact the error explanation?

@ashtneoi

Copy link
Copy Markdown
ContributorAuthor

read2_abbreviated is definitely needed as long as the test run-pass\rustc-rust-log.rs still runs on a 32-bit platform.

Aha, I knew I was missing something.

P.S. Why would the JSON output exceed 416 KB? Could we redact the error explanation?

That sounds like a much better idea. Maybe we could add a new --error-format option that omits explanations? Call it something like json-brief or json-no-explanations?

@alexcrichton

Copy link
Copy Markdown
Member

It's probably best to avoid changing the compiler here, ideally we'd just use the abbreviated reading for that one test I believe.

@emilyalbini

Copy link
Copy Markdown
Member

Ping from triage! What's the status of this PR?

@ashtneoi

Copy link
Copy Markdown
ContributorAuthor

I think we're waiting on me now, but I didn't have much time last week to work on it (sorry).

@ashtneoi

Copy link
Copy Markdown
ContributorAuthor

I'm not sure when I'll get time to finish this so I'm going to close it for now. If someone else wants to work on it, they're welcome to.

@ashtneoiashtneoi closed this Sep 3, 2018
@ashtneoi
ashtneoi deleted the dont-truncate-compiler-output branch August 8, 2020 20:12
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@ashtneoi@rust-highfive@alexcrichton@kennytm@emilyalbini