[Do not merge] Optional turbofish breakage test by varkor · Pull Request #53578 · rust-lang/rust

varkor · 2018-08-21T22:26:40Z

As an academic exercise, to satisfy ourselves that we completely understand the lay of the land, we'd like to see how often ambiguous cases arise in real-world Rust code. (Following on from #53511.)

@rust-lang/infra: is it possible to get a check-only crater run for this change?

r? @ghost

estebank · 2018-08-21T23:30:13Z

@bors try

bors · 2018-08-21T23:30:24Z

⌛ Trying commit 01cb485 with merge a5b9f2c...

@ghost

[Do not merge] Optional turbofish breakage test As an academic exercise, to satisfy ourselves that we completely understand the lay of the land, we'd like to see how often ambiguous cases arise in real-world Rust code. (Following on from #53511.) @rust-lang/infra: is it possible to get a check-only crater run for this change? r? @ghost

bors · 2018-08-22T01:14:59Z

☀️ Test successful - status-travis
State: approved= try=True

estebank · 2018-08-22T17:03:42Z

@rust-lang/infra could we get a crater run?

emilyalbini · 2018-08-27T15:21:51Z

@craterbot run start=master#d0d81b7fc1421859ba0218e8a437af29ae3b0967 end=try#a5b9f2cc0cdaca8edf23a89c649279de2c91cd3b mode=check-only

craterbot · 2018-08-27T15:21:52Z

👌 Experiment pr-53578 created and queued.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2018-08-31T01:06:39Z

🚧 Experiment pr-53578 is now running on agent crater-1.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2018-09-01T11:53:26Z

🎉 Experiment pr-53578 is completed!
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

kennytm · 2018-09-01T11:57:40Z

🤔 526 regressed. The number is higher than I expected.

Almost all of the regressions are caused by the same line in nix:

Sep 01 11:27:00.320 INFO kablam! error: expected one of `!`, `(`, `)`, `,`, `::`, or `<`, found `.`
Sep 01 11:27:00.321 INFO kablam! --> /cargo-home/registry/src/github.com-1ecc6299db9ec823/nix-0.5.1/src/sys/socket/mod.rs:616:36
Sep 01 11:27:00.321 INFO kablam! |
Sep 01 11:27:00.321 INFO kablam! 616 | if len < mem::size_of_val(&addr.ss_family) {
Sep 01 11:27:00.321 INFO kablam! | ^ expected one of `!`, `(`, `)`, `,`, `::`, or `<` here

Looks the parser is trying to parse something similar to Box<Fn(&A·. and then got an unexpected dot.

Other breakages are similar. No breakage is caused by actual ambiguity.

microbench options.memory<Bytes(iterations·*

Sep 01 08:21:01.607 INFO kablam! error: expected one of `!`, `(`, `)`, `+`, `,`, `::`, or `<`, found `*`
Sep 01 08:21:01.607 INFO kablam! --> /cargo-home/registry/src/github.com-1ecc6299db9ec823/microbench-0.3.3/src/lib.rs:300:46
Sep 01 08:21:01.607 INFO kablam! |
Sep 01 08:21:01.607 INFO kablam! 300 | if options.memory < Bytes(iterations * cmp::max(1, mem::size_of::<T>() as u64)) {
Sep 01 08:21:01.607 INFO kablam! | ^ expected one of 7 possible tokens here

comrak i<min(alignments·.

Sep 01 08:18:33.012 INFO kablam! error: expected one of `!`, `(`, `)`, `+`, `,`, `::`, or `<`, found `.`
Sep 01 08:18:33.012 INFO kablam! --> /cargo-home/registry/src/github.com-1ecc6299db9ec823/comrak-0.2.14/src/parser/table.rs:99:29
Sep 01 08:18:33.012 INFO kablam! |
Sep 01 08:18:33.012 INFO kablam! 99 | while i < min(alignments.len(), this_row.len()) {
Sep 01 08:18:33.012 INFO kablam! | ^ expected one of 7 possible tokens here

packed_simd self<<$id::splat(other·as

Sep 01 04:32:12.308 INFO kablam! error: expected one of `!`, `(`, `)`, `+`, `,`, `::`, or `<`, found `as`
Sep 01 04:32:12.308 INFO kablam! --> /cargo-home/registry/src/github.com-1ecc6299db9ec823/packed_simd-0.1.0/src/api/ops/scalar_shifts.rs:9:42
Sep 01 04:32:12.308 INFO kablam! |
Sep 01 04:32:12.308 INFO kablam! 9 | self << $id::splat(other as $elem_ty)
Sep 01 04:32:12.308 INFO kablam! | ^^ expected one of 7 possible tokens here
Sep 01 04:32:12.309 INFO kablam! |

medallion now<Timespec::new(exp_sec·as

Sep 01 03:42:00.864 INFO kablam! error: expected one of `!`, `(`, `)`, `+`, `,`, `::`, or `<`, found `as`
Sep 01 03:42:00.864 INFO kablam! --> /cargo-home/registry/src/github.com-1ecc6299db9ec823/medallion-2.2.3/src/payload.rs:94:58
Sep 01 03:42:00.864 INFO kablam! |
Sep 01 03:42:00.864 INFO kablam! 94 | Some(exp_sec) => now < Timespec::new(exp_sec as i64, 0),
Sep 01 03:42:00.864 INFO kablam! | ^^ expected one of 7 possible tokens here

gazetta-render-ext tmpl<<::Markdown::new(self·.

Sep 01 03:41:31.071 INFO kablam! error: expected one of `!`, `(`, `)`, `+`, `,`, `::`, or `<`, found `.`
Sep 01 03:41:31.071 INFO kablam! --> /cargo-home/registry/src/github.com-1ecc6299db9ec823/gazetta-render-ext-0.2.1/src/content.rs:53:70
Sep 01 03:41:31.071 INFO kablam! |
Sep 01 03:41:31.071 INFO kablam! 53 | "mkd" | "md" | "markdown" => tmpl << ::Markdown::new(self.0.content.data, self.0.href),
Sep 01 03:41:31.071 INFO kablam! | ^ expected one of 7 possible tokens here
Sep 01 03:41:31.071 INFO kablam! Sep 01 03:41:31.071 INFO kablam! error: expected one of `!`, `(`, `)`, `+`, `,`, `::`, or `<`, found `.`
Sep 01 03:41:31.071 INFO kablam! --> /cargo-home/registry/src/github.com-1ecc6299db9ec823/gazetta-render-ext-0.2.1/src/content.rs:54:39
Sep 01 03:41:31.071 INFO kablam! |
Sep 01 03:41:31.071 INFO kablam! 54 | "html" => tmpl << Raw(self.0.content.data),
Sep 01 03:41:31.071 INFO kablam! | ^ expected one of 7 possible tokens here

glslwatch self.mtime<File::open(&self·.

Sep 01 02:58:21.346 INFO kablam! error: expected one of `!`, `(`, `)`, `,`, `::`, or `<`, found `.`
Sep 01 02:58:21.346 INFO kablam! --> src/preprocess.rs:72:41
Sep 01 02:58:21.346 INFO kablam! |
Sep 01 02:58:21.346 INFO kablam! 72 | Ok(self.mtime < File::open(&self.path)?.metadata()?.modified()?)
Sep 01 02:58:21.346 INFO kablam! | ^ expected one of `!`, `(`, `)`, `,`, `::`, or `<` here

hash-rings j<i64::from(self·.

Sep 01 01:18:12.544 INFO kablam! error: expected one of `!`, `(`, `)`, `+`, `,`, `::`, or `<`, found `.`
Sep 01 01:18:12.545 INFO kablam! --> src/jump.rs:61:33
Sep 01 01:18:12.545 INFO kablam! |
Sep 01 01:18:12.545 INFO kablam! 61 | while j < i64::from(self.nodes) {
Sep 01 01:18:12.545 INFO kablam! | ^ expected one of 7 possible tokens here

lava_torrent total_piece_length<util::i64_to_usize(self·.

Aug 31 23:12:20.942 INFO kablam! error: expected one of `!`, `(`, `)`, `+`, `,`, `::`, or `<`, found `.`
Aug 31 23:12:20.942 INFO kablam! --> src/torrent/v1/read.rs:131:60
Aug 31 23:12:20.942 INFO kablam! |
Aug 31 23:12:20.942 INFO kablam! 131 | if total_piece_length < util::i64_to_usize(self.length)? {
Aug 31 23:12:20.942 INFO kablam! | ^ expected one of 7 possible tokens here

recurdates added.minutes<cmp::max(self·.

Aug 31 17:15:44.146 INFO kablam! error: expected one of `!`, `(`, `)`, `+`, `,`, `::`, or `<`, found `.`
Aug 31 17:15:44.146 INFO kablam! --> src/repeat_every.rs:78:41
Aug 31 17:15:44.146 INFO kablam! |
Aug 31 17:15:44.146 INFO kablam! 78 | if added.minutes < cmp::max(self.minutes, rhs.minutes) || added.days < cmp::max(self.days, rhs.days) || added.months < cmp::max(self.months, rhs.months) {
Aug 31 17:15:44.146 INFO kablam! | ^ expected one of 7 possible tokens here

rome self.pos<F::index(self·.

Aug 31 16:23:04.191 INFO kablam! error: expected one of `!`, `(`, `)`, `+`, `,`, `::`, or `<`, found `.`
Aug 31 16:23:04.191 INFO kablam! --> src/graphs/tel/iter.rs:25:36
Aug 31 16:23:04.191 INFO kablam! |
Aug 31 16:23:04.191 INFO kablam! 25 | if self.pos < F::index(self.graph).len() {
Aug 31 16:23:04.192 INFO kablam! | ^ expected one of 7 possible tokens here

smoltcp len<field::TPA(self·.

Aug 31 13:20:54.029 INFO kablam! error: expected one of `!`, `(`, `)`, `+`, `,`, `::`, or `<`, found `.`
Aug 31 13:20:54.029 INFO kablam! --> src/wire/arp.rs:93:40
Aug 31 13:20:54.029 INFO kablam! |
Aug 31 13:20:54.029 INFO kablam! 93 | } else if len < field::TPA(self.hardware_len(), self.protocol_len()).end {
Aug 31 13:20:54.029 INFO kablam! | ^ expected one of 7 possible tokens here

tsk_lib precedence<Precedence::from(&self·.

Aug 31 10:29:47.659 INFO kablam! error: expected one of `!`, `(`, `)`, `,`, `::`, or `<`, found `.`
Aug 31 10:29:47.659 INFO kablam! --> /cargo-home/registry/src/github.com-1ecc6299db9ec823/tsk_lib-0.0.0/src/query/parser.rs:217:52
Aug 31 10:29:47.659 INFO kablam! |
Aug 31 10:29:47.659 INFO kablam! 217 | && (precedence < Precedence::from(&self.peek_token) || precedence == Precedence::STRING)
Aug 31 10:29:47.659 INFO kablam! | ^ expected one of `!`, `(`, `)`, `,`, `::`, or `<` here

uncover self.cnt<__covers_get_coverage(self·.

Aug 31 10:07:50.416 INFO kablam! error: expected one of `!`, `(`, `)`, `+`, `,`, `::`, or `<`, found `.`
Aug 31 10:07:50.416 INFO kablam! --> src/lib.rs:174:51
Aug 31 10:07:50.416 INFO kablam! |
Aug 31 10:07:50.416 INFO kablam! 174 | if !(self.cnt < __covers_get_coverage(self.pos)) {
Aug 31 10:07:50.416 INFO kablam! | ^ expected one of 7 possible tokens here

unic-ucd-age None<Some(Age(UnicodeVersion·{

Aug 31 10:05:02.130 INFO kablam! error: expected one of `!`, `(`, `)`, `+`, `,`, `::`, or `<`, found `{`
Aug 31 10:05:02.130 INFO kablam! --> src/age.rs:640:44
Aug 31 10:05:02.130 INFO kablam! |
Aug 31 10:05:02.130 INFO kablam! 640 | None < Some(Age(UnicodeVersion {
Aug 31 10:05:02.130 INFO kablam! | ^ expected one of 7 possible tokens here
Aug 31 10:05:02.130 INFO kablam! Aug 31 10:05:02.130 INFO kablam! error: expected one of `!`, `)`, `+`, `,`, `->`, or `::`, found `major`
Aug 31 10:05:02.130 INFO kablam! --> src/age.rs:641:17
Aug 31 10:05:02.130 INFO kablam! |
Aug 31 10:05:02.130 INFO kablam! 640 | None < Some(Age(UnicodeVersion {
Aug 31 10:05:02.130 INFO kablam! | - expected one of `!`, `)`, `+`, `,`, `->`, or `::` here
Aug 31 10:05:02.130 INFO kablam! 641 | major: 1,
Aug 31 10:05:02.130 INFO kablam! | ^^^^^ unexpected token
Aug 31 10:05:02.130 INFO kablam! Aug 31 10:05:02.130 INFO kablam! error: expected one of `!`, `(`, `)`, `+`, `,`, `::`, or `<`, found `:`
Aug 31 10:05:02.130 INFO kablam! --> src/age.rs:641:22
Aug 31 10:05:02.130 INFO kablam! |
Aug 31 10:05:02.130 INFO kablam! 641 | major: 1,
Aug 31 10:05:02.130 INFO kablam! | ^ expected one of 7 possible tokens here

evo_model self.center_sep_sqr<sqr(self·.

Aug 31 05:18:50.467 INFO kablam! error: expected one of `!`, `(`, `)`, `+`, `,`, `::`, or `<`, found `.`
Aug 31 05:18:50.467 INFO kablam! --> evo_model/src/physics/overlap.rs:136:39
Aug 31 05:18:50.467 INFO kablam! |
Aug 31 05:18:50.467 INFO kablam! 136 | self.center_sep_sqr < sqr(self.just_touching_center_sep) && self.center_sep_sqr != 0.0
Aug 31 05:18:50.467 INFO kablam! | ^ expected one of 7 possible tokens here

Is the regression in opcua-server spurious?

varkor · 2018-09-11T10:56:21Z

@kennytm: thanks for taking a look at the regressions! It's taken a while for me to look at this. It looks like it might be possible to make the error reporting in this case lazier and backtrack instead.

Is the regression in opcua-server spurious?

Possibly; I can't see why this change would affect it.

varkor · 2018-09-13T17:14:47Z

@bors try

bors · 2018-09-13T17:15:00Z

⌛ Trying commit ca2849a with merge 58114b1...

@ghost

[Do not merge] Optional turbofish breakage test As an academic exercise, to satisfy ourselves that we completely understand the lay of the land, we'd like to see how often ambiguous cases arise in real-world Rust code. (Following on from #53511.) @rust-lang/infra: is it possible to get a check-only crater run for this change? r? @ghost

varkor · 2018-09-13T21:28:40Z

@bors try

bors · 2018-09-13T21:28:51Z

⌛ Trying commit 307ea60 with merge 102de0ab47505b4e9d03054e600bcac5ad4939b7...

estebank · 2018-09-13T22:40:30Z

@bors try

rust-highfive · 2018-09-13T23:11:17Z

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

Check compiletest suite=ui mode=ui (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[00:45:32] [00:45:32] running 6774 tests
[00:45:34] ....................................................................................................
[00:45:37] ..............................................................F.....................................
[00:45:43] ....................................................................................................
[00:45:45] ....................................................................................................
[00:45:49] .................i..................................................................................
[00:45:54] ....................................................................................................
---
[00:51:58] failures:
[00:51:58] [00:51:58] ---- [ui] ui/bastion-of-the-turbofish.rs stdout ----
[00:51:58] [00:51:58] error: test compilation failed although it shouldn't!
[00:51:58] status: exit code: 1
[00:51:58] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/bastion-of-the-turbofish.rs" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/bastion-of-the-turbofish/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/bastion-of-the-turbofish/auxiliary" "-A" "unused"
[00:51:58] ------------------------------------------
[00:51:58] [00:51:58] ------------------------------------------
[00:51:58] stderr:
[00:51:58] stderr:
[00:51:58] ------------------------------------------
[00:51:58] {"message":"expected type, found local variable `woe`","code":{"code":"E0573","explanation":null},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/bastion-of-the-turbofish.rs","byte_start":2179,"byte_end":2182,"line_start":45,"line_end":45,"column_start":31,"column_end":34,"is_primary":true,"text":[{"text":" let _: (bool, bool) = (oh<woe, is>(me));","highlight_start":31,"highlight_end":34}],"label":"not a type","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error[E0573]: expected type, found local variable `woe`\n --> /checkout/src/test/ui/bastion-of-the-turbofish.rs:45:31\n |\nLL | let _: (bool, bool) = (oh<woe, is>(me));\n | ^^^ not a type\n\n"}
[00:51:58] {"message":"expected type, found local variable `is`","code":{"code":"E0573","explanation":null},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/bastion-of-the-turbofish.rs","byte_start":2184,"byte_end":2186,"line_start":45,"line_end":45,"column_start":36,"column_end":38,"is_primary":true,"text":[{"text":" let _: (bool, bool) = (oh<woe, is>(me));","highlight_start":36,"highlight_end":38}],"label":"did you mean `i8`?","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error[E0573]: expected type, found local variable `is`\n --> /checkout/src/test/ui/bastion-oethod.\n\nErroneous code examples:\n\n```compile_fail,E0618\nenum X {\n Entry,\n}\n\nX::Entry(); // error: expected function, found `X::Entry`\n\n// Or even simpler:\nlet x = 0i32;\nx(); // error: expected function, found `i32`\n```\n\nOnly functions and methods can be called using `()`. Example:\n\n```\n// We declare a function:\nfn i_am_a_function() {}\n\n// And we call it:\ni_am_a_function();\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/bastion-of-the-turbofish.rs","byte_start":2175,"byte_end":2192,"line_start":45,"line_end":45,"column_start":27,"column_end":44,"is_primary":true,"text":[{"text":" let _: (bool, bool) = (oh<woe, is>(me));","highlight_start":27,"highlight_end":44}],"label":"not a function","suggested_replacement":null,"suggestion_applicability":null,"expansion":null},{"file_name":"/checkout/src/test/ui/bastion-of-the-turbofish.rs","byte_start":2083,"byte_end":2085,"line_start":44,"line_end":44,"column_start":10,"column_end":12,"is_primary":false,"text":[{"text":" let (oh, woe, is, me) = (\"the\", \"Turbofish\", \"remains\", \"undefeated\");","highlight_start":10,"highlight_end":12}],"label":"`&str` defined here","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error[E0618]: expected function, found `&str`\n --> /checkout/src/test/ui/bastion-of-the-turbofish.rs:45:27\n |\nLL | let (oh, woe, is, me) = (\"the\", \"Turbofish\", \"remains\", \"undefeated\");\n | -- `&str` defined here\nLL | let _: (bool, bool) = (oh<woe, is>(me));\n | ^^^^^^^^^^^^^^^^^ not a function\n\n"}
[00:51:58] {"message":"aborting due to 4 previous errors","code":null,"level":"error","spans":[],"children":[],"rendered":"error: aborting due to 4 previous errors\n\n"}
[00:51:58] {"message":"Some errors occurred: E0109, E0573, E0618.","code":null,"level":"","spans":[],"children":[],"rendered":"Some errors occurred: E0109, E0573, E0618.\n"}
[00:51:58] {"message":"For more information about an error, try `rustc --explain E0109`.","code":null,"level":"","spans":[],"children":[],"rendered":"For more information about an error, try `rustc --explain E0109`.\n"}
[00:51:58] ------------------------------------------
[00:51:58] [00:51:58] thread '[ui] ui/bastion-of-the-turbofish.rs' panicked at 'explicit panic', tools/compiletest/src/runtest.rs:3205:9
[00:51:58] note: Run with `RUST_BACKTRACE=1` for a backtrace.
---
[00:51:58] [00:51:58] thread 'main' panicked at 'Some tests failed', tools/compiletest/src/main.rs:496:22
[00:51:58] [00:51:58] [00:51:58] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-5.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options " "--target-rustcflags" "-Crpath -O -Zunstable-options -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "5.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[00:51:58] [00:51:58] [00:51:58] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[00:51:58] Build completed unsuccessfully in 0:07:27
[00:51:58] Build completed unsuccessfully in 0:07:27
[00:51:58] make: *** [check] Error 1
[00:51:58] Makefile:58: recipe for target 'check' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:26711d4b
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
151412 ./src/tools/clang
149128 ./src/llvm-emscripten/test
149020 ./obj/build/bootstrap/debug/incremental
134588 ./obj/build/bootstrap/debug/incremental/bootstrap-j9sjo2qxwegl
134584 ./obj/build/bootstrap/debug/incremental/bootstrap-j9sjo2qxwegl/s-f4rzp9c2cl-afh1ys-1jtu7ee7y4raz
130988 ./obj/build/x86_64-unknown-linux-gnu/stage1-rustc/x86_64-unknown-linux-gnu/release
129860 ./obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu
129856 ./obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release
128068 ./obj/build/x86_64-unknown-linux-gnu/stage1-rustc/x86_64-unknown-linux-gnu/release/deps
---
travis_time:end:074f927d:start=1536880274071224279,finish=1536880274075993660,duration=4769381
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:06df3d04
$ ln -s . checkout && fo

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

varkor · 2018-09-13T23:13:22Z

Hopefully that's the only thing that fails the test 😄

varkor · 2018-09-13T23:14:04Z

(Huh, the previous try didn't work.)

@bors try

bors · 2018-09-13T23:14:14Z

⌛ Trying commit c7b5c52 with merge 87b8e7411c4f1267d0cac0d63fa9c21c943e2ea0...

bors · 2018-09-14T01:35:26Z

☀️ Test successful - status-travis
State: approved= try=True

varkor · 2018-09-14T01:56:44Z

@craterbot run start=master#90d36fb5905bbe5004f5b465ea14b53d10dae260 end=try#87b8e7411c4f1267d0cac0d63fa9c21c943e2ea0 mode=check-only

craterbot · 2018-09-14T01:56:44Z

🚨 Error: an experiment named pr-53578 already exists!

🆘 If you have any trouble with Crater please ping @rust-lang/infra!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

varkor · 2018-09-14T02:00:10Z

@craterbot run start=master#90d36fb5905bbe5004f5b465ea14b53d10dae260 end=try#87b8e7411c4f1267d0cac0d63fa9c21c943e2ea0 mode=check-only name=pr-53578-1

craterbot · 2018-09-14T02:00:11Z

👌 Experiment pr-53578-1 created and queued.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2018-09-14T02:00:13Z

🚧 Experiment pr-53578-1 is now running on agent aws-1.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2018-09-14T20:28:18Z

🎉 Experiment pr-53578-1 is completed!
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

varkor · 2018-09-14T21:18:39Z

The one regression is spurious. It seems switching the syntax to ::-less generic expressions causes little to no breakages in the ecosystem.

estebank · 2018-09-17T21:22:06Z

Agreeing with @petrochenkov and @SimonSapin (here and in the RFCS) that making this change for 2015 edition could be unwise, but I would love to have this PR merged with customized suggestion when this would work to actually suggest using the turbofish. The same reasoning behind changing the semantics applies to making the diagnostic error more accurate. What do you think, @varkor? Would you be ok with cleaning up this PR as a diagnostic only change while the RFCS process and conversation marches on?

petrochenkov · 2018-09-17T21:40:12Z

Agreeing with @petrochenkov and @SimonSapin (here and in the RFCS) that making this change for 2015 edition could be unwise

To clarify, I think making this change for any edition is unwise, but the theoretical breakage is probably the last of the reasons for that.

XAMPPRocky · 2018-09-26T15:20:37Z

Triage; @varkor Hello, what is the current status of this PR?

varkor · 2018-09-26T23:56:04Z

For now, let's just close this; I'll come back to it after the 2018 Edition is out.

craterbot added the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Aug 27, 2018

craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Sep 1, 2018

varkor force-pushed the disappearing-turbofish-crater-run branch from 01cb485 to ca2849aCompare September 13, 2018 17:14

This comment has been minimized.
Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 13, 2018

varkor added 3 commits September 13, 2018 22:23

Allow generic parameters to be specified in expressions without ::
21da4b0

Save parser state lazily
29ab824

Fix issue parsing .
307ea60

varkor force-pushed the disappearing-turbofish-crater-run branch from ca2849a to 307ea60Compare September 13, 2018 21:28

Remove do catch
c7b5c52

estebank mentioned this pull request Sep 13, 2018
Undisambiguated generic arguments in expressions rust-lang/rfcs#2527
Closed

craterbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 14, 2018

craterbot added the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Sep 14, 2018

varkor mentioned this pull request Sep 14, 2018
craterbot should generate unique names for each run rust-lang/crater#306
Closed

craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Sep 14, 2018

petrochenkov mentioned this pull request Sep 15, 2018
proc macro API: Making enum Delimiter non-exhaustive #54248
Closed

varkor closed this Sep 26, 2018

varkor mentioned this pull request Oct 1, 2018
Make the turbofish syntax redundant rust-lang/rfcs#2544
Closed

estebank mentioned this pull request Dec 20, 2018
AST/HIR: Introduce ExprKind::Err for better error recovery in the front-end #56999
Merged

estebank mentioned this pull request Jan 2, 2019
use structured suggestion for method calls #57291
Merged

Uh oh!

Uh oh!

Conversation

varkor commented Aug 21, 2018

Uh oh!

estebank commented Aug 21, 2018

Uh oh!

bors commented Aug 21, 2018

Uh oh!

bors commented Aug 22, 2018

Uh oh!

estebank commented Aug 22, 2018

Uh oh!

emilyalbini commented Aug 27, 2018

Uh oh!

craterbot commented Aug 27, 2018

Uh oh!

craterbot commented Aug 31, 2018

Uh oh!

craterbot commented Sep 1, 2018

Uh oh!

kennytm commented Sep 1, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

varkor commented Sep 11, 2018

Uh oh!

varkor commented Sep 13, 2018

Uh oh!

bors commented Sep 13, 2018

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

varkor commented Sep 13, 2018

Uh oh!

bors commented Sep 13, 2018

Uh oh!

estebank commented Sep 13, 2018

Uh oh!

rust-highfive commented Sep 13, 2018

Uh oh!

varkor commented Sep 13, 2018

Uh oh!

varkor commented Sep 13, 2018

Uh oh!

bors commented Sep 13, 2018

Uh oh!

bors commented Sep 14, 2018

Uh oh!

varkor commented Sep 14, 2018

Uh oh!

craterbot commented Sep 14, 2018

Uh oh!

varkor commented Sep 14, 2018

Uh oh!

craterbot commented Sep 14, 2018

Uh oh!

craterbot commented Sep 14, 2018

Uh oh!

craterbot commented Sep 14, 2018

Uh oh!

varkor commented Sep 14, 2018

Uh oh!

estebank commented Sep 17, 2018

Uh oh!

petrochenkov commented Sep 17, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

XAMPPRocky commented Sep 26, 2018

Uh oh!

varkor commented Sep 26, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

kennytm commented Sep 1, 2018•
edited
Loading

petrochenkov commented Sep 17, 2018•
edited
Loading