Automatically expand a section even after page load by kzys · Pull Request #53626 · rust-lang/rust

kzys · 2018-08-23T07:55:00Z

rust-highfive · 2018-08-23T07:55:10Z

Some changes occurred in HTML/CSS.

rust-highfive · 2018-08-23T07:55:11Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @QuietMisdreavus (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

GuillaumeGomez · 2018-08-23T08:20:30Z

Already fixed in #53094. You can see it in action in nightly docs: https://doc.rust-lang.org/nightly/std/vec/struct.Vec.html#method.extend

Thanks anyway! 😉

GuillaumeGomez · 2018-08-23T08:22:25Z

Ah hold on, nevermind! I didn't see you extended it, my bad. Reopening and reviewing.

GuillaumeGomez · 2018-08-23T08:24:24Z

+ if (elem && isHidden(elem.offsetParent)) {
+ var h3 = elem.parentNode.previousSibling;
+
+ if (h3.tagName !== 'H3') {


Please check if h3 exists before accessing tagName.

Thanks. Done at 1f441a0

GuillaumeGomez · 2018-08-23T11:33:25Z

+ }
+
+ var elem = document.getElementById(hash);
+ if (elem && isHidden(elem.offsetParent)) {


offsetParent can be null, please check it before calling isHidden.

GuillaumeGomez · 2018-08-23T11:34:10Z

Two nits to fix and it's good to go.

ehuss · 2018-08-23T16:33:41Z

Would it be possible to fix the issues listed in #48726? It looks like this is close, but doesn't seem to work on those examples.

GuillaumeGomez · 2018-08-23T18:18:30Z

@ehuss This PR should fix it.

GuillaumeGomez · 2018-08-23T18:19:00Z

@kzys Thanks a lot for your work!

@bors: r+ rollup

bors · 2018-08-23T18:19:01Z

📌 Commit 1f441a0 has been approved by GuillaumeGomez

ehuss · 2018-08-23T18:58:23Z

I tried this patch, it doesn't seem to work.

In the example of BufWriter, the flush link doesn't work because it is nested within a trait implementation, so it actually needs to check recursively up the parents (document.getElementById("method.flush").offsetParent.offsetParent.offsetParent).
In the example of hiding all methods, and then trying to click on the sidebar, the immediate offsetParent is null.
When using cross-page links, AFAIK these won't trigger. The same logic needs to be applied somewhere like autoCollapse to prevent them from being collapsed in the first place (or immediately reopen them).

GuillaumeGomez · 2018-08-24T08:01:02Z

@ehuss: Thanks for your check!
@kzys: Can you fix these issues too please?

@bors: r-

Doing the expansion on onhashchange seems too late. Fixesrust-lang#48726

kzys · 2018-08-25T10:40:45Z

@ehuss The last change (2c61f3c) should address the issues you've mentioned.

For cross-page links, I couldn't reproduce the issue even before my fix. How did you check the behavior?

ehuss · 2018-08-25T16:52:10Z

I tried a variety of things, and everything seems to work now! TYVM!!

GuillaumeGomez · 2018-08-25T20:09:22Z

Thanks a lot again, let's get this in!

@bors: r+ rollup

bors · 2018-08-25T20:09:23Z

📌 Commit 2c61f3c has been approved by GuillaumeGomez

Automatically expand a section even after page load Fixesrust-lang#52774

@ghost

Rollup of 5 pull requests Successful merges: - #53043 (Improve unstable message display) - #53428 (libtest terse format: show how far in we are) - #53626 (Automatically expand a section even after page load) - #53651 (Add struct keyword doc) - #53706 (rustdoc: Fix gap on section anchor symbol when hovering.) Failed merges: - #53472 (Use FxHash{Map,Set} instead of the default Hash{Map,Set} everywhere in rustc.) r? @ghost

@ghost

Rollup of 5 pull requests Successful merges: - #53043 (Improve unstable message display) - #53428 (libtest terse format: show how far in we are) - #53626 (Automatically expand a section even after page load) - #53651 (Add struct keyword doc) - #53706 (rustdoc: Fix gap on section anchor symbol when hovering.) Failed merges: - #53472 (Use FxHash{Map,Set} instead of the default Hash{Map,Set} everywhere in rustc.) r? @ghost

Automatically expand a section even after page load
917cdd2
Fixesrust-lang#52774

rust-highfive assigned QuietMisdreavus Aug 23, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 23, 2018

GuillaumeGomez closed this Aug 23, 2018

GuillaumeGomez reopened this Aug 23, 2018

GuillaumeGomez reviewed Aug 23, 2018
View reviewed changes

Check null-able variables before using them
1f441a0

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 23, 2018

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 24, 2018

Expand a collapsed element on onclick
2c61f3c
Doing the expansion on onhashchange seems too late. Fixesrust-lang#48726

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 25, 2018

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 26, 2018
Rollup merge ofrust-lang#53626- kzys:hashchange, r=GuillaumeGomez
9c20f06
Automatically expand a section even after page load Fixesrust-lang#52774

GuillaumeGomez mentioned this pull request Aug 26, 2018
Rollup of 5 pull requests #53717
Merged

bors merged commit 2c61f3c into rust-lang:masterAug 26, 2018

Uh oh!

Uh oh!

Conversation

kzys commented Aug 23, 2018

Uh oh!

rust-highfive commented Aug 23, 2018

Uh oh!

rust-highfive commented Aug 23, 2018

Uh oh!

GuillaumeGomez commented Aug 23, 2018

Uh oh!

GuillaumeGomez commented Aug 23, 2018

Uh oh!

GuillaumeGomezAug 23, 2018

Choose a reason for hiding this comment

Uh oh!

kzysAug 23, 2018

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomezAug 23, 2018

Choose a reason for hiding this comment

Uh oh!

kzysAug 23, 2018

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomez commented Aug 23, 2018

Uh oh!

ehuss commented Aug 23, 2018

Uh oh!

GuillaumeGomez commented Aug 23, 2018

Uh oh!

GuillaumeGomez commented Aug 23, 2018

Uh oh!

bors commented Aug 23, 2018

Uh oh!

ehuss commented Aug 23, 2018

Uh oh!

GuillaumeGomez commented Aug 24, 2018

Uh oh!

kzys commented Aug 25, 2018

Uh oh!

ehuss commented Aug 25, 2018

Uh oh!

GuillaumeGomez commented Aug 25, 2018

Uh oh!

bors commented Aug 25, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants