Uh oh!
There was an error while loading. Please reload this page.
Update RLS - #53701
Merged
Merged
Conversation
rust-highfive
commented
Aug 25, 2018
Contributor
|
kennytm
commented
Aug 25, 2018
Member
@bors r+ p=79 |
bors
commented
Aug 25, 2018
Collaborator
📌 Commit 0741ed8a08eb7b3290522ff44842bab1dda38a92 has been approved by |
bors
commented
Aug 25, 2018
Collaborator
⌛ Testing commit 0741ed8a08eb7b3290522ff44842bab1dda38a92 with merge 2d1d3ccb2d5a820db27cdb670ed6f1eff29b4729... |
bors
commented
Aug 25, 2018
Collaborator
💔 Test failed - status-travis |
This comment has been minimized.
This comment has been minimized.
Member
Please exempt (cc serde-rs/json#474) |
This fixes 'cannot find macro `json_internal!` in this scope' RLS compilation error in Rust CI, presumably due to a local macro fix in serde_json 1.0.25 (serde-rs/json@e40cbad)
Xanewok
commented
Aug 25, 2018
ContributorAuthor
@kennytm done. |
kennytm
commented
Aug 25, 2018
Member
@bors r+ |
bors
commented
Aug 25, 2018
Collaborator
📌 Commit 3a17cf7 has been approved by |
kennytm
commented
Aug 25, 2018
Member
bors
commented
Aug 25, 2018
Collaborator
✌️ @Xanewok can now approve this pull request |
bors
commented
Aug 25, 2018
Collaborator
bors added a commit
that referenced
this pull request
Aug 25, 2018
Update RLS Continuation of #53610. Workspaces are tricky - the `json_internal` problem was only reproducible in Rust CI (not sure why it was only relevant to Windows?) and it seems that this was fixed by updating serde_json workspace-wide. Tested locally in Rust repo and it seems to be working. Nightlies are currently shipping without RLS, so it'd be great to include this in the next nightlies if possible.
bors
commented
Aug 25, 2018
Collaborator
☀️ Test successful - status-appveyor, status-travis |
rust-highfive
commented
Aug 25, 2018
Contributor
rust-highfive added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Aug 25, 2018
Tested on commit rust-lang/rust@39e6ba8. Direct link to PR: <rust-lang/rust#53701> 🎉 rls on windows: build-fail → test-pass. 🎉 rls on linux: build-fail → test-pass.
This was referenced Aug 25, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #53610.
Workspaces are tricky - the
json_internalproblem was only reproducible in Rust CI (not sure why it was only relevant to Windows?) and it seems that this was fixed by updating serde_json workspace-wide.Tested locally in Rust repo and it seems to be working.
Nightlies are currently shipping without RLS, so it'd be great to include this in the next nightlies if possible.