Uh oh!
There was an error while loading. Please reload this page.
Rollup of 21 pull requests - #53798
Closed
emilyalbini wants to merge 49 commits into
Closed
Conversation
It's a ~1% win on `keccak` and `inflate`.
In case that it is statically known that the OS doesn't support
`getrandom` (non-Linux) or becomes clear at runtime that `getrandom`
isn't available (`ENOSYS`), the opened fd ("/dev/urandom") isn't closed
after the function, so that future calls can reuse it. This saves
repeated `open`/`close` system calls at the cost of one permanently open
fd.
Additionally, this skips the initial zero-length `getrandom` call and
directly hands the user buffer to the operating system, saving one
`getrandom` syscall.This typo was introduced in rust-lang#47334. A couple tests bitrotted as a result, so we fix those too, and move them to a more sensible place.
`bad_style` is being deprecated in favor of `nonstandard_style`: - rust-lang#41646
This commit generalizes the existing `async_idents` lint to easily encompass other identifiers that will be keywords in future editions. The new lint is called `keyword_idents` and the old `async_idents` lint is registered as renamed to this new lint. As a proof of concept the `try` keyword was added to this list as it looks to be listed as a keyword in the 2018 edition only. The `await` keyword was not added as it's not listed as a keyword yet. Closesrust-lang#53077
…q-example, r=QuietMisdreavus Add another PartialEq example r? @steveklabnik
…omez Add example for Cow Add one more example that shows how to keep `Cow` in a struct. Link to playground: https://play.rust-lang.org/?gist=a9256bdd034b44bc3cdd0044bbcdbb7c&version=stable&mode=debug&edition=2015 Users ask this question in [ruRust](https://gitter.im/ruRust/general) chat time to time and it is not obvious to add `ToOwned<Owned=Target>` to requirements of generic params.
document effect of join on memory ordering Fixesrust-lang#45467
Use FxHash{Map,Set} instead of the default Hash{Map,Set} everywhere in rustc.
Most of the compiler uses the `Fx` hasher but some places ended up with the default one.…artial-eq, r=KodrAus Add partialeq implementation for TryFromIntError type Fixesrust-lang#53458.
… r=varkor Force-inline `shallow_resolve` at its hottest call site. It's a ~1% win on `keccak` and `inflate`.
set applicability Update a few more calls as described in rust-lang#50723 r? @estebank
Generalize `async_idents` to all new keywords This commit generalizes the existing `async_idents` lint to easily encompass other identifiers that will be keywords in future editions. The new lint is called `keyword_idents` and the old `async_idents` lint is registered as renamed to this new lint. As a proof of concept the `try` keyword was added to this list as it looks to be listed as a keyword in the 2018 edition only. The `await` keyword was not added as it's not listed as a keyword yet. Closesrust-lang#53077
…o_vis_matcher, r=cramertj Fix stabilisation version for macro_vis_matcher. r? @cramertj
…richton Reduce number of syscalls in `rand` This skips the initial zero-length `getrandom` call and directly hands the user buffer to the operating system, saving one `getrandom` syscall.
…, r=nikomatsakis Do not suggest dereferencing in macro Fixrust-lang#52783.
save-analysis: Differentiate foreign functions and statics.
add llvm-readobj to llvm-tools-preview Similar to readelf but supports more object formats (it seems). Particularly useful to inspect in detail sections (e.g. their flags) and symbols (e.g. their types). r? @alexcrichton cc @dvc94ch
fix a typo: taget_env -> target_env This typo was introduced in rust-lang#47334. A couple tests bitrotted as a result, so we fix those too, and move them to a more sensible place. Is there some lint we could turn on that would've caught this? It's a drag that cfg typos can silently pass through the compiler.
…etMisdreavus Rustdoc fixes Fixes rustdoc not scrolling to given lines and invalid unstable display: <img width="1440" alt="screen shot 2018-08-27 at 23 28 47" src="https://user-images.githubusercontent.com/3050060/44687252-06535e80-aa51-11e8-8512-d7d34d1cb963.png"> r? @QuietMisdreavus
expand keep-stage --help text
Fix typo in comment
move file-extension based .gitignore down to src/ Currently, it for example ignores `*.rlib` files in the repository root -- which I think is wrong; I sometimes get these files when I call rustc directly and I do want them cleaned up, not ignored. No such files are created during the normal build process.
Fix a comment in src/libcore/slice/mod.rs
…shearth Replace usages of 'bad_style' with 'nonstandard_style'. `bad_style` is being deprecated in favor of `nonstandard_style`: - rust-lang#41646
emilyalbini
commented
Aug 29, 2018
MemberAuthor
@bors r+ p=21 |
bors
commented
Aug 29, 2018
Collaborator
📌 Commit 31a6f9f has been approved by |
bors
commented
Aug 29, 2018
Collaborator
⌛ Testing commit 31a6f9f with merge 0ceb55e2bd9355363e066a62310b7d931516062e... |
bors
commented
Aug 29, 2018
Collaborator
💔 Test failed - status-travis |
rust-highfive
commented
Aug 29, 2018
Contributor
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
let x = bazwhich was obscuring the real error #53129 (removelet x = bazwhich was obscuring the real error)shallow_resolveat its hottest call site. #53513 (Force-inlineshallow_resolveat its hottest call site.)async_identsto all new keywords #53685 (Generalizeasync_identsto all new keywords)rand#53725 (Reduce number of syscalls inrand)Failed merges:
r? @ghost