Skip to content

[beta] const eval perf regression fix - #53825

Merged
bors merged 3 commits into
rust-lang:betafrom
oli-obk:beta_backport
Aug 31, 2018
Merged

[beta] const eval perf regression fix#53825
bors merged 3 commits into
rust-lang:betafrom
oli-obk:beta_backport

Conversation

@oli-obk

@oli-obkoli-obk commented Aug 30, 2018

Copy link
Copy Markdown
Contributor

backports #52925 (for #52849)

and additionally skips hashing on every evaluation step

@rust-highfive

rust-highfive commented Aug 30, 2018

Copy link
Copy Markdown
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive

rust-highfive commented Aug 30, 2018

Copy link
Copy Markdown
Contributor

⚠️Warning⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 30, 2018
@oli-obkoli-obk changed the title [beta][beta] const eval perf regression fixAug 30, 2018
@oli-obk

oli-obk commented Aug 30, 2018

Copy link
Copy Markdown
ContributorAuthor

r? @RalfJung

@RalfJung

RalfJung commented Aug 30, 2018

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Aug 30, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 860b257 has been approved by RalfJung

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 30, 2018
@oli-obk

oli-obk commented Aug 30, 2018

Copy link
Copy Markdown
ContributorAuthor

@bors p=1 beta regression fix

@oli-obk

oli-obk commented Aug 30, 2018

Copy link
Copy Markdown
ContributorAuthor

@bors r- we don't have official beta nomination yet

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 30, 2018
@RalfJung

RalfJung commented Aug 30, 2018

Copy link
Copy Markdown
Member

oops I clearly do not know the process.

r=me when you got the paperwork done. :P

@nikomatsakis

nikomatsakis commented Aug 30, 2018

Copy link
Copy Markdown
Contributor

@bors r=RalfJung

@bors

bors commented Aug 30, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 860b257 has been approved by RalfJung

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 30, 2018
@nikomatsakisnikomatsakis mentioned this pull request Aug 30, 2018
Merged
@emilyalbini

emilyalbini commented Aug 30, 2018

Copy link
Copy Markdown
Member

@bors p=30 (rollup fairness)

@bors

bors commented Aug 30, 2018

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 860b257 with merge b18e0c20f7c90dd93a83bda7f941a7dd20535494...

@bors

bors commented Aug 30, 2018

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-appveyor

@borsbors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 30, 2018
@borsbors added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 30, 2018
@oli-obk

oli-obk commented Aug 31, 2018

Copy link
Copy Markdown
ContributorAuthor

@bors retry (timout on one job, log says "success")

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 31, 2018
@bors

bors commented Aug 31, 2018

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 860b257 with merge 1daa912...

bors added a commit that referenced this pull request Aug 31, 2018
@bors
Auto merge of#53825- oli-obk:beta_backport, r=RalfJung
1daa912
[beta] const eval perf regression fix
backports #52925 (for #52849)
and additionally skips hashing on every evaluation step
@borsbors mentioned this pull request Aug 31, 2018
Merged
@bors

bors commented Aug 31, 2018

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-appveyor, status-travis
Approved by: RalfJung
Pushing 1daa912 to beta...

@bors
bors merged commit 860b257 into rust-lang:betaAug 31, 2018
@oli-obk
oli-obk deleted the beta_backport branch August 31, 2018 08:59
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@RalfJungRalfJung

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@oli-obk@rust-highfive@RalfJung@bors@nikomatsakis@emilyalbini