Add rustc SHA to released DWARF debuginfo by alexcrichton · Pull Request #53829 · rust-lang/rust

alexcrichton · 2018-08-30T17:29:40Z

This commit updates the debuginfo that is encoded in all of our released
artifacts by default. Currently it has paths like /checkout/src/... but these
are a little inconsistent and have changed over time. This commit instead
attempts to actually define the file paths in our debuginfo to be consistent
between releases.

All debuginfo paths are now intended to be /rustc/$sha where $sha is the git
sha of the released compiler. Sub-paths are all paths into the git repo at that
$sha.

rust-highfive · 2018-08-30T17:29:50Z

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

alexcrichton · 2018-08-30T17:30:33Z

r? @michaelwoerister

cc @luser, this will likely affect Gecko if we decide to merge!

cc @yurydelendik, I think this should do what you were requesting on IRC

@bors: try

I'd like to poke around these artifacts before landing to double check it's all as expected.

bors · 2018-08-30T17:30:44Z

⌛ Trying commit 8bdc6f79ac792303051bb23a053f7c45f4616267 with merge 5eaeeb3b3e3e2540410740229dcfc8b883091b10...

luser · 2018-08-30T17:36:27Z

Oh, excellent! We currently just fetch the sha from rustc --version -v and have a hardcoded list of paths we look for in debug info to map Rust stdlib sources back to the rust-lang/rust repo.

luser · 2018-08-30T17:37:56Z

One other thing to consider here would be trying to apply this to vendored C sources that you compile as well.

bors · 2018-08-30T19:53:48Z

☀️ Test successful - status-travis
State: approved= try=True

alexcrichton · 2018-08-30T21:05:52Z

Sure enough C code was still mentioning /checkout/..., good catch! I've updated to hopefully catch that as well.

@bors: try

bors · 2018-08-30T21:06:04Z

⌛ Trying commit 4b790ad1f8e78f61e2847058071b42a264e712f3 with merge 37655c8000de5017c6d28454888e55af3d6e5040...

alexcrichton · 2018-08-30T21:07:51Z

@bors: try

bors · 2018-08-30T21:08:01Z

⌛ Trying commit cc4c606 with merge 449328a...

Add rustc SHA to released DWARF debuginfo This commit updates the debuginfo that is encoded in all of our released artifacts by default. Currently it has paths like `/checkout/src/...` but these are a little inconsistent and have changed over time. This commit instead attempts to actually define the file paths in our debuginfo to be consistent between releases. All debuginfo paths are now intended to be `/rustc/$sha` where `$sha` is the git sha of the released compiler. Sub-paths are all paths into the git repo at that `$sha`.

rust-highfive · 2018-08-30T21:19:04Z

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

Requirement already satisfied: PyYAML<=3.13,>=3.10 in /usr/lib/python2.7/dist-packages (from awscli)
Collecting botocore==1.11.5 (from awscli)
/usr/local/lib/python2.7/dist-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:122: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. You can upgrade to a newer version of Python to solve this. For more information, see https://urllib3.readthedocs.io/en/latest/security.html#insecureplatformwarning.
InsecurePlatformWarning
Downloading https://files.pythonhosted.org/packages/9e/ef/5d6d9995946379e018bca8353271a3d7068daf5892f4bcdddd59faded358/botocore-1.11.5-py2.py3-none-any.whl (4.6MB)
0% | | 10kB 46.5MB/s eta 0:00:01
0% |▏ | 20kB 3.0MB/s eta 0:00:02
0% |▏ | 30kB 4.3MB/s eta 0:00:02
0% |▎ | 40kB 3.7MB/s eta 0:00:02
---
configure: processing command line
[00:01:56] configure: [00:01:56] configure: rust.dist-src := False
[00:01:56] configure: llvm.link-shared := True
[00:01:56] configure: rust.remap-debuginfo := True
[00:01:56] configure: rust.debug-assertions := True
[00:01:56] configure: llvm.assertions := True
[00:01:56] configure: build.locked-deps := True
[00:01:56] configure: llvm.ccache := sccache
---
travis_fold:start:make-tidy
travis_time:start:00a9761c
make -j 4 tidy
[00:04:24] Finished dev [unoptimized] target(s) in 0.26s
[00:04:25] thread 'main' panicked at 'failed to find rust sha', libcore/option.rs:989:5
[00:04:25] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:04:25] Build completed unsuccessfully in 0:00:01
[00:04:25] Build completed unsuccessfully in 0:00:01
[00:04:25] make: *** [tidy] Error 1
[00:04:25] Makefile:79: recipe for target 'tidy' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:006a786c
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_time:end:085f31be:start=1535663673272848064,finish=1535663673279712105,duration=6864041
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:09fb3340
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:24ebd880
travis_time:start:24ebd880
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:01b23418
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

bors · 2018-08-31T00:08:25Z

💔 Test failed - status-travis

rust-highfive · 2018-08-31T00:08:28Z

The job dist-x86_64-linux of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_fold:end:services
travis_fold:start:git.checkout
travis_time:start:0d1461e0
$ git clone --depth=2 --branch=try https://github.com/rust-lang/rust.git rust-lang/rust
---
Requirement already satisfied: PyYAML<=3.13,>=3.10 in /usr/lib/python2.7/dist-packages (from awscli)
Collecting botocore==1.11.5 (from awscli)
/usr/local/lib/python2.7/dist-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:122: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. You can upgrade to a newer version of Python to solve this. For more information, see https://urllib3.readthedocs.io/en/latest/security.html#insecureplatformwarning.
InsecurePlatformWarning
Downloading https://files.pythonhosted.org/packages/9e/ef/5d6d9995946379e018bca8353271a3d7068daf5892f4bcdddd59faded358/botocore-1.11.5-py2.py3-none-any.whl (4.6MB)
/usr/local/lib/python2.7/dist-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:122: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. You can upgrade to a newer version of Python to solve this. For more information, see https://urllib3.readthedocs.io/en/latest/security.html#insecureplatformwarning.
InsecurePlatformWarning
Downloading https://files.pythonhosted.org/packages/50/09/c53398e0005b11f7ffb27b7aa720c617aba53be4fb4f4f3f06b9b5c60f28/docutils-0.14-py2-none-any.whl (543kB)
Collecting pyasn1>=0.1.3 (from rsa<=3.5.0,>=3.1.2->awscli)
---
[00:04:28] configure: target.x86_64-unknown-linux-gnu.linker := clang
[00:04:28] configure: target.x86_64-unknown-linux-gnu.ar := /rustroot/bin/llvm-ar
[00:04:28] configure: target.x86_64-unknown-linux-gnu.ranlib := /rustroot/bin/llvm-ranlib
[00:04:28] configure: llvm.thin-lto := True
[00:04:28] configure: rust.remap-debuginfo := True
[00:04:28] configure: build.submodules := False
[00:04:28] configure: build.compiler-docs := True
[00:04:28] configure: build.profiler := True
[00:04:28] configure: build.locked-deps := True
---
[00:20:39] travis_fold:start:llvm
travis_time:start:llvm
Building LLVM for x86_64-unknown-linux-gnu
[00:20:39] running: "cmake" "/checkout/src/llvm" "-DLLVM_ENABLE_ASSERTIONS=OFF" "-DLLVM_TARGETS_TO_BUILD=X86;ARM;AArch64;Mips;PowerPC;SystemZ;MSP430;Sparc;NVPTX;Hexagon" "-DLLVM_EXPERIMENTAL_TARGETS_TO_BUILD=WebAssembly;RISCV" "-DLLVM_INCLUDE_EXAMPLES=OFF" "-DLLVM_INCLUDE_TESTS=OFF" "-DLLVM_INCLUDE_DOCS=OFF" "-DLLVM_ENABLE_ZLIB=OFF" "-DWITH_POLLY=OFF" "-DLLVM_ENABLE_TERMINFO=OFF" "-DLLVM_ENABLE_LIBEDIT=OFF" "-DLLVM_PARALLEL_COMPILE_JOBS=4" "-DLLVM_TARGET_ARCH=x86_64" "-DLLVM_DEFAULT_TARGET_TRIPLE=x86_64-unknown-linux-gnu" "-DLLVM_ENABLE_LTO=Thin" "-DLLVM_ENABLE_LLD=ON" "-DLLVM_OCAML_INSTALL_PATH=usr/lib/ocaml" "-DLLVM_LINK_LLVM_DYLIB=ON" "-DCMAKE_EXE_LINKER_FLAGS=-Wl,-Bsymbolic -static-libstdc++" "-DLLVM_ENABLE_LIBXML2=OFF" "-DCMAKE_C_COMPILER=sccache" "-DCMAKE_C_COMPILER_ARG1=clang" "-DCMAKE_CXX_COMPILER=sccache" "-DCMAKE_CXX_COMPILER_ARG1=clang++" "-DCMAKE_C_FLAGS=-ffunction-sections -fdata-sections -fPIC --target=x86_64-unknown-linux-gnu -fdebug-prefix-map=/checkout=/rustc/449328a8a8cf8e5b49cef91f38306d10036aeead" "-DCMAKE_CXX_FLAGS=-ffunction-sections -fdata-sections -fPIC --target=x86_64-unknown-linux-gnu -fdebug-prefix-map=/checkout=/rustc/449328a8a8cf8e5b49cef91f38306d10036aeead" "-DCMAKE_AR=/rustroot/bin/llvm-ar" "-DCMAKE_INSTALL_PREFIX=/checkout/obj/build/x86_64-unknown-linux-gnu/llvm" "-DCMAKE_BUILD_TYPE=Release"
[00:20:39] -- The CXX compiler identification is Clang 6.0.0
[00:20:39] -- The ASM compiler identification is Clang
[00:20:39] -- Found assembler: /usr/local/bin/sccache
[00:20:39] -- Check for working C compiler: /usr/local/bin/sccache
---
[01:16:44] travis_fold:start:llvm
travis_time:start:llvm
Building Emscripten LLVM for x86_64-unknown-linux-gnu
[01:16:44] running: "cmake" "/checkout/src/llvm-emscripten" "-DLLVM_ENABLE_ASSERTIONS=OFF" "-DLLVM_TARGETS_TO_BUILD=JSBackend" "-DLLVM_EXPERIMENTAL_TARGETS_TO_BUILD=" "-DLLVM_INCLUDE_EXAMPLES=OFF" "-DLLVM_INCLUDE_TESTS=OFF" "-DLLVM_INCLUDE_DOCS=OFF" "-DLLVM_ENABLE_ZLIB=OFF" "-DWITH_POLLY=OFF" "-DLLVM_ENABLE_TERMINFO=OFF" "-DLLVM_ENABLE_LIBEDIT=OFF" "-DLLVM_PARALLEL_COMPILE_JOBS=4" "-DLLVM_TARGET_ARCH=x86_64" "-DLLVM_DEFAULT_TARGET_TRIPLE=x86_64-unknown-linux-gnu" "-DLLVM_OCAML_INSTALL_PATH=usr/lib/ocaml" "-DCMAKE_EXE_LINKER_FLAGS=-Wl,-Bsymbolic -static-libstdc++" "-DLLVM_ENABLE_LIBXML2=OFF" "-DCMAKE_C_COMPILER=sccache" "-DCMAKE_C_COMPILER_ARG1=clang" "-DCMAKE_CXX_COMPILER=sccache" "-DCMAKE_CXX_COMPILER_ARG1=clang++" "-DCMAKE_C_FLAGS=-ffunction-sections -fdata-sections -fPIC --target=x86_64-unknown-linux-gnu -fdebug-prefix-map=/checkout=/rustc/449328a8a8cf8e5b49cef91f38306d10036aeead" "-DCMAKE_CXX_FLAGS=-ffunction-sections -fdata-sections -fPIC --target=x86_64-unknown-linux-gnu -fdebug-prefix-map=/checkout=/rustc/449328a8a8cf8e5b49cef91f38306d10036aeead" "-DCMAKE_AR=/rustroot/bin/llvm-ar" "-DCMAKE_INSTALL_PREFIX=/checkout/obj/build/x86_64-unknown-linux-gnu/llvm-emscripten" "-DCMAKE_BUILD_TYPE=Release"
[01:16:44] -- The CXX compiler identification is Clang 6.0.0
[01:16:44] -- The ASM compiler identification is Clang
[01:16:44] -- Found assembler: /usr/local/bin/sccache
[01:16:44] -- Check for working C compiler: /usr/local/bin/sccache
---
[01:38:40] travis_fold:start:lld
travis_time:start:lld
Building LLD for x86_64-unknown-linux-gnu
[01:38:40] running: "cmake" "/checkout/src/tools/lld" "-DCMAKE_C_COMPILER=sccache" "-DCMAKE_C_COMPILER_ARG1=clang" "-DCMAKE_CXX_COMPILER=sccache" "-DCMAKE_CXX_COMPILER_ARG1=clang++" "-DCMAKE_C_FLAGS=-ffunction-sections -fdata-sections -fPIC --target=x86_64-unknown-linux-gnu -fdebug-prefix-map=/checkout=/rustc/449328a8a8cf8e5b49cef91f38306d10036aeead" "-DCMAKE_CXX_FLAGS=-ffunction-sections -fdata-sections -fPIC --target=x86_64-unknown-linux-gnu -fdebug-prefix-map=/checkout=/rustc/449328a8a8cf8e5b49cef91f38306d10036aeead -static-libstdc++" "-DCMAKE_AR=/rustroot/bin/llvm-ar" "-DLLVM_CONFIG_PATH=/checkout/obj/build/bootstrap/debug/llvm-config-wrapper" "-DLLVM_INCLUDE_TESTS=OFF" "-DCMAKE_INSTALL_PREFIX=/checkout/obj/build/x86_64-unknown-linux-gnu/lld" "-DCMAKE_BUILD_TYPE=Release"
[01:38:40] -- The CXX compiler identification is Clang 6.0.0
[01:38:40] -- Check for working C compiler: /usr/local/bin/sccache
[01:38:40] -- Check for working C compiler: /usr/local/bin/sccache -- works
[01:38:40] -- Detecting C compiler ABI info

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

bors · 2018-08-31T04:17:12Z

☀️ Test successful - status-travis
State: approved= try=True

alexcrichton · 2018-08-31T05:22:51Z

Alright should be good to go!

r? @michaelwoerister

michaelwoerister · 2018-08-31T08:41:20Z

Why only Clang? Gcc should accept the same flag.

Oh sure! I was unaware of that
(eventually we'll need to figure out how to pass this to clang-cl as well)

clang-cl seems to accept it if you stick -Xclang before it, from cursory testing:
c:\build>c:\Users\ted\.mozbuild\clang\bin\clang-cl.exe -Fohello.obj -c c:\build\hello.c -Ic:\build -Z7 -Xclang -fdebug-prefix-map=c:\build=\src $ stringsext hello.obj | rg src \src\src\hello.c

michaelwoerister · 2018-08-31T08:48:06Z

Looks great, thanks Alex!

@bors r+

bors · 2018-08-31T08:48:06Z

📌 Commit 3286a6957193e34c1f20a2d0f0c15bcdcbab9462 has been approved by michaelwoerister

bors · 2018-09-12T17:31:01Z

⌛ Testing commit 5595aeb with merge 0ca767d460157af164fd4a7adb1cc7f61b8dfce4...

bors · 2018-09-12T18:30:13Z

💔 Test failed - status-travis

rust-highfive · 2018-09-12T18:30:15Z

The job dist-i686-linux of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_fold:end:step_upload_script
travis_fold:start:worker_info
Worker information
hostname: 3d549454-cfcc-43d5-b941-36a913e5fbce@1.production-4-worker-org-a-1-gce
version: v4.1.0-17-g600200d https://github.com/travis-ci/worker/tree/600200deddbb9114004580ec8d6dd7b4722840d9
startup: 7.880795643s
travis_fold:end:worker_info
travis_fold:start:system_info
Build system information
---
[00:46:53] [RUSTC-TIMING] rustc_allocator test:false 44.960
[00:47:16] Compiling rustc_traits v0.0.0 (file:///checkout/src/librustc_traits)
[00:47:18] [RUSTC-TIMING] rustc_incremental test:false 70.930
[00:48:08] [RUSTC-TIMING] rustc_traits test:false 51.878
The job exceeded the maximum time limit for jobs, and has been terminated.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

alexcrichton · 2018-09-12T18:46:49Z

@bors: retry

sigh

bors · 2018-09-12T23:52:19Z

⌛ Testing commit 5595aeb with merge e12dcff5e7e8f632039fe9b88e2c5cc7b91f171f...

bors · 2018-09-13T00:44:15Z

💔 Test failed - status-travis

rust-highfive · 2018-09-13T00:44:16Z

The job dist-aarch64-linux of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_fold:end:step_upload_script
travis_fold:start:worker_info
Worker information
hostname: f21fa5fc-9e6e-4623-9331-86b438669e8a@1.production-4-worker-org-a-1-gce
version: v4.1.0-17-g600200d https://github.com/travis-ci/worker/tree/600200deddbb9114004580ec8d6dd7b4722840d9
startup: 6.311264712s
travis_fold:end:worker_info
travis_fold:start:system_info
Build system information
---
[00:49:14] Compiling syntax_pos v0.0.0 (file:///checkout/src/libsyntax_pos)
[00:49:21] [RUSTC-TIMING] rustc_target test:false 16.620
[00:49:23] [RUSTC-TIMING] syntax_pos test:false 8.156
[00:49:23] Compiling rustc_errors v0.0.0 (file:///checkout/src/librustc_errors)
The job exceeded the maximum time limit for jobs, and has been terminated.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

alexcrichton · 2018-09-13T00:46:41Z

@bors: retry

mati865 · 2018-09-13T00:58:22Z

3rd failure because of 50-minute timeout. Travis broke?

kennytm · 2018-09-13T01:43:21Z

@mati865 Yes, and Travis is aware of the bug already.

bors · 2018-09-13T01:52:24Z

⌛ Testing commit 5595aeb with merge 48e6312571a6498927ddf63f91e3649e05e36ab9...

bors · 2018-09-13T02:44:13Z

💔 Test failed - status-travis

rust-highfive · 2018-09-13T02:44:15Z

The job dist-mips-linux of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_fold:end:step_upload_script
travis_fold:start:worker_info
Worker information
hostname: b026bde8-9bbb-4b04-b655-4ed64002dd41@1.production-4-worker-org-a-1-gce
version: v4.1.0-17-g600200d https://github.com/travis-ci/worker/tree/600200deddbb9114004580ec8d6dd7b4722840d9
startup: 6.228734054s
travis_fold:end:worker_info
travis_fold:start:system_info
Build system information
---
[00:49:24] [RUSTC-TIMING] rustc_data_structures test:false 5.462
[00:49:24] Compiling arena v0.0.0 (file:///checkout/src/libarena)
[00:49:25] [RUSTC-TIMING] arena test:false 0.619
[00:49:25] Compiling syntax_pos v0.0.0 (file:///checkout/src/libsyntax_pos)
The job exceeded the maximum time limit for jobs, and has been terminated.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

kennytm · 2018-09-13T03:26:42Z

@bors retry treeclosed=1

50 minute timeout

eddyb · 2019-03-15T08:10:24Z

 // except according to those terms.

+// ignore-musl
+// ignore-x86


I don't see this discussed explicitly. What is causing the problem these ignores are, well, ignoring? Was an issue ever opened to track it.
This showed up again in #58140 (comment), and while I'm fine with copying the two directives from here, this seems like a bug that should be tracked, if not investigated right away.

The failure happened here and I wasn't really interested in debugging this, but I agree I should have opened up an issue to track it.

rust-highfive assigned nikomatsakis Aug 30, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 30, 2018

rust-highfive assigned michaelwoerister and unassigned nikomatsakis Aug 30, 2018

alexcrichton force-pushed the release-debuginfo branch from 8bdc6f7 to 4b790adCompare August 30, 2018 21:04

alexcrichton force-pushed the release-debuginfo branch from 4b790ad to cc4c606Compare August 30, 2018 21:07

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 31, 2018

alexcrichton force-pushed the release-debuginfo branch from cc4c606 to 3286a69Compare August 31, 2018 05:22

michaelwoerister reviewed Aug 31, 2018
View reviewed changes

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 12, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 12, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 12, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 13, 2018

bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 13, 2018

kennytm mentioned this pull request Sep 13, 2018
Rollup of 11 pull requests #54168
Merged

michaelwoerister mentioned this pull request Sep 25, 2018
DWARF information does not contain absolute file locations for generics #54408
Closed

eddyb mentioned this pull request Sep 26, 2018
rustup component rust-src should be used to load cross-crate sources. #53486
Closed

kennytm mentioned this pull request Oct 28, 2018
Performance regression with rustc 1.30.0-nightly (2ab3eba30 2018-09-14) kennytm/cargo-kcov#35
Open

eddyb mentioned this pull request Mar 15, 2019
Refactor ppaux out of existence. #58140
Merged

eddyb reviewed Mar 15, 2019
View reviewed changes

Uh oh!

Uh oh!

Conversation

alexcrichton commented Aug 30, 2018

Uh oh!

rust-highfive commented Aug 30, 2018

Uh oh!

alexcrichton commented Aug 30, 2018

Uh oh!

bors commented Aug 30, 2018

Uh oh!

luser commented Aug 30, 2018

Uh oh!

luser commented Aug 30, 2018

Uh oh!

bors commented Aug 30, 2018

Uh oh!

alexcrichton commented Aug 30, 2018

Uh oh!

bors commented Aug 30, 2018

Uh oh!

alexcrichton commented Aug 30, 2018

Uh oh!

bors commented Aug 30, 2018

Uh oh!

rust-highfive commented Aug 30, 2018

Uh oh!

bors commented Aug 31, 2018

Uh oh!

rust-highfive commented Aug 31, 2018

Uh oh!

bors commented Aug 31, 2018

Uh oh!

alexcrichton commented Aug 31, 2018

Uh oh!

michaelwoeristerAug 31, 2018

Choose a reason for hiding this comment

Uh oh!

alexcrichtonAug 31, 2018

Choose a reason for hiding this comment

Uh oh!

luserAug 31, 2018

Choose a reason for hiding this comment

Uh oh!

michaelwoerister commented Aug 31, 2018

Uh oh!

bors commented Aug 31, 2018

Uh oh!

bors commented Sep 12, 2018

Uh oh!

bors commented Sep 12, 2018

Uh oh!

rust-highfive commented Sep 12, 2018

Uh oh!

alexcrichton commented Sep 12, 2018

Uh oh!

bors commented Sep 12, 2018

Uh oh!

bors commented Sep 13, 2018

Uh oh!

rust-highfive commented Sep 13, 2018

Uh oh!

alexcrichton commented Sep 13, 2018

Uh oh!

mati865 commented Sep 13, 2018

Uh oh!

kennytm commented Sep 13, 2018

Uh oh!

bors commented Sep 13, 2018

Uh oh!

bors commented Sep 13, 2018

Uh oh!

rust-highfive commented Sep 13, 2018

Uh oh!

kennytm commented Sep 13, 2018

Uh oh!

eddybMar 15, 2019

Choose a reason for hiding this comment

Uh oh!

alexcrichtonMar 15, 2019