Uh oh!
There was an error while loading. Please reload this page.
resolve: Future proof derive helper attributes - #54086
Conversation
rust-highfive
commented
Sep 9, 2018
r? @oli-obk (rust_highfive has picked a reviewer for you, use r? to override) |
petrochenkov
commented
Sep 9, 2018
petrochenkov
commented
Sep 9, 2018
@bors p=1 |
bors
commented
Sep 9, 2018
☔ The latest upstream changes (presumably #53778) made this pull request unmergeable. Please resolve the merge conflicts. |
alexcrichton
commented
Sep 11, 2018
@bors: r+ |
bors
commented
Sep 11, 2018
📌 Commit 8c49e4a41f9915d38a5802c3f1976f4d42ff51ae has been approved by |
bors
commented
Sep 12, 2018
🔒 Merge conflict This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again. How do I rebase?Assuming
You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial. Please avoid the "Resolve conflicts" button on GitHub. It uses Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Error message |
bors
commented
Sep 12, 2018
☔ The latest upstream changes (presumably #53913) made this pull request unmergeable. Please resolve the merge conflicts. |
petrochenkov
commented
Sep 13, 2018
@bors r=alexcrichton |
bors
commented
Sep 13, 2018
📌 Commit 2b3e98f has been approved by |
bors
commented
Sep 13, 2018
bors
commented
Sep 13, 2018
☀️ Test successful - status-appveyor, status-travis |
Derive helpers no longer require going through recovery mode (fixes#53481).
They also report an error if they are ambiguous with any other macro in scope, so we can resolve the question about their exact priority sometime later (cc #52226).