Uh oh!
There was an error while loading. Please reload this page.
add "temporary value borrowed for too long" error - #54164
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bors
commented
Sep 14, 2018
☔ The latest upstream changes (presumably #54088) made this pull request unmergeable. Please resolve the merge conflicts. |
There was a problem hiding this comment.
So, there is actually a standard template for these errors we ought to follow.
There was a problem hiding this comment.
I took a stab at a conformant write-up:
https://gist.github.com/nikomatsakis/10349c6242aad639b2e89eada6fffb7a
(you can get the raw text from there)
There was a problem hiding this comment.
Make sure to check over the examples in that gist; don't just cut-and-paste their content blindly. In particular, the fn bar's, starting on line 8, probably should be returning a &i32, not a i32.
(The code as written doesn't compile because it tries to dereference an i32, but that's not the error we are trying to illustrate here.)
There was a problem hiding this comment.
Note that, unless the example is tagged with ignore, we actually test this.
There was a problem hiding this comment.
(True; not everyone runs the full test suite locally, but the error would have been caught.)
There was a problem hiding this comment.
let's phrase this: "temporary value dropped while borrowed"
bors
commented
Sep 23, 2018
☔ The latest upstream changes (presumably #54310) made this pull request unmergeable. Please resolve the merge conflicts. |
pnkfelix
commented
Sep 24, 2018
@bors r+ |
bors
commented
Sep 24, 2018
📌 Commit 0397eb0 has been approved by |
pnkfelix
commented
Sep 24, 2018
(I want this to land asap because its effects are going to interact with whatever diagnostic I develop as our short-term fix for resolving #21114 ) |
bors
commented
Sep 24, 2018
⌛ Testing commit 0397eb0 with merge e6cba0cdbea6a8119bd0991f00edc1629a50ce3b... |
bors
commented
Sep 24, 2018
💔 Test failed - status-appveyor |
I'm pretty sure this needs to be rebased, because the diagnostic code it adds to (This is something that the Travis-autobuild on your pull request won't catch until you rebase, but bors will catch it during the trial merge after an |
pnkfelix
commented
Sep 25, 2018
@bors r+ |
bors
commented
Sep 25, 2018
📌 Commit d773f7c6a6d2ae9fc0a401991791cd4a299f5f50 has been approved by |
rust-highfive
commented
Sep 25, 2018
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
pnkfelix
commented
Sep 25, 2018
@bors r+ |
bors
commented
Sep 25, 2018
📌 Commit 2af199d has been approved by |
bors
commented
Sep 26, 2018
add "temporary value borrowed for too long" error Issue #54131 r? @nikomatsakis
bors
commented
Sep 26, 2018
☀️ Test successful - status-appveyor, status-travis |
Issue #54131
r? @nikomatsakis