Skip to content

Unsupport #[derive(Trait)] sugar for #[derive_Trait] legacy plugin attributes - #54271

Merged
bors merged 1 commit into
rust-lang:masterfrom
petrochenkov:nolegder
Dec 7, 2018
Merged

Unsupport #[derive(Trait)] sugar for #[derive_Trait] legacy plugin attributes#54271
bors merged 1 commit into
rust-lang:masterfrom
petrochenkov:nolegder

Conversation

@petrochenkov

@petrochenkovpetrochenkov commented Sep 16, 2018•
edited
Loading

Copy link
Copy Markdown
Contributor

This is a long deprecated unstable feature that doesn't mesh well with regular resolution/expansion.

How to fix broken code:

  • The recommended way is to migrate to stable procedural macros - derives or attributes (https://doc.rust-lang.org/nightly/book/first-edition/procedural-macros.html).
  • If you are using rocket 0.3.* in particular, the recommended solution is to migrate to rocket 0.4.*.
  • If that's not possible right now for some reason, you can keep code working with a simple mechanical replacement #[derive(Legacy)] -> #[derive_Legacy].

Closes#29644

r? @ghost

@petrochenkov

petrochenkov commented Sep 16, 2018

Copy link
Copy Markdown
ContributorAuthor

r? @alexcrichton

@bors

bors commented Sep 16, 2018

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #53461) made this pull request unmergeable. Please resolve the merge conflicts.

@borsbors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 16, 2018
@petrochenkovpetrochenkov added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 17, 2018
@petrochenkov

petrochenkov commented Sep 17, 2018•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

cc @SergioBenitez who reported about the feature still being used in Rocker in July.

That said, #[derive(Legacy)] -> #[derive_Legacy] is not a huge regression in usability (at least for nightly), even if the feature is still used.

@SergioBenitez

SergioBenitez commented Sep 17, 2018

Copy link
Copy Markdown
Contributor

We've migrated all of Rocket's derives to procedural macros. That being said, that migration is not yet part of an official release, so this would be a breaking change for almost all of Rocket's users.

If it's possible to delay this PR until Rocket sees a new release, which should happen in a matter of weeks as there is only a single blocking feature remaining, that would be much appreciated.

@petrochenkov

petrochenkov commented Sep 17, 2018

Copy link
Copy Markdown
ContributorAuthor

@SergioBenitez
Yeah, I think this can wait for a few weeks.
Is there any issue that I can subscribe to for tracking Rocket's release status?

@SergioBenitez

SergioBenitez commented Sep 17, 2018

Copy link
Copy Markdown
Contributor

@petrochenkov The 0.4 milestone tracks the missing features. Converting all of Rocket's code generation to proc-macros is tracked in rwf2/Rocket#693.

@petrochenkovpetrochenkov added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 18, 2018
@petrochenkovpetrochenkov mentioned this pull request Oct 17, 2018
Merged
@Centril

Centril commented Nov 10, 2018

Copy link
Copy Markdown
Contributor

@SergioBenitez what's the status now?

@SergioBenitez

SergioBenitez commented Nov 10, 2018

Copy link
Copy Markdown
Contributor

@Centril We are no longer using this in Rocket as of the the 0.4 release candidate. The GA of 0.4 has not yet been released; that should happen on the 14th. Ideally this wouldn't be merged until some time after the GA is available to give users a chance to migrate.

@nagisa

nagisa commented Dec 2, 2018

Copy link
Copy Markdown
Member

Rocket 0.4 is still not GA (is currently on -rc2, which has been published yesterday).

@petrochenkov

petrochenkov commented Dec 7, 2018

Copy link
Copy Markdown
ContributorAuthor

Yay.
@bors r=eddyb,alexcrichton

@bors

bors commented Dec 7, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 8ab115c has been approved by eddyb,alexcrichton

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Dec 7, 2018
@bors

bors commented Dec 7, 2018

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 8ab115c with merge a2fb99b...

bors added a commit that referenced this pull request Dec 7, 2018
@bors
Auto merge of#54271- petrochenkov:nolegder, r=eddyb,alexcrichton
a2fb99b
Unsupport `#[derive(Trait)]` sugar for `#[derive_Trait]` legacy plugin attributes
This is a long deprecated unstable feature that doesn't mesh well with regular resolution/expansion.
How to fix broken code:
- The recommended way is to migrate to stable procedural macros - derives or attributes (https://doc.rust-lang.org/nightly/book/first-edition/procedural-macros.html).
- If that's not possible right now for some reason, you can keep code working with a simple mechanical replacement `#[derive(Legacy)]` -> `#[derive_Legacy]`.
Closes#29644
r? @ghost
@bors

bors commented Dec 7, 2018

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-appveyor, status-travis
Approved by: eddyb,alexcrichton
Pushing a2fb99b to master...

@bors
bors merged commit 8ab115c into rust-lang:masterDec 7, 2018
This was referenced Dec 7, 2018
Merged
Merged
@borsbors mentioned this pull request Dec 7, 2018
Merged
@CentrilCentril mentioned this pull request Dec 31, 2018
Closed
@petrochenkov
petrochenkov deleted the nolegder branch June 5, 2019 16:24
@jieyouxujieyouxu mentioned this pull request Jul 28, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexcrichtonalexcrichtonalexcrichton approved these changes
+1 more reviewer
@eddybeddybeddyb approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@alexcrichtonalexcrichton

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tracking issue for custom_derive feature

7 participants

@petrochenkov@bors@SergioBenitez@Centril@nagisa@alexcrichton@eddyb