A few cleanups and minor improvements to typeck/check by ljedrz · Pull Request #54533 · rust-lang/rust

ljedrz · 2018-09-24T15:44:29Z

turn a loop into a while let
turn a push_back loop into an extend
turn a few push loops into collected iterators
prefer vec![x; n] to (0..n).map(|_| x).collect()
combine two loops doing the same thing on 2 data sets using chain
use unwrap_or where applicable and readable
add a potentially_plural_count helper function to simplify several format!() calls
prefer to_owned to to_string for string literals
change match to if let where only one branch matters
a few other minor improvements
whitespace fixes

rust-highfive · 2018-09-24T15:44:33Z

(rust_highfive has picked a reviewer for you, use r? to override)

…davis A few cleanups and minor improvements to typeck This PR complements rust-lang#54533, which was limited to `check`. - change a few `push` loops to `extend`s - prefer `to_owned` to `to_string` for string literals - prefer `if let` to `match` where only one branch matters - a few other minor improvements - whitespace fixes

ljedrz · 2018-09-27T08:19:50Z

Rebased.

davidtwco · 2018-09-27T08:53:47Z

@bors r+

bors · 2018-09-27T08:53:48Z

📌 Commit 3527276 has been approved by davidtwco

bors · 2018-09-27T16:54:35Z

⌛ Testing commit 3527276 with merge f1694ea...

A few cleanups and minor improvements to typeck/check - turn a `loop` into a `while let` - turn a `push_back` loop into an `extend` - turn a few `push` loops into collected iterators - prefer `vec![x; n]` to `(0..n).map(|_| x).collect()` - combine two loops doing the same thing on 2 data sets using `chain` - use `unwrap_or` where applicable and readable - add a `potentially_plural_count` helper function to simplify several `format!()` calls - prefer `to_owned` to `to_string` for string literals - change `match` to `if let` where only one branch matters - a few other minor improvements - whitespace fixes

bors · 2018-09-27T19:26:52Z

☀️ Test successful - status-appveyor, status-travis
Approved by: davidtwco
Pushing f1694ea to master...

A few cleanups and minor improvements to typeck This PR complements #54533, which was limited to `check`. - change a few `push` loops to `extend`s - prefer `to_owned` to `to_string` for string literals - prefer `if let` to `match` where only one branch matters - a few other minor improvements - whitespace fixes

rust-highfive assigned davidtwco Sep 24, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 24, 2018