Skip to content

update clippy submodule to a72e786c - #54561

Merged
bors merged 1 commit into
rust-lang:masterfrom
matthiaskrgr:clippy_up
Sep 26, 2018
Merged

update clippy submodule to a72e786c #54561
bors merged 1 commit into
rust-lang:masterfrom
matthiaskrgr:clippy_up

Conversation

@matthiaskrgr

@matthiaskrgrmatthiaskrgr commented Sep 25, 2018

Copy link
Copy Markdown
Member

No description provided.

@rust-highfive

rust-highfive commented Sep 25, 2018

Copy link
Copy Markdown
Contributor

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive

rust-highfive commented Sep 25, 2018

Copy link
Copy Markdown
Contributor

⚠️Warning⚠️

  • These commits modify submodules.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 25, 2018
@kennytm

kennytm commented Sep 26, 2018

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Sep 26, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 7703928f83366e90276299f1aed6fec4262ff575 has been approved by kennytm

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 26, 2018
@matthiaskrgr

matthiaskrgr commented Sep 26, 2018

Copy link
Copy Markdown
MemberAuthor

#53824 broke the clippy build so this won't pass CI in its current state.

I filed a PR to fix clippy and will update this PR once that is merged into clippy.

@kennytm

kennytm commented Sep 26, 2018

Copy link
Copy Markdown
Member

Ok.

@bors r-

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 26, 2018
@kennytmkennytm added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 26, 2018
@matthiaskrgr

matthiaskrgr commented Sep 26, 2018

Copy link
Copy Markdown
MemberAuthor

rebased to include fix-pr

@kennytm

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 26, 2018
@kennytm

kennytm commented Sep 26, 2018

Copy link
Copy Markdown
Member

Needs to update Cargo.lock...

@matthiaskrgr

matthiaskrgr commented Sep 26, 2018

Copy link
Copy Markdown
MemberAuthor

Ah yes, sorry, I forgot to git add that..

@matthiaskrgrmatthiaskrgr changed the title update clippy submodule to cdde22c2update clippy submodule to a72e786c Sep 26, 2018
@kennytm

kennytm commented Sep 26, 2018

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Sep 26, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 45f45e5 has been approved by kennytm

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 26, 2018
@bors

bors commented Sep 26, 2018

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 45f45e5 with merge ae7fe84...

bors added a commit that referenced this pull request Sep 26, 2018
@bors
Auto merge of#54561- matthiaskrgr:clippy_up, r=kennytm
ae7fe84
update clippy submodule to a72e786
@bors

bors commented Sep 26, 2018

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-appveyor, status-travis
Approved by: kennytm
Pushing ae7fe84 to master...

@bors
bors merged commit 45f45e5 into rust-lang:masterSep 26, 2018
@rust-highfive

rust-highfive commented Sep 26, 2018

Copy link
Copy Markdown
Contributor

📣 Toolstate changed by #54561!

Tested on commit ae7fe84.
Direct link to PR: #54561

🎉 clippy-driver on windows: build-fail → test-pass.
🎉 clippy-driver on linux: build-fail → test-pass.
🎉 rls on windows: build-fail → test-pass.
🎉 rls on linux: build-fail → test-pass.

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Sep 26, 2018
@rust-highfive
📣 Toolstate changed byrust-lang/rust#54561!
cf425dc
Tested on commit rust-lang/rust@ae7fe84.
Direct link to PR: <rust-lang/rust#54561>
🎉 clippy-driver on windows: build-fail → test-pass.
🎉 clippy-driver on linux: build-fail → test-pass.
🎉 rls on windows: build-fail → test-pass.
🎉 rls on linux: build-fail → test-pass.
@matthiaskrgr
matthiaskrgr deleted the clippy_up branch October 15, 2018 15:08
@pnkfelixpnkfelix mentioned this pull request Nov 12, 2018
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@aturonaturon

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@matthiaskrgr@rust-highfive@kennytm@bors@aturon