Skip to content

Remove useless lifetimes from Pinimpls. - #54598

Merged
bors merged 1 commit into
rust-lang:masterfrom
pthariensflame:patch-1
Sep 29, 2018
Merged

Remove useless lifetimes from Pinimpls.#54598
bors merged 1 commit into
rust-lang:masterfrom
pthariensflame:patch-1

Conversation

@pthariensflame

@pthariensflamepthariensflame commented Sep 26, 2018

Copy link
Copy Markdown
Contributor

These were evidently left in by accident when the new API was switched over to.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @sfackler

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 26, 2018
@sfackler

Copy link
Copy Markdown
Member

@bors r+ rollup

Thanks!

@bors

bors commented Sep 26, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit bb0abe9 has been approved by sfackler

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 26, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Sep 27, 2018
Remove useless lifetimes from `Pin` `impl`s.
These were evidently left in by accident when the new API was switched over to.
@kennytmkennytm mentioned this pull request Sep 27, 2018
@kennytmkennytm mentioned this pull request Sep 29, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Sep 29, 2018
Remove useless lifetimes from `Pin` `impl`s.
These were evidently left in by accident when the new API was switched over to.
bors added a commit that referenced this pull request Sep 29, 2018
Rollup of 8 pull requests
Successful merges:
- #54564 (Add 1.29.1 release notes)
- #54567 (Include path in stamp hash for debuginfo tests)
- #54577 (rustdoc: give proc-macros their own pages)
- #54590 (std: Don't let `rust_panic` get inlined)
- #54598 (Remove useless lifetimes from `Pin` `impl`s.)
- #54604 (Added help message for `self_in_typedefs` feature gate)
- #54635 (Improve docs for std::io::Seek)
- #54645 (Compute Android gdb version in compiletest)
@bors
bors merged commit bb0abe9 into rust-lang:masterSep 29, 2018
@pthariensflame
pthariensflame deleted the patch-1 branch January 17, 2019 00:44
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@pthariensflame@rust-highfive@sfackler@bors