Panic when using mem::uninitialized or mem::zeroed on an uninhabited type by RalfJung · Pull Request #54667 · rust-lang/rust

RalfJung · 2018-09-29T12:54:28Z

All code by @japaric. This re-submits one half of #53508. This is likely not the one that introduced the perf regression, but just to be sure I'll do a perf run anyway.

rust-highfive · 2018-09-29T12:54:31Z

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

RalfJung · 2018-09-29T13:06:31Z

@bors try

bors · 2018-09-29T13:06:43Z

⌛ Trying commit a1a74ab5ad7fae002fe65b388a19be7275536871 with merge cd661db2bccbe284334ee486254891e2858a667a...

bors · 2018-09-29T13:07:07Z

💔 Test failed - status-travis

RalfJung · 2018-09-29T13:22:06Z

It got cancelled by another try build. Try again.

@bors try

RalfJung · 2018-09-29T14:13:47Z

@bors retry

bors · 2018-09-29T14:13:57Z

⌛ Trying commit a1a74ab5ad7fae002fe65b388a19be7275536871 with merge 31ec4bcad01a3a5f6214474912ec7f53478414d7...

RalfJung · 2018-09-29T14:37:52Z

Dang, it's that gdb test again. :/ @japaric any idea?

RalfJung · 2018-09-29T14:39:56Z

Oh I see. I put all commits related to that test into the other PR because I though it was only about the changed data structures. But it is also about this panic.

RalfJung · 2018-09-29T17:22:04Z

@rust-timer build 31ec4bcad01a3a5f6214474912ec7f53478414d7

rust-timer · 2018-09-29T17:22:05Z

Success: Queued 31ec4bcad01a3a5f6214474912ec7f53478414d7 with parent 7e7bc06, comparison URL.

scottmcm · 2018-09-30T05:23:56Z

Perf came back; looks clean to me.

…zeroed}

oli-obk · 2018-10-01T07:00:24Z

@bors r+

bors · 2018-10-01T07:00:25Z

📌 Commit dd65d73 has been approved by oli-obk

bors · 2018-10-01T08:52:21Z

⌛ Testing commit dd65d73 with merge 48e45914f2f6dc7499fee2c031c06cf4b4c5ddf7...

pnkfelix · 2018-10-01T10:15:53Z

@bors r+

bors · 2018-10-01T10:15:54Z

💡 This pull request was already approved, no need to approve it again.

This pull request is currently being tested. If there's no response from the continuous integration service, you may use retry to trigger a build again.

bors · 2018-10-01T10:15:54Z

📌 Commit dd65d73 has been approved by pnkfelix

bors · 2018-10-01T14:58:32Z

⌛ Testing commit dd65d73 with merge de3d640...

@japaric

Panic when using mem::uninitialized or mem::zeroed on an uninhabited type All code by @japaric. This re-submits one half of #53508. This is likely not the one that introduced the perf regression, but just to be sure I'll do a perf run anyway.

bors · 2018-10-01T17:43:51Z

☀️ Test successful - status-appveyor, status-travis
Approved by: pnkfelix
Pushing de3d640 to master...

@japaric

Use MaybeUninit All code by @japaric. This re-submits the second half of #53508 (the first half is at #54667). This is likely the one containing the perf regression.

@japaric

Use MaybeUninit in libcore All code by @japaric. This re-submits the second half of #53508 (the first half is at #54667). This is likely the one containing the perf regression.

@japaric

Use MaybeUninit in libcore All code by @japaric. This re-submits the second half of #53508 (the first half is at #54667). This is likely the one containing the perf regression.

rust-highfive assigned cramertj Sep 29, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 29, 2018

RalfJung mentioned this pull request Sep 29, 2018
Use MaybeUninit in libcore #54668
Merged

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 29, 2018

This comment has been minimized.
Sign in to view

RalfJung force-pushed the maybe-uninit branch from a1a74ab to c64749bCompare September 29, 2018 15:04

RalfJung added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 29, 2018

This comment has been minimized.
Sign in to view

japaric added 6 commits September 30, 2018 17:26

panic when instantiating an uninhabited type via mem::{uninitialized,…
f9bbb5f
…zeroed}

use is_uninhabited in more places
bd3c781

improve panic message
7294fcd

move our check to reuse a previous computation
00ba5cb

improve the run-pass test
22cde0e

add empty enum to the test cases
0bf40d8

the test requires unwinding so we don't run it on the wasm32-bare target
dd65d73

RalfJung force-pushed the maybe-uninit branch from c64749b to dd65d73Compare September 30, 2018 15:31

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 1, 2018

bors merged commit dd65d73 into rust-lang:masterOct 1, 2018

This was referenced Oct 1, 2018
Lint uncallable function #54127
Closed
rustc_codegen_llvm: traitification of LLVM-specific CodegenCx and Builder methods #54012
Closed

RalfJung mentioned this pull request Oct 1, 2018
Tracking issue for RFC 1892, "Deprecate uninitialized in favor of a new MaybeUninit type" #53491
Closed
3 tasks

bors added a commit that referenced this pull request Oct 8, 2018
Auto merge of#54668- RalfJung:use-maybe-uninit, r=<try>
d4c1752
Use MaybeUninit All code by @japaric. This re-submits the second half of #53508 (the first half is at #54667). This is likely the one containing the perf regression.

RalfJung deleted the maybe-uninit branch November 9, 2018 15:35

Uh oh!

Uh oh!

Conversation

RalfJung commented Sep 29, 2018

Uh oh!

rust-highfive commented Sep 29, 2018

Uh oh!

RalfJung commented Sep 29, 2018

Uh oh!

bors commented Sep 29, 2018

Uh oh!

bors commented Sep 29, 2018

Uh oh!

RalfJung commented Sep 29, 2018

Uh oh!

RalfJung commented Sep 29, 2018

Uh oh!

bors commented Sep 29, 2018

Uh oh!

This comment has been minimized.

RalfJung commented Sep 29, 2018

Uh oh!

RalfJung commented Sep 29, 2018

Uh oh!

RalfJung commented Sep 29, 2018

Uh oh!

rust-timer commented Sep 29, 2018

Uh oh!

scottmcm commented Sep 30, 2018

Uh oh!

This comment has been minimized.

oli-obk commented Oct 1, 2018

Uh oh!

bors commented Oct 1, 2018

Uh oh!

bors commented Oct 1, 2018

Uh oh!

pnkfelix commented Oct 1, 2018

Uh oh!

bors commented Oct 1, 2018

Uh oh!

bors commented Oct 1, 2018

Uh oh!

bors commented Oct 1, 2018

Uh oh!

bors commented Oct 1, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants