Uh oh!
There was an error while loading. Please reload this page.
Stabilize disable-minification option - #54827
Conversation
QuietMisdreavus
commented
Oct 17, 2018
cc @rust-lang/rustdoc This is effectively a debugging flag, right? Has this flag received any major use? Are there any tests for this flag? (I'm curious how those would look...) Does the Rustdoc Book have any documentation about this flag? (We'll need to move it into the stable section, if so.) |
GuillaumeGomez
commented
Oct 19, 2018
Yes, yes (well, for me at least), no (not sure how to test it...), no idea. |
QuietMisdreavus
commented
Oct 24, 2018
I don't see anything on https://doc.rust-lang.org/nightly/rustdoc/unstable-features.html about this flag, so i assume that it has no docs. Can you add a section to the "Command-line arguments" page about this flag? To test, it depends on whether the minification will remove certain whitespace entirely. If so, we can use a regular rustdoc test to ensure that the minified version has some portion of a JS/CSS file with no whitespace in some location, and the non-minified version preserved that whitespace. (It's problematic because apparently |
TimNN
commented
Nov 13, 2018
Ping from triage @GuillaumeGomez: What is the status of this PR? |
GuillaumeGomez
commented
Nov 14, 2018
I need to add the documentation. |
TimNN
commented
Nov 20, 2018
Ping from triage @GuillaumeGomez: Do you think you'll be able to / have the time to continue working on this PR? |
GuillaumeGomez
commented
Nov 21, 2018
Yup yup. |
TimNN
commented
Nov 27, 2018
Ping from triage! This PR hasn't made any progress in a while, so I'm closing it for now. Thanks for your contributions and please feel free to re-open in the future. |
Fixes#54819.
r? @QuietMisdreavus